Fixed mongo instance locking bug #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISauve
force-pushed
the
isabelle/mongo
branch
from
bee1568
to
de41336
Compare
ISauve
changed the title
ISauve
force-pushed
the
isabelle/mongo
branch
from
de41336
to
678c7e9
Compare
Added use of 'nameOnly' tag when fetching database names for mongo versions >= 3.2
ISauve
force-pushed
the
isabelle/mongo
branch
from
678c7e9
to
a7281f8
Compare
ISauve
force-pushed
the
isabelle/mongo
branch
from
cceaba3
to
d85c066
Compare
gmmeyer
suggested changes
Oct 31, 2017
| @@ -862,7 +865,21 @@ def total_seconds(td): | |||
| except KeyError: | |||
| pass | |||
|
|
|||
| dbnames = cli.database_names() | |||
| cmd = SON([("listDatabases", 1)]) | |||
There was a problem hiding this comment.
Can you add a comment with a link to the code in the mongo driver here and a comment with a reminder to fix this after the upgrade is done!
|
PyMongo 3.5 already contains a fix for this issue - no need to wait for the next version to come out. This problem is fixed by #747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We currently use PyMongo's
database_names()command to fetch the names of all the databases; this in turn uses MongoDB'slistDatabasescommand. For Mongo versions >= 3.2, the command supports an additional fieldnameOnlywhich returns only the names of the databases and does not require database locks ( documentation ). PyMongo does not currently support this option, but the next version is supposed to, so this is just a temporary workaround until that version is released ( PyMongo changelog ).This PR checks which version of Mongo the user is running and calls the
listDatabasescommand directly, using thenameOnlyfield if the version is high enough.Motivation
#606
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsonCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?