upgrading pymongo to 3.5 #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyarimi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @olivielpeau and @gmmeyer to be potential reviewers. |
truthbk
requested changes
Oct 25, 2017
There was a problem hiding this comment.
Hi @tyarimi, could you please add the details to the changelog and bump the version in the manifest (as suggested by the PR template)?
Improvements looks straight-forward, we just need to go over the pymongo release notes to check if there's any change that could break anything.
Thank you! 👍
|
@truthbk I've made the changes. Any chance this gets reviewed soon? |
|
@truthbk can we get another look at this? |
2 tasks
|
Thank you @truthbk :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update pymongo to 3.5, as this version has a fix for the
database_names()function which make it faster.Motivation
Datadog agent is significantly slowing down mongo due to repetitive ListDatabases calls.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsonCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?