-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrading pymongo to 3.5 #747
Conversation
@tyarimi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @olivielpeau and @gmmeyer to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tyarimi, could you please add the details to the changelog and bump the version in the manifest (as suggested by the PR template)?
Improvements looks straight-forward, we just need to go over the pymongo
release notes to check if there's any change that could break anything.
Thank you! 👍
@truthbk I've made the changes. Any chance this gets reviewed soon? |
@truthbk can we get another look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're a star @tyarimi thank you 🙇
Thank you @truthbk :) |
What does this PR do?
Update pymongo to 3.5, as this version has a fix for the
database_names()
function which make it faster.Motivation
Datadog agent is significantly slowing down mongo due to repetitive ListDatabases calls.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.json
CHANGELOG.md
. Please useUnreleased
as the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?