Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change metadata errors log level #7897

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Change metadata errors log level #7897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2075e1
Change metadata errors log level
FlorianVeaux Oct 30, 2020
617e014
Fix tests
FlorianVeaux Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datadog_checks_base/datadog_checks/base/utils/metadata/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ def submit(self, name, value, options):
transformed = transformer(value, options)
except Exception as e:
if is_primitive(value):
self.logger.warning('Unable to transform `%s` metadata value `%s`: %s', name, value, e)
self.logger.debug('Unable to transform `%s` metadata value `%s`: %s', name, value, e)
else:
self.logger.warning('Unable to transform `%s` metadata: %s', name, e)
self.logger.debug('Unable to transform `%s` metadata: %s', name, e)

return

Expand Down Expand Up @@ -190,7 +190,7 @@ def transform_config(self, config, options):
if is_primitive(value):
field_data['value'] = value
else:
self.logger.warning(
self.logger.debug(
'Skipping metadata submission of non-primitive type `%s` for field `%s` in section `%s`',
type(value).__name__,
field,
Expand Down
16 changes: 8 additions & 8 deletions datadog_checks_base/tests/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def test_unknown_scheme(self, caplog):

expected_message = 'Unable to transform `version` metadata value `1.0.0`: Unsupported version scheme `foo`'
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand Down Expand Up @@ -162,7 +162,7 @@ def test_semver_invalid(self, caplog):

expected_prefix = 'Unable to transform `version` metadata value `1.0`: '
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message.startswith(expected_prefix):
if level == logging.DEBUG and message.startswith(expected_prefix):
break
else:
raise AssertionError('Expected ERROR log starting with message: {}'.format(expected_prefix))
Expand Down Expand Up @@ -247,7 +247,7 @@ def test_regex_no_pattern(self, caplog):
'Unable to transform `version` metadata value `1.0`: Version scheme `regex` requires a `pattern` option'
)
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand All @@ -266,7 +266,7 @@ def test_regex_no_match(self, caplog):
'Version does not match the regular expression pattern'
)
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand All @@ -285,7 +285,7 @@ def test_regex_no_subgroups(self, caplog):
'Regular expression pattern has no named subgroups'
)
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand Down Expand Up @@ -347,7 +347,7 @@ def test_parts_no_part_map(self, caplog):
'Version scheme `parts` requires a `part_map` option'
)
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand All @@ -365,7 +365,7 @@ def test_no_section(self, caplog):

expected_message = 'Unable to transform `config` metadata: The `section` option is required'
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand All @@ -387,7 +387,7 @@ def test_non_primitive(self, caplog):
'Skipping metadata submission of non-primitive type `list` for field `foo` in section `instance`'
)
for _, level, message in caplog.record_tuples:
if level == logging.WARNING and message == expected_message:
if level == logging.DEBUG and message == expected_message:
break
else:
raise AssertionError('Expected ERROR log with message: {}'.format(expected_message))
Expand Down