-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change metadata errors log level #7897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I agree with lowering the log level. Warning seems a bit aggressive and often raises concerns despite having little impact on the actual integration performance.
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
* Change metadata errors log level * Fix tests 5c29f21
Yeah, until/if metadata becomes a feature anything other than debug is noise |
Open to thoughts and comments.
Metadata collection is often problematic and we often see the
Unable to transform version metadata
because the version string doesn't exactly match the expected format.Most integrations are logging version metadata errors at the debug log level at the moment, this PR pushes the same id to the base class