Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metadata errors log level #7897

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Conversation

FlorianVeaux
Copy link
Member

Open to thoughts and comments.
Metadata collection is often problematic and we often see the Unable to transform version metadata because the version string doesn't exactly match the expected format.
Most integrations are logging version metadata errors at the debug log level at the moment, this PR pushes the same id to the base class

ChristineTChen
ChristineTChen previously approved these changes Oct 30, 2020
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I agree with lowering the log level. Warning seems a bit aggressive and often raises concerns despite having little impact on the actual integration performance.

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #7897 into master will decrease coverage by 0.31%.
The diff coverage is 27.27%.

Impacted Files Coverage Δ
datadog_checks_base/tests/test_metadata.py 92.46% <0.00%> (+0.90%) ⬆️
...ks_base/datadog_checks/base/utils/metadata/core.py 100.00% <100.00%> (ø)
ignite/tests/conftest.py 33.33% <0.00%> (-11.67%) ⬇️
ignite/tests/common.py 100.00% <0.00%> (ø)
consul/tests/test_unit.py 100.00% <0.00%> (ø)
php_fpm/tests/test_unit.py 100.00% <0.00%> (ø)
ambari/tests/test_common.py
apache/tests/conftest.py
ambari/datadog_checks/ambari/ambari.py
apache/tests/test_apache.py
... and 129 more

Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@FlorianVeaux FlorianVeaux merged commit 5c29f21 into master Oct 30, 2020
@FlorianVeaux FlorianVeaux deleted the florian/fix_metadata_log_level branch October 30, 2020 16:38
github-actions bot pushed a commit that referenced this pull request Oct 30, 2020
* Change metadata errors log level

* Fix tests 5c29f21
@hithwen
Copy link
Contributor

hithwen commented Nov 9, 2020

Yeah, until/if metadata becomes a feature anything other than debug is noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants