-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade isort #7539
Upgrade isort #7539
Conversation
@@ -40,6 +40,7 @@ default_section = 'THIRDPARTY' | |||
force_grid_wrap = 0 | |||
include_trailing_comma = true | |||
known_first_party = 'datadog_checks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: datadog_test_lib
can also be considered known_first_party
, but this can be done in another PRs to reduce the changelog for this PR. The goal of this PR is mainly about upgrading isort version.
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No docs impact
@@ -139,7 +139,7 @@ def add_style_formatter(config, sections, make_envconfig, reader): | |||
# Run formatter AFTER sorting imports | |||
'commands': '\n'.join( | |||
[ | |||
'isort --recursive .', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: --recursive
is not necessary anymore for isort v5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
What does this PR do?
Upgrade isort
Motivation
Was previously capped due to PyCQA/isort#1278 , but it's solved now.