Upgrade isort #7539
Merged
Upgrade isort #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
requested review from
trishankatdatadog and
a team
as code owners
ghost
added
AlexandreYang
commented
Sep 8, 2020
| @@ -40,6 +40,7 @@ default_section = 'THIRDPARTY' | |||
| force_grid_wrap = 0 | |||
| include_trailing_comma = true | |||
| known_first_party = 'datadog_checks' | |||
There was a problem hiding this comment.
note: datadog_test_lib can also be considered known_first_party, but this can be done in another PRs to reduce the changelog for this PR. The goal of this PR is mainly about upgrading isort version.
ofek
requested changes
Sep 8, 2020
Codecov Report
|
AlexandreYang
commented
Sep 9, 2020
AlexandreYang
commented
Sep 9, 2020
AlexandreYang
commented
Sep 10, 2020
| @@ -139,7 +139,7 @@ def add_style_formatter(config, sections, make_envconfig, reader): | |||
| # Run formatter AFTER sorting imports | |||
| 'commands': '\n'.join( | |||
| [ | |||
| 'isort --recursive .', | |||
There was a problem hiding this comment.
note: --recursive is not necessary anymore for isort v5
FlorianVeaux
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade isort
Motivation
Was previously capped due to PyCQA/isort#1278 , but it's solved now.