You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for reporting this issue! I believe the error here is that all skips were explicitly made relative to the config file location in 5.x.x, with no implied initial star. All that means for your configuration is that a star would be need to be placed before each glob for it to match, changing the config value to:
Hi,
In the following setup,
isort v5
is not working as expected. It's working fine withisort v4
.skip_glob
declared inpyproject.toml
is not working correctly forisort v5
.Setup
Content of
code.py
Content of
pyproject.toml
Command
With isort 5.5.1
With isort 4.3.21
Notes for isort 5.5.1
Using
--skip-glob
as command line argument does not work ifskip_glob
is not present inpyproject.toml
. But it does work, if absent.Without
skip_glob
inpyproject.toml
:With
skip_glob = 'datadog_checks/*/vendor/*'
inpyproject.toml
:Real life case:
https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=23283&view=logs&jobId=1a934b33-5d6c-528e-b666-73479c7a7fd1&j=1a934b33-5d6c-528e-b666-73479c7a7fd1&t=d7570bc9-350e-55d5-cbd3-a5ab30f91435
Related PR: DataDog/integrations-core#7539
The text was updated successfully, but these errors were encountered: