Update config spec default values #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
ChristineTChen
requested changes
Aug 12, 2020
mysql/assets/configuration/spec.yaml
Outdated
| @@ -33,7 +33,7 @@ files: | |||
| value: | |||
| type: string | |||
| example: localhost | |||
| default: None | |||
| default: '' | |||
There was a problem hiding this comment.
Do we need default here at all? Can it be removed?
There was a problem hiding this comment.
I think it could be left out- since it defaults to an empty string, it's hard to show that here
mysql/assets/configuration/spec.yaml
Outdated
| @@ -42,7 +42,7 @@ files: | |||
| value: | |||
| type: string | |||
| example: datadog | |||
| default: None | |||
| default: '' | |||
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mysql/assets/configuration/spec.yaml
Outdated
| @@ -58,7 +58,7 @@ files: | |||
| value: | |||
| type: number | |||
| example: 3306 | |||
| default: None | |||
| default: 0 | |||
There was a problem hiding this comment.
Suggested change
| default: 0 | |
| default: null |
Maybe here too? Or should default be the example since it's option is enabled
ChristineTChen
approved these changes
Aug 13, 2020
coignetp
pushed a commit
that referenced
this pull request
Aug 14, 2020
* Make config spec accurate * Remove default * Update default port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached