-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config spec default values #7340
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no docs to review
mysql/assets/configuration/spec.yaml
Outdated
@@ -33,7 +33,7 @@ files: | |||
value: | |||
type: string | |||
example: localhost | |||
default: None | |||
default: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need default here at all? Can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be left out- since it defaults to an empty string, it's hard to show that here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
mysql/assets/configuration/spec.yaml
Outdated
@@ -42,7 +42,7 @@ files: | |||
value: | |||
type: string | |||
example: datadog | |||
default: None | |||
default: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
mysql/assets/configuration/spec.yaml
Outdated
@@ -58,7 +58,7 @@ files: | |||
value: | |||
type: number | |||
example: 3306 | |||
default: None | |||
default: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default: 0 | |
default: null |
Maybe here too? Or should default be the example since it's option is enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure!
* Make config spec accurate * Remove default * Update default port
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached