Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor connection, improve documentation #7204

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Refactor connection, improve documentation #7204

merged 2 commits into from
Jul 28, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jul 24, 2020 •
edited
Loading

Refactor connection method, add tests. Improve configuration documentation and add more warnings.

Step prior to #7216

@hithwen hithwen requested review from a team as code owners July 24, 2020 10:44
@hithwen hithwen changed the title Refactor mysql connection, improve documentation Refactor connection, improve documentation Jul 24, 2020
@hithwen hithwen force-pushed the julia/msql-connect-refactor branch 2 times, most recently from b11b215 to 1bce318 Compare July 24, 2020 10:48
@codecov
Copy link

codecov bot commented Jul 24, 2020 •
edited
Loading

Codecov Report

Merging #7204 into master will decrease coverage by 9.89%.
The diff coverage is 98.11%.

Impacted Files Coverage Δ
mysql/datadog_checks/mysql/config.py 93.10% <80.00%> (ø)
mysql/datadog_checks/mysql/mysql.py 73.01% <100.00%> (ø)
mysql/tests/test_connection.py 100.00% <100.00%> (ø)
process/datadog_checks/process/__init__.py
ssh_check/datadog_checks/ssh_check/__init__.py
system_swap/tests/test_integration.py
process/datadog_checks/process/process.py
openstack/datadog_checks/openstack/__init__.py
openstack/datadog_checks/openstack/__about__.py
system_core/tests/conftest.py
... and 890 more

@hithwen hithwen force-pushed the julia/msql-connect-refactor branch from 1bce318 to 281f4f7 Compare July 24, 2020 10:58
@hithwen hithwen mentioned this pull request Jul 27, 2020
Merged
ChristineTChen
ChristineTChen previously approved these changes Jul 27, 2020
View reviewed changes
mysql/datadog_checks/mysql/config.py Outdated Show resolved Hide resolved
@hithwen hithwen merged commit 3897009 into master Jul 28, 2020
@hithwen hithwen deleted the julia/msql-connect-refactor branch July 28, 2020 09:51
@sarah-witt sarah-witt mentioned this pull request Aug 10, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen left review comments

Assignees
No one assigned
Labels
documentation integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hithwen @ChristineTChen