-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jaydebeapi and jpype1 #6963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the next step is to remove the patch from datadog-agent
repo. Could you link that PR once created ?
Codecov Report
|
jaydebeapi==1.1.1 | ||
jpype1==0.7.0 | ||
jaydebeapi==1.2.3 | ||
jpype1==0.7.1 ; python_version <= '2.7' # 0.7.5 it's not py2 compatible but this specific version breaks in py3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on py3 jaydebeapi will bring latest jpype: https://github.com/baztian/jaydebeapi/blob/master/setup.py#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we raise an issue on jaydebeapi
repo about that ?
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity. |
Update agent requirements file comment
getting an error on py3, but it works locally:
Locally I have 3.8.1 |
* Bump jaydebeapi and jpype1 * Add gcc and g++ to -jdbc docker image d2768d3
TL;DR: We're performing a patch on jaydebeapi that has been solved in newer versions. However the new version has different requirements on py2 and py3
Related to: baztian/jaydebeapi#117
Original patches:
Omnibus change: DataDog/datadog-agent#5830
Pinning jpype1==0.7.1 causes this error on py3:
Options are to pin jpype1 in py2 and py3 differently or pin
numpy>=1.16.0
as well