Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch jaydebeapy #4425

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Patch jaydebeapy #4425

merged 1 commit into from
Nov 13, 2019

Conversation

therve
Copy link
Contributor

@therve therve commented Nov 12, 2019 •
edited
Loading

We need to carry a custom patch for jaydebeapi as it doesn't support latest
jpype currently and no release is happening.

See baztian/jaydebeapi#107.

Originally submitted as #4402.

@therve therve requested review from a team as code owners November 12, 2019 14:59
@therve therve added this to the 6.16.0 milestone Nov 12, 2019
@therve therve added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. team/integrations component/config kind/packaging labels Nov 12, 2019
@therve therve force-pushed the revert-4424-revert-4402-therve/jpype-compat branch from 1aa573a to ed90930 Compare November 12, 2019 18:17
@albertvaka
Copy link
Contributor

This commits the exact same thing that got reverted. Is it intended?

@ofek
Copy link
Contributor

ofek commented Nov 12, 2019

@albertvaka We're investigating why it was failing only on 32-bit builds.

@ofek
Copy link
Contributor

ofek commented Nov 12, 2019

@albertvaka Do you know why?

@albertvaka
Copy link
Contributor

It seems this commit answers it ☝️

albertvaka
albertvaka previously approved these changes Nov 13, 2019
View reviewed changes
@therve therve force-pushed the revert-4424-revert-4402-therve/jpype-compat branch from 0b72a27 to ed90930 Compare November 13, 2019 13:27
ofek
ofek previously approved these changes Nov 13, 2019
View reviewed changes
@therve therve force-pushed the revert-4424-revert-4402-therve/jpype-compat branch from ed90930 to c322e9f Compare November 13, 2019 13:31
@therve therve merged commit 4f510bb into master Nov 13, 2019
@ofek ofek deleted the revert-4424-revert-4402-therve/jpype-compat branch November 13, 2019 19:23
xlucas pushed a commit that referenced this pull request Nov 18, 2019
@therve @xlucas
Revert "Revert "Patch jaydebeapi (#4402)" (#4424)" (#4425)
8f76982 
We need to carry a custom patch for jaydebeapi as it doesn't support latest
jpype currently and no release is happening.

See baztian/jaydebeapi#107.

Originally submitted as #4402.
@AlexandreYang AlexandreYang mentioned this pull request Dec 9, 2019
Merged
@hithwen hithwen mentioned this pull request Jun 24, 2020
Merged
@hithwen hithwen mentioned this pull request Jun 25, 2020
Merged
hithwen added a commit that referenced this pull request Jun 25, 2020
@hithwen
Revert "Revert "Revert "Patch jaydebeapi (#4402)" (#4424)" (#4425)"
ab45dbb 
This reverts commit 4f510bb.
KSerrania pushed a commit that referenced this pull request Aug 25, 2020
@hithwen
Revert "Revert "Revert "Patch jaydebeapi (#4402)" (#4424)" (#4425)" (#…
5154c05 
…5830)

Reverts changes added in #4425 and #4577.

Depends on: DataDog/integrations-core#6963 which bumps the dependency to a version that does not need the patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvaka albertvaka albertvaka approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
component/config [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. kind/packaging team/integrations
Projects
None yet
Milestone
7.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@therve @albertvaka @ofek