Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing style checks #6207

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Fix failing style checks #6207

merged 1 commit into from
Mar 31, 2020

Conversation

florimondmanca
Copy link
Contributor

What does this PR do?

Fix style checks on WinPDHCounter.

./datadog_checks/base/checks/win/winpdh.py:133:81: W291 trailing whitespace

Motivation

Makes datadog_checks_base tests fail on master.

Cleanup for #6052. Refs #6084 (comment)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested review from a team as code owners March 31, 2020 13:05
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #6207 into master will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted Files Coverage Δ
couch/datadog_checks/couch/couch.py 88.21% <0.00%> (-1.15%) ⬇️
postgres/tests/utils.py
gearmand/tests/test_integration_e2e.py
cockroachdb/tests/common.py
go_expvar/tests/conftest.py
squid/datadog_checks/squid/squid.py
php_fpm/datadog_checks/php_fpm/__init__.py
go_expvar/datadog_checks/go_expvar/__init__.py
airflow/datadog_checks/airflow/__init__.py
...nner/datadog_checks/gitlab_runner/gitlab_runner.py
... and 447 more

@hithwen hithwen mentioned this pull request Mar 31, 2020
Closed
@florimondmanca florimondmanca merged commit ddf7e55 into master Mar 31, 2020
@florimondmanca florimondmanca deleted the fix-pdh-style branch March 31, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florimondmanca @ofek @FlorianVeaux @mgarabed