-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @metadata_entrypoint
decorator
#6084
Conversation
Codecov Report
|
datadog_checks_base/datadog_checks/base/utils/metadata/decorators.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, not sure if I like this proposal - the extra import and decorator seems pretty heavy for a relatively light functionality benefit.
Updated the PR to reflect the latest state of discussions. Personally I'm a bit less convinced this is worth it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
|
CI failures are unrelated (E2E flakes, Envoy "No Go files…"), merging… |
What does this PR do?
Provide a decorator for automatically performing certain tasks associated to metadata collection.
Motivation
.check()
usage without having to create separate methods).Additional Notes
More explicit alternative to #6078
Refs #5748
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached