Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not_asserted aggregator stub function #2639

Merged
merged 1 commit into from
Nov 22, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions datadog_checks_base/datadog_checks/base/stubs/aggregator.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,11 +221,12 @@ def all_metrics_asserted(self):
assert self.metrics_asserted_pct >= 100.0

def not_asserted(self):
not_asserted = []
for mname, metric in iteritems(self._metrics):
if mname not in self._asserted:
not_asserted.append(metric)
return not_asserted
metrics_not_asserted = []
for metric in self._metrics:
metric = ensure_unicode(metric)
if metric not in self._asserted:
metrics_not_asserted.append(metric)
return metrics_not_asserted

def assert_metric_has_tag_prefix(self, metric_name, tag_prefix, count=None, at_least=1):
candidates = []
Expand Down