Fix not_asserted aggregator stub function #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
==========================================
- Coverage 83.9% 75.59% -8.31%
==========================================
Files 644 45 -599
Lines 36468 3237 -33231
Branches 4439 380 -4059
==========================================
- Hits 30597 2447 -28150
+ Misses 4555 694 -3861
+ Partials 1316 96 -1220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Python 3 compatibility
Additional Notes
Also made it return the more useful metric names instead of list of list of metric stubs. This function is only used in mysql tests and it won't be affected