Make the error message more clear in case a path is not accessible #2369
Conversation
| if not ignore_missing: | ||
| raise ConfigurationError(msg) | ||
|
|
||
| self.log.info(msg) |
There was a problem hiding this comment.
You're right, let's raise the log level at this point since permission errors will be eventually possible
Codecov Report
@@ Coverage Diff @@
## master #2369 +/- ##
==========================================
+ Coverage 79.56% 89.05% +9.49%
==========================================
Files 204 5 -199
Lines 13777 201 -13576
Branches 1460 35 -1425
==========================================
- Hits 10961 179 -10782
+ Misses 2428 18 -2410
+ Partials 388 4 -384 |
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| from datadog_checks.checks import AgentCheck | |||
| from datadog_checks.config import is_affirmative | |||
| from datadog_checks.errors import ConfigurationError | |||
There was a problem hiding this comment.
this exception only exists since #2367, shouldn't this be reflected on the version constraint of this integration on the datadog-checks-base wheel? (just asking, not sure what the policy is)
There was a problem hiding this comment.
We're still transitioning and very few of the checks pin the base check version, directory is one of those not pinning. At this moment there's not a real policy, we help users who need to update to manually setup the right set of packages in the agent on a case by case policy. This will change as soon as we outline the Agent CLI requirements for the single check update.
What does this PR do?
On Windows,
os.path.existsreturnsFalseboth when a directory doesn't exist and when the user can't access it for lack of permissions, we now mention this in the error message.Motivation
Since upcoming version of the Agent will run under an unprivileged user, a permission error will be possible in the future, let's be proactive.
Review checklist
no-changeloglabel attachedAdditional Notes
Logic doesn't change, it's just the error message