Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic error class ConfigurationError #2367

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Added generic error class ConfigurationError #2367

merged 1 commit into from
Oct 10, 2018

Conversation

masci
Copy link
Contributor

@masci masci commented Oct 10, 2018

What does this PR do?

See title

Motivation

We have a bunch of checks raising in case the config file is invalid and all of them redefine their own generic exception class, not a big deal but this way the code is more consistent

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

@codecov-io
Copy link

Codecov Report

Merging #2367 into master will decrease coverage by 37.5%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #2367       +/-   ##
===========================================
- Coverage   79.95%   42.44%   -37.51%     
===========================================
  Files         212       50      -162     
  Lines       14932     2980    -11952     
  Branches     1660      463     -1197     
===========================================
- Hits        11939     1265    -10674     
+ Misses       2551     1628      -923     
+ Partials      442       87      -355

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@masci masci merged commit 7290d86 into master Oct 10, 2018
@masci masci deleted the massi/directory branch October 10, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants