Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLINT-265] Update pyvmomi to 8.0.2.0.1 #16542

Merged
merged 4 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datadog_checks_base/changelog.d/16542.added
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update pyvmomi to 8.0.2.0.1
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ python-binary-memcached==0.26.1; sys_platform != 'win32' and python_version < '3
python-binary-memcached==0.31.2; sys_platform != 'win32' and python_version > '3.0'
python-dateutil==2.8.2
python3-gearman==0.1.0; sys_platform != 'win32' and python_version > '3.0'
pyvmomi==7.0.3
pyvmomi==8.0.2.0.1
pywin32==228; sys_platform == 'win32' and python_version < '3.0'
pywin32==306; sys_platform == 'win32' and python_version > '3.0'
pyyaml==5.4.1; python_version < '3.0'
Expand Down
1 change: 1 addition & 0 deletions vsphere/changelog.d/16542.added
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update pyvmomi to 8.0.2.0.1
6 changes: 3 additions & 3 deletions vsphere/datadog_checks/vsphere/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Any, Callable, List, TypeVar, cast # noqa: F401

from pyVim import connect
from pyVmomi import SoapAdapter, vim, vmodl
from pyVmomi import vim, vmodl
from six import itervalues

from datadog_checks.base.log import CheckLoggingAdapter # noqa: F401
Expand Down Expand Up @@ -332,7 +332,7 @@ def get_new_events(self, start_time):
query_filter.type = ALLOWED_EVENTS
try:
events = event_manager.QueryEvents(query_filter)
except SoapAdapter.ParserError as e:
except KeyError as e:
self.log.debug("Error parsing bulk events: %s", e)

if self.config.use_collect_events_fallback:
Expand Down Expand Up @@ -361,7 +361,7 @@ def _get_new_events_one_by_one(self, query_filter):
while True:
try:
collected_events = event_collector.ReadNextEvents(1) # Read with page_size=1
except SoapAdapter.ParserError as e:
except KeyError as e:
self.log.debug("Cannot parse event, skipped: %s", e)
continue
if len(collected_events) == 0:
Expand Down
2 changes: 1 addition & 1 deletion vsphere/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ license = "BSD-3-Clause"
[project.optional-dependencies]
deps = [
"futures==3.4.0; python_version < '3.0'",
"pyvmomi==7.0.3",
"pyvmomi==8.0.2.0.1",
]

[project.urls]
Expand Down
12 changes: 6 additions & 6 deletions vsphere/tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import pytest
from mock import ANY, MagicMock, patch
from pyVmomi import SoapAdapter, vim, vmodl
from pyVmomi import vim, vmodl

from datadog_checks.vsphere.api import APIConnectionError, VSphereAPI
from datadog_checks.vsphere.config import VSphereConfig
Expand Down Expand Up @@ -183,9 +183,9 @@ def test_get_new_events_failure_without_fallback(realtime_instance):
config = VSphereConfig(realtime_instance, {}, MagicMock())
api = VSphereAPI(config, MagicMock())

api._conn.content.eventManager.QueryEvents.side_effect = SoapAdapter.ParserError("some parse error")
api._conn.content.eventManager.QueryEvents.side_effect = KeyError("some parse error")

with pytest.raises(SoapAdapter.ParserError):
with pytest.raises(KeyError):
api.get_new_events(start_time=dt.datetime.now())


Expand All @@ -200,16 +200,16 @@ def test_get_new_events_with_fallback(realtime_instance):
event3 = vim.event.Event(key=3)
event_collector = MagicMock()
api._conn.content.eventManager.QueryEvents.side_effect = [
SoapAdapter.ParserError("some parse error"),
KeyError("some parse error"),
[event1],
SoapAdapter.ParserError("event parse error"),
KeyError("event parse error"),
[event3],
]
api._conn.content.eventManager.CreateCollectorForEvents.return_value = event_collector

event_collector.ReadNextEvents.side_effect = [
[event1],
SoapAdapter.ParserError("event parse error"),
KeyError("event parse error"),
[event3],
[],
]
Expand Down
Loading