Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the pymysql version to 1.1.0 on Python 3 #16042

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Bump the pymysql version to 1.1.0 on Python 3 #16042

merged 1 commit into from
Oct 19, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Oct 18, 2023 •
edited
Loading

What does this PR do?

Bump the pymysql version to 1.1.0 on Python 3

Motivation

  • This version was pinned in this PR because of a bug in the version 1.0.2
  • The bug got fixed in 1.0.3
  • The version we use does not officially support Python 3.11, so I'd like to bump it to 1.1.0 which does

Additional Notes

Relates to https://datadoghq.atlassian.net/browse/AITS-277

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #16042 (9bbe2ae) into master (7e109c2) will increase coverage by 0.11%.
Report is 13 commits behind head on master.
The diff coverage is n/a.

Flag Coverage Δ
activemq ?
cacti 87.90% <ø> (ø)
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
proxysql 98.97% <ø> (ø)
singlestore 90.81% <ø> (ø)
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@ghost ghost added the documentation label Oct 18, 2023
@FlorentClarret FlorentClarret mentioned this pull request Oct 18, 2023
Merged
3 tasks
@github-actions
Copy link

Test Results

     16 files       16 suites   18m 4s ⏱️
   172 tests    168 ✔️   4 💤 0 ❌
1 214 runs  1 197 ✔️ 17 💤 0 ❌

Results for commit 9bbe2ae.

@FlorentClarret FlorentClarret marked this pull request as ready for review October 18, 2023 10:03
@FlorentClarret FlorentClarret requested review from a team as code owners October 18, 2023 10:03
jmeunier28
jmeunier28 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@jmeunier28 jmeunier28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks!!

@FlorentClarret FlorentClarret merged commit 1eab2a7 into master Oct 19, 2023
45 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/bump_pymysql branch October 19, 2023 14:36
@FlorentClarret FlorentClarret mentioned this pull request Jan 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeunier28 jmeunier28 jmeunier28 approved these changes

@steveny91 steveny91 steveny91 approved these changes

@hestonhoffman hestonhoffman hestonhoffman approved these changes

Assignees
No one assigned
Labels
base_package dependencies documentation integration/cacti integration/mysql integration/proxysql integration/singlestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlorentClarret @jmeunier28 @steveny91 @hestonhoffman