Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pymysql to 0.10.1 #12612

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Pin pymysql to 0.10.1 #12612

merged 3 commits into from
Jul 28, 2022

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Jul 27, 2022 •
edited
Loading

What does this PR do?

We are currently shipping pymysql version 1.0.2, but there is a bug in this version, and there is no release with the fix yet. We have to revert this update until there is a new release of the library.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #12612 (28c8811) into master (77d1477) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
arangodb 98.21% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
cacti 83.95% <ø> (ø)
calico 83.33% <ø> (ø)
datadog_cluster_agent 90.00% <ø> (ø)
hazelcast 92.39% <ø> (ø)
ibm_i 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt changed the title Revert pymysql bump Pin pymysql to 1.0.2 Jul 27, 2022
@sarah-witt sarah-witt changed the title Pin pymysql to 1.0.2 Pin pymysql to 0.10.1 Jul 27, 2022
@sarah-witt
Copy link
Contributor Author

/azp run PR Comment All

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@sarah-witt
Copy link
Contributor Author

/azp run PR All Comment

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sarah-witt sarah-witt marked this pull request as ready for review July 27, 2022 21:54
@sarah-witt sarah-witt requested review from a team as code owners July 27, 2022 21:54
FlorentClarret
FlorentClarret approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sarah-witt sarah-witt merged commit d024413 into master Jul 28, 2022
@sarah-witt sarah-witt deleted the sarah/revert-pymysql-bump branch July 28, 2022 15:27
@sarah-witt sarah-witt mentioned this pull request Jul 28, 2022
Merged
4 tasks
@ofek ofek mentioned this pull request Aug 3, 2022
Merged
4 tasks
@hithwen
Copy link
Contributor

hithwen commented Aug 5, 2022

Note for QA: this is going to require manual testing for cacti since we do not have a cacti environment right now

@FlorentClarret FlorentClarret mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justiniso justiniso justiniso approved these changes

@vickenty vickenty vickenty approved these changes

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@fanny-jiang fanny-jiang fanny-jiang approved these changes

Assignees
No one assigned
Labels
dependencies integration/cacti integration/datadog_checks_base integration/mysql integration/proxysql integration/singlestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sarah-witt @hithwen @justiniso @vickenty @FlorentClarret @fanny-jiang