Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add can_use_jdbc to check_initializations #13521

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Do not add can_use_jdbc to check_initializations #13521

merged 1 commit into from
Dec 19, 2022

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Dec 14, 2022 •
edited
Loading

What does this PR do?

Do not add can_use_jdbc to check_initializations

Motivation

This is not really needed since those function are called during the first run, which is also the case for this.

QA for #13298

Additional Notes

This is definitely a nit PR, sorry

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret FlorentClarret requested review from a team as code owners December 14, 2022 15:46
@ghost ghost added the integration/oracle label Dec 14, 2022
yzhan289
yzhan289 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #13521 (59bc4ea) into master (786fa2e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
oracle 90.24% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret merged commit ce1b335 into master Dec 19, 2022
@FlorentClarret FlorentClarret deleted the florentclarret/oracle/qa-init branch December 19, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
integration/oracle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @yzhan289