-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Oracle check to use python-oracledb library #13298
Conversation
The |
Label |
The |
The |
The |
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Julia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing those changes, this looks good from a docs perspective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small documentation nits
Co-authored-by: Julia <[email protected]>
Co-authored-by: Julia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see lines in oracle.py
without test coverage but it has a 85%, and I guess that is ok for now
This PR actually increases in 2.80% the coverage of oracle.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
07324bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small nits!
@@ -165,44 +149,40 @@ def check(self, _): | |||
|
|||
@property | |||
def _connection(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a comment and is out of scope for this PR, but I think we should eventually abstract out the connection logic to another class, especially since the connection is conditional on either JDBC or oracle client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I think that was something I was planning on doing given more time but it definitely makes sense to do as a future PR.
Co-authored-by: Andrew Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
* test * edit and fix tests * fixed error description * style and remove pdb * validate deps * remove py2 env * remove , * fixed lone except * small fix * tcps * fix * fix * change readme * style fix * log line fix * fix e2e * fix e2e * fix dependency mismatch * Update oracle/README.md Co-authored-by: Bryce Eadie <[email protected]> * Update oracle/README.md Co-authored-by: Bryce Eadie <[email protected]> * Update oracle/README.md Co-authored-by: Bryce Eadie <[email protected]> * Update oracle/README.md Co-authored-by: Bryce Eadie <[email protected]> * edit and fix tests * update docs * fix * fix * fix * Update oracle/datadog_checks/oracle/oracle.py Co-authored-by: Julia <[email protected]> * Update oracle/README.md Co-authored-by: Julia <[email protected]> * Update oracle/README.md Co-authored-by: Julia <[email protected]> * Update oracle/datadog_checks/oracle/oracle.py Co-authored-by: Julia <[email protected]> * update docs * Update oracle/README.md Co-authored-by: Julia <[email protected]> * Update oracle/README.md Co-authored-by: Julia <[email protected]> * fix * add PY2 ConfigurationError * Update oracle/README.md Co-authored-by: Andrew Zhang <[email protected]> * fix Co-authored-by: Bryce Eadie <[email protected]> Co-authored-by: Julia <[email protected]> Co-authored-by: Andrew Zhang <[email protected]> ef596c3
What does this PR do?
This PR replaces the old
cx_Oracle
module with the newerpython-oracledb
. Since this only replacescx_Oracle
(Instant Client), we still need to keep the JDBC driver implementation for the customer base that still uses it because the documentation nor the source code forpython-oracledb
lists parameters that we can use to supplement the one's listed in our documentation when using SSL\TLS.Additional Notes
https://python-oracledb.readthedocs.io/en/latest/index.html
python-oracledb
only uses Python 3 so Python 2 environments are removed#13300 addresses the failing validations
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.