Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_error settings for grape #3370

Merged
merged 13 commits into from
Jan 10, 2024
Merged

on_error settings for grape #3370

merged 13 commits into from
Jan 10, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jan 8, 2024

2.0 Upgrade Guide notes

🚨 Breaking change for Grape instrumentation:

Replace error_statuses with error_status_codes. Change your configuration from string to array of ranges or integers.

For example:

Before:

Datadog.configure do |c|
  c.tracing.instrument :grape, error_statuses: '400,500-599'
end

After:

Datadog.configure do |c|
  c.tracing.instrument :grape, error_status_codes: [400, 500..599]
end

What does this PR do?

  1. Add on_error settings for grape instrumentation
  2. Replace error_statuses with error_status_codes settings for grape instrumentation

@TonyCTHsu TonyCTHsu changed the base branch from master to 2.0 January 8, 2024 15:40
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ea3035) 98.10% compared to head (6ea3035) 98.10%.

❗ Current head 6ea3035 differs from pull request most recent head a7405cd. Consider uploading reports for the commit a7405cd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3370   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files        1250     1250           
  Lines       72377    72377           
  Branches     3394     3394           
=======================================
  Hits        71009    71009           
  Misses       1368     1368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 8, 2024 20:33
@TonyCTHsu TonyCTHsu requested review from a team as code owners January 8, 2024 20:33
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style nits changing to present tense, avoiding temporal words, and fixing spacing before parenthetical. 👍

docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
@TonyCTHsu TonyCTHsu mentioned this pull request Jan 10, 2024
2 tasks
@TonyCTHsu TonyCTHsu merged commit dede2de into 2.0 Jan 10, 2024
151 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/grape-on-error-2.0 branch January 10, 2024 14:33
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions captured with rescue_from :all still appear in Error Tracking when using Grape integration
5 participants