-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on_error
settings for grape
#3370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3370 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 1250 1250
Lines 72377 72377
Branches 3394 3394
=======================================
Hits 71009 71009
Misses 1368 1368 ☔ View full report in Codecov by Sentry. |
05c0554
to
2e17696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small style nits changing to present tense, avoiding temporal words, and fixing spacing before parenthetical. 👍
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
8f1c670
to
af2af87
Compare
2.0 Upgrade Guide notes
🚨 Breaking change for Grape instrumentation:
Replace
error_statuses
witherror_status_codes
. Change your configuration from string to array of ranges or integers.For example:
Before:
After:
What does this PR do?
on_error
settings forgrape
instrumentationerror_statuses
witherror_status_codes
settings forgrape
instrumentation