-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on_error
settings for mysql2
#3316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two suggestions!
Co-authored-by: Austin Lai <[email protected]>
Co-authored-by: Edmund Kump <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 1253 1253
Lines 72766 72781 +15
Branches 3417 3417
==========================================
+ Hits 71481 71495 +14
- Misses 1285 1286 +1 ☔ View full report in Codecov by Sentry. |
Wow, this is amazing @TonyCTHsu, thank you! This is exactly what we are looking for! Question: do you think this is something we can also implement for the grape integration? We have this issue currently where we catch all exceptions using |
What does this PR do?
Add
on_error
settings formysql2
instrumentation.Motivation:
This proc provides the flexibility to handle exception that does not want to be reported.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.