Use updated JRubies in CircleCI

[lloeki]

What does this PR do?

Use JRubies built from #2412

How to test the change?

CI shoudl be green

[lloeki]

Bah, a commit went missing during rebase,

[lloeki]

@marcotc looks like we might have legit failures on JRuby 9.3.9.0, I threw a retry at it and the same expectations failed.

[ivoanjo]

The spec that failed is a weird one because different Rubies have different behaviors:

dd-trace-rb/spec/datadog/core/error_spec.rb

Lines 133 to 164 in 29c245e

	it 'reports errors only once', if: (RUBY_VERSION < '2.6.0' || PlatformHelpers.truffleruby?) do
	expect(error.type).to eq('RuntimeError')
	expect(error.message).to eq('first error')
	expect(error.backtrace).to match(/first error \(RuntimeError\).*second error \(RuntimeError\)/m)
	# Expect 2 "first-class" exception lines: 'first error' and 'second error'.
	expect(error.backtrace.each_line.reject { |l| l.start_with?("\tfrom") }).to have(2).items
	end
	it 'reports errors only once', if: (RUBY_VERSION >= '2.6.0' && PlatformHelpers.mri?) do
	expect(error.type).to eq('ArgumentError')
	expect(error.message).to eq('circular causes')
	expect(error.backtrace).to match(/circular causes \(ArgumentError\).*first error \(RuntimeError\)/m)
	# Expect 2 "first-class" exception lines: 'circular causes' and 'first error'.
	# Ruby doesn't report 'second error' as it was never successfully set as the cause of 'first error'.
	expect(error.backtrace.each_line.reject { |l| l.start_with?("\tfrom") }).to have(2).items
	end
	it 'reports errors only once', if: (RUBY_VERSION >= '2.6.0' && PlatformHelpers.jruby?) do
	expect(error.type).to eq('RuntimeError')
	expect(error.message).to eq('circular causes')
	expect(error.backtrace)
	.to match(/circular causes \(RuntimeError\).*first error \(RuntimeError\)/m)
	# Expect 3 "first-class" exception lines: 'circular causes', 'first error' and 'second error'.
	expect(error.backtrace.each_line.reject { |l| l.start_with?("\tfrom") }).to have(3).items
	end
	end

I guess JRuby has now adopted pre 2.6/TruffleRuby behavior?

[lloeki]

Changed base to depend on #2422

[lloeki]

I guess JRuby has now adopted pre 2.6/TruffleRuby behavior?

In the JRuby 9.3.7.0 release notes there's a reference to jruby/jruby#7267.

Circular exception handling can cause infinite loop since 9.3.4.0

Other releases (9.3.6.0, 9.3.9.0) don't seem to have reference to anything possibly related.

[ivoanjo]

👍 LGTM. Rubocop has a line-too-long complaint. Sigh, I hate this Rubocop rule -- you add one more character to a PR that worked and Rubocop breaks everything :(

[ivoanjo]

I suggest adding some parenthesis so people don't have to wonder about precedence ;)

Suggested change

	it 'reports errors only once', if: (RUBY_VERSION < '2.6.0' || PlatformHelpers.truffleruby? || PlatformHelpers.jruby? && RUBY_ENGINE_VERSION >= '9.3.7.0') do
	it 'reports errors only once', if: (RUBY_VERSION < '2.6.0' || PlatformHelpers.truffleruby? || (PlatformHelpers.jruby? && RUBY_ENGINE_VERSION >= '9.3.7.0')) do

[lloeki]

Add too much parentheses and Rubocop will complain :D

I would otherwise agree in general but I'm pretty sure most everyone knows the precedence between || and && so it's quire readable.