Update to JRuby 9.2.21.0 and 9.3.9.0 #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2412 +/- ##
==========================================
+ Coverage 98.33% 98.34% +0.01%
==========================================
Files 1101 1101
Lines 58946 58945 -1
==========================================
+ Hits 57964 57969 +5
+ Misses 982 976 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ivoanjo
reviewed
Nov 23, 2022
lloeki
force-pushed
the
update-jrubies
branch
from
3da112a to
0b38da4
Compare
github-actions
bot
removed
the
dev/ci
marcotc
approved these changes
Nov 23, 2022
Also a bit of alignment on 9.2.8.0
lloeki
force-pushed
the
update-jrubies
branch
from
c434082 to
546a7df
Compare
ivoanjo
added a commit
that referenced
this pull request
Jan 20, 2023
**What does this PR do?**: This PR disables testing of JRuby 9.2.8.0 in CI, as well as appraisal generation for it (as well as removes the existing appraisals). **Motivation**: Maintaining JRuby 9.2.8.0 working has been quite a burden: this version has many, many, many known issues -- you will notice that there have been **13** other bugfix releases on top of it; latest JRuby is 9.2.31.0. Some examples of PRs where this JRuby version caused toil are #2565, #2558, #2448, #2412, #1869, etc We've decided to stop running it in CI for now, and plan to evaluate if we should remove it entirely from our test harness. We recommend that all our customers use JRuby 9.2.21.0, and also recommend evaluating the move to JRuby 9.3, as the JRuby developers have marked JRuby 9.2 as end-of-life: <https://twitter.com/jruby/status/1611063274459566106>. **Additional Notes**: I didn't have to remove the appraisal gemfiles from the tree, but since I disabled the tasks that automatically keep them up-to-date, they wouldn't be maintained anyway. If/when we do want to revert this change, we should regenerate them using the usual rake tasks. **How to test the change?**: Validate that CI is green and that the JRuby 9.2.8.0 configuration is not shown there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built 9.3 from a buster base, vendored in to attempt to avoid any issues with bullseye.
Also, a bit of alignment on 9.2.8.0.
And removed the
-latestsuffixes as they don't mean much.