Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debugging): emit probe status updates unconditionally [backport #6714 to 1.16] #6742

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

P403n1x87
Copy link
Contributor

Backport of #6714 to 1.16

We ensure that probe status update are sent when due, regardless of whether the RCM worker has found new data. This fixes a regression introduced by the IPC refactor for the RCM client.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We ensure that probe status update are sent when due, regardless of
whether the RCM worker has found new data. This fixes a regression
introduced by the IPC refactor for the RCM client.

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Title is accurate.
- [ ] No unnecessary changes are introduced.
- [ ] Description motivates each change.
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [ ] Testing strategy adequately addresses listed risk(s).
- [ ] Change is maintainable (easy to change, telemetry, documentation).
- [ ] Release note makes sense to a user of the library.
- [ ] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 1726105)
@P403n1x87 P403n1x87 requested review from a team as code owners August 24, 2023 15:41
@P403n1x87 P403n1x87 requested a review from majorgreys August 24, 2023 15:41
@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Aug 24, 2023
@P403n1x87 P403n1x87 requested a review from juanjux August 24, 2023 15:41
@P403n1x87 P403n1x87 self-assigned this Aug 24, 2023
@P403n1x87 P403n1x87 enabled auto-merge (squash) August 24, 2023 15:41
@pr-commenter
Copy link

pr-commenter bot commented Aug 25, 2023

Benchmarks

Benchmark execution time: 2023-08-25 12:07:09

Comparing candidate commit eda4d91 in PR branch backport-6714-to-1.16 with baseline commit c6dbd64 in branch 1.16.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 94 metrics, 0 unstable metrics.

@P403n1x87 P403n1x87 merged commit 759f3f7 into 1.16 Aug 25, 2023
@P403n1x87 P403n1x87 deleted the backport-6714-to-1.16 branch August 25, 2023 14:27
@github-actions
Copy link
Contributor

The backport to 1.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.16 1.16
# Navigate to the new working tree
cd .worktrees/backport-1.16
# Create a new branch
git switch --create backport-6742-to-1.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 759f3f7573c4ee566376e71388ad61ee4ec2e3e7
# Push it to GitHub
git push --set-upstream origin backport-6742-to-1.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.16

Then, create a pull request where the base branch is 1.16 and the compare/head branch is backport-6742-to-1.16.

@github-actions
Copy link
Contributor

The backport to 1.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.18 1.18
# Navigate to the new working tree
cd .worktrees/backport-1.18
# Create a new branch
git switch --create backport-6742-to-1.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 759f3f7573c4ee566376e71388ad61ee4ec2e3e7
# Push it to GitHub
git push --set-upstream origin backport-6742-to-1.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.18

Then, create a pull request where the base branch is 1.18 and the compare/head branch is backport-6742-to-1.18.

github-actions bot pushed a commit that referenced this pull request Aug 25, 2023
…6714 to 1.16] (#6742)

Backport of #6714 to 1.16

We ensure that probe status update are sent when due, regardless of
whether the RCM worker has found new data. This fixes a regression
introduced by the IPC refactor for the RCM client.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 759f3f7)
@github-actions github-actions bot added this to the v1.16.2 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants