fix(debugging): ensure dynamic instrumentation enabled #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P403n1x87
added
the
changelog/no-changelog
|
This PR needs to wait until the |
P403n1x87
added
Dynamic Instrumentation
P403n1x87
force-pushed
the
fix/di-enable-programmatic-api
branch
from
994ae99 to
d37f0d1
Compare
With the introduction of exception debugging, the new enablement logic caused the dynamic instrumentation to not register with the remoteconfig client when the programmatic API was used, unless DD_DYNAMIC_INSTRUMENTATION_ENABLED is also set. Since this is not the documented behaviour, we make this fix to align with the expected behaviour of the programmatic API.
P403n1x87
force-pushed
the
fix/di-enable-programmatic-api
branch
from
d37f0d1 to
8ecf424
Compare
|
Requires #6714 to remove test flakiness |
emmettbutler
approved these changes
Aug 24, 2023
mabdinur
approved these changes
Aug 25, 2023
brettlangdon
approved these changes
Aug 25, 2023
16 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
With the introduction of exception debugging, the new enablement logic caused the dynamic instrumentation to not register with the remoteconfig client when the programmatic API was used, unless `DD_DYNAMIC_INSTRUMENTATION_ENABLED` is also set. Since this is not the documented behaviour, we make this fix to align with the expected behaviour of the programmatic API. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Title is accurate. - [ ] No unnecessary changes are introduced. - [ ] Description motivates each change. - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Testing strategy adequately addresses listed risk(s). - [ ] Change is maintainable (easy to change, telemetry, documentation). - [ ] Release note makes sense to a user of the library. - [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit c98875a)
mabdinur
added a commit
that referenced
this pull request
Aug 28, 2023
#6763) Backport c98875a from #6618 to 1.18. With the introduction of exception debugging, the new enablement logic caused the dynamic instrumentation to not register with the remoteconfig client when the programmatic API was used, unless `DD_DYNAMIC_INSTRUMENTATION_ENABLED` is also set. Since this is not the documented behaviour, we make this fix to align with the expected behaviour of the programmatic API. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Gabriele N. Tornetta <[email protected]> Co-authored-by: Munir Abdinur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of exception debugging, the new enablement logic caused the dynamic instrumentation to not register with the remoteconfig client when the programmatic API was used, unless
DD_DYNAMIC_INSTRUMENTATION_ENABLEDis also set. Since this is not the documented behaviour, we make this fix to align with the expected behaviour of the programmatic API.Checklist
changelog/no-changelog.Reviewer Checklist