Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL Blocking #3819
GraphQL Blocking #3819
Changes from all commits
ca016be
7233810
007204a
1bee1ae
6113ee1
f8c52e9
7f05909
ece953f
2aa7488
3c7d6a7
d74cf95
51640f2
a2ed730
a8f2186
464ad05
b2fb5d6
f45d1ed
d195082
4ad350c
a059bfd
76483a0
e982e80
6498d9f
3f5653b
5dd121b
7cc8bba
7542f8a
bbcebcf
71a3524
d9d8050
e417adb
fe6edbb
2410db5
df4d73d
61b18ac
c944acc
9ce8d98
cf7baa8
9cba641
12427b3
82db1d4
1a238bf
a685a01
1d4524f
46039a7
727456e
35d4aeb
5c293ee
d9e6ce3
7cc8561
62dc02a
a941309
d94df58
80a4e01
08b3b2b
e310e5c
5fbb4c5
8be2238
204b405
3416b3f
0347483
1b1d481
4c5578b
44187c6
c820226
a293f51
c45af94
26f64d0
b4a23e6
80b3c21
026aaaa
0b83ea1
8f427dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is breaking to me.
I am using KeystoneJS and the schema generated is not returning
directives
sometimes.For example:
Of course, the error I am getting is:
TypeError: directives is not iterable
.Should we validate if
directives
is effectively iterable before thefor
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll investigate and fix this bug as fast as possible. Thank you for reporting the issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @simon-id! I've just created an issue with the same topic and more details 😄
#4097
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow perfect, I was about to create one too. Thank you for being proactive and let's continue this discussion there.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.