-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datadog-plugin-graphql is not validating if directives is an array #4097
Comments
Once again, thank you for reporting this issue with detailed infos. We'll look into it asap and update the thread when we have news. Although this issue won't be resolved until next week as it's already friday afternoon for us :/ |
Thank you @simon-id! No rush at all 😄 |
Hey guys,
After this PR, I started having an issue with this line (mentioned in a late comment by myself also).
I am using a product called: KesytoneJS and the schema that it generates does not always return directives. For example:
Finally, the error I am getting is:
TypeError: directives is not iterable
.I keep my project working with version
4.21.0
that doesn't have that change, but now I have a high dependabot issue due to that version is usinglodash.pick
.It looks like Lodash doesn't have a patch version yet: GHSA-p6mc-m468-83gw.
It looks like Datadog just removed the dependency in new versions:
Should we validate if
directives
is effectively iterable before thefor
?I've tried to push a fix for this, but I am getting 403 when I push 🥲 I think we should do something like:
Thanks in advance!
The text was updated successfully, but these errors were encountered: