Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer json parsing probe definition #7957

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix integer json parsing probe definition #7957

merged 1 commit into from
Nov 15, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Nov 14, 2024 •
edited by jira bot
Loading

What Does This Do

Following #7676 issue, numbers parsed from the json probe definition are still considered as long value which still makes then unfittable to be used as key for Integer -> Integer map.
Now we parse integers (without dot numbers) as long and see if they fit into an integer, then downgrade them as DSL value with integer type.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3131

@jpbempel
Fix integer json parsing probe definition
fd1bd00 
Following #7676 issue, numbers parsed from the json probe definition
are still considered as long value which still makes then unfittable
to be used as key for Integer -> Integer map.
Now we parse integers (without dot numbers) as long and see if they
fit into an integer, then downgrade them as DSL value with integer
type.
@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels Nov 14, 2024
@jpbempel jpbempel requested a review from a team as a code owner November 14, 2024 16:55
@jpbempel jpbempel requested review from evanchooly and removed request for a team November 14, 2024 16:55
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1731603866 1731604242
end_time 2024-11-14T17:05:41 2024-11-14T17:11:56
git_branch master jpbempel/fix-int-parsing-probe-def
git_commit_sha 105c9dc fd1bd00
start_time 2024-11-14T17:04:27 2024-11-14T17:10:43
See matching parameters
Baseline Candidate
ci_job_id 707384235 707384235
ci_pipeline_id 49042162 49042162
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1731603283 1731603283

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+441.016µs; +517.992µs] or [+4.341%; +5.098%]		 worse
[+429.027µs; +525.685µs] or [+4.154%; +5.090%]		 worse
[+414.994µs; +536.159µs] or [+3.986%; +5.149%]		 worse
[+373.488µs; +757.146µs] or [+3.481%; +7.058%]		 worse
[-4.780op/s; -3.122op/s] or [-4.995%; -3.262%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-27.771µs; +17.920µs] or [-10.565%; +6.818%]		 unstable
[-44.520µs; +23.720µs] or [-14.643%; +7.802%]		 unstable
[-59.817µs; +31.152µs] or [-18.681%; +9.729%]		 unstable
[-111.134µs; +79.674µs] or [-18.228%; +13.068%]		 same
scenario:basic same same same unstable
[-49.155µs; +45.915µs] or [-9.188%; +8.582%]		 same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (304.038 µs) : 263, 345
.   : milestone, 304,
basic (298.536 µs) : 289, 308
.   : milestone, 299,
loop (10.329 ms) : 10289, 10369
.   : milestone, 10329,
section candidate
noprobe (293.638 µs) : 273, 315
.   : milestone, 294,
basic (300.982 µs) : 292, 310
.   : milestone, 301,
loop (10.806 ms) : 10757, 10855
.   : milestone, 10806,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 304.038 µs [263.064 µs, 345.011 µs]
basic 298.536 µs [289.111 µs, 307.962 µs]
loop 10.329 ms [10.289 ms, 10.369 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 293.638 µs [272.663 µs, 314.613 µs]
basic 300.982 µs [292.044 µs, 309.919 µs]
loop 10.806 ms [10.757 ms, 10.855 ms]

@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-int-parsing-probe-def
git_commit_date 1731601861 1731603283
git_commit_sha 105c9dc fd1bd00
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~fd1bd009d1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731605729 1731605729
ci_job_id 707384227 707384227
ci_pipeline_id 49042162 49042162
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085914
Total [baseline] (10.454 s) : 0, 10454475
Agent [candidate] (1.086 s) : 0, 1086235
Total [candidate] (10.459 s) : 0, 10458580
section appsec
Agent [baseline] (1.222 s) : 0, 1222193
Total [baseline] (10.72 s) : 0, 10719540
Agent [candidate] (1.218 s) : 0, 1217917
Total [candidate] (10.742 s) : 0, 10741845
section iast
Agent [baseline] (1.21 s) : 0, 1209596
Total [baseline] (10.943 s) : 0, 10942650
Agent [candidate] (1.211 s) : 0, 1210765
Total [candidate] (10.913 s) : 0, 10913109
section profiling
Agent [baseline] (1.283 s) : 0, 1282899
Total [baseline] (10.808 s) : 0, 10808410
Agent [candidate] (1.29 s) : 0, 1289979
Total [candidate] (10.864 s) : 0, 10863642
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.222 s 136.28 ms (12.5%)
Agent iast 1.21 s 123.682 ms (11.4%)
Agent profiling 1.283 s 196.985 ms (18.1%)
Total tracing 10.454 s -
Total appsec 10.72 s 265.065 ms (2.5%)
Total iast 10.943 s 488.175 ms (4.7%)
Total profiling 10.808 s 353.935 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.218 s 131.682 ms (12.1%)
Agent iast 1.211 s 124.53 ms (11.5%)
Agent profiling 1.29 s 203.744 ms (18.8%)
Total tracing 10.459 s -
Total appsec 10.742 s 283.265 ms (2.7%)
Total iast 10.913 s 454.529 ms (4.3%)
Total profiling 10.864 s 405.063 ms (3.9%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.146 ms) : 0, 689146
BytebuddyAgent [candidate] (689.062 ms) : 0, 689062
GlobalTracer [baseline] (316.637 ms) : 0, 316637
GlobalTracer [candidate] (317.923 ms) : 0, 317923
AppSec [baseline] (54.266 ms) : 0, 54266
AppSec [candidate] (54.201 ms) : 0, 54201
Remote Config [baseline] (673.785 µs) : 0, 674
Remote Config [candidate] (674.208 µs) : 0, 674
Telemetry [baseline] (11.429 ms) : 0, 11429
Telemetry [candidate] (10.562 ms) : 0, 10562
section appsec
BytebuddyAgent [baseline] (708.303 ms) : 0, 708303
BytebuddyAgent [candidate] (705.36 ms) : 0, 705360
GlobalTracer [baseline] (315.233 ms) : 0, 315233
GlobalTracer [candidate] (313.978 ms) : 0, 313978
AppSec [baseline] (165.984 ms) : 0, 165984
AppSec [candidate] (165.189 ms) : 0, 165189
Remote Config [baseline] (635.845 µs) : 0, 636
Remote Config [candidate] (637.274 µs) : 0, 637
Telemetry [baseline] (8.513 ms) : 0, 8513
Telemetry [candidate] (8.86 ms) : 0, 8860
IAST [baseline] (19.44 ms) : 0, 19440
IAST [candidate] (20.191 ms) : 0, 20191
section iast
BytebuddyAgent [baseline] (804.12 ms) : 0, 804120
BytebuddyAgent [candidate] (804.24 ms) : 0, 804240
GlobalTracer [baseline] (305.445 ms) : 0, 305445
GlobalTracer [candidate] (305.552 ms) : 0, 305552
AppSec [baseline] (57.475 ms) : 0, 57475
AppSec [candidate] (57.996 ms) : 0, 57996
Remote Config [baseline] (613.363 µs) : 0, 613
Remote Config [candidate] (617.399 µs) : 0, 617
Telemetry [baseline] (7.453 ms) : 0, 7453
Telemetry [candidate] (7.569 ms) : 0, 7569
IAST [baseline] (20.712 ms) : 0, 20712
IAST [candidate] (21.004 ms) : 0, 21004
section profiling
BytebuddyAgent [baseline] (682.282 ms) : 0, 682282
BytebuddyAgent [candidate] (686.207 ms) : 0, 686207
GlobalTracer [baseline] (400.933 ms) : 0, 400933
GlobalTracer [candidate] (402.319 ms) : 0, 402319
AppSec [baseline] (54.9 ms) : 0, 54900
AppSec [candidate] (55.275 ms) : 0, 55275
Remote Config [baseline] (664.896 µs) : 0, 665
Remote Config [candidate] (665.63 µs) : 0, 666
Telemetry [baseline] (10.673 ms) : 0, 10673
Telemetry [candidate] (12.778 ms) : 0, 12778
ProfilingAgent [baseline] (94.309 ms) : 0, 94309
ProfilingAgent [candidate] (93.377 ms) : 0, 93377
Profiling [baseline] (94.333 ms) : 0, 94333
Profiling [candidate] (93.4 ms) : 0, 93400
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087569
Total [baseline] (8.634 s) : 0, 8633722
Agent [candidate] (1.087 s) : 0, 1087046
Total [candidate] (8.64 s) : 0, 8639666
section iast
Agent [baseline] (1.218 s) : 0, 1217598
Total [baseline] (9.18 s) : 0, 9179554
Agent [candidate] (1.21 s) : 0, 1210332
Total [candidate] (9.149 s) : 0, 9149176
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1217528
Total [baseline] (9.135 s) : 0, 9135500
Agent [candidate] (1.209 s) : 0, 1209259
Total [candidate] (9.123 s) : 0, 9123394
section iast_TELEMETRY_OFF
Agent [baseline] (1.217 s) : 0, 1217252
Total [baseline] (9.207 s) : 0, 9207130
Agent [candidate] (1.207 s) : 0, 1207268
Total [candidate] (9.163 s) : 0, 9163344
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent iast 1.218 s 130.029 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 129.96 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.217 s 129.683 ms (11.9%)
Total tracing 8.634 s -
Total iast 9.18 s 545.832 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.135 s 501.778 ms (5.8%)
Total iast_TELEMETRY_OFF 9.207 s 573.408 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent iast 1.21 s 123.286 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 122.213 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.207 s 120.222 ms (11.1%)
Total tracing 8.64 s -
Total iast 9.149 s 509.51 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.123 s 483.728 ms (5.6%)
Total iast_TELEMETRY_OFF 9.163 s 523.678 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.764 ms) : 0, 688764
BytebuddyAgent [candidate] (689.321 ms) : 0, 689321
GlobalTracer [baseline] (316.707 ms) : 0, 316707
GlobalTracer [candidate] (317.57 ms) : 0, 317570
AppSec [baseline] (54.747 ms) : 0, 54747
AppSec [candidate] (54.326 ms) : 0, 54326
Remote Config [baseline] (700.474 µs) : 0, 700
Remote Config [candidate] (685.205 µs) : 0, 685
Telemetry [baseline] (12.882 ms) : 0, 12882
Telemetry [candidate] (11.362 ms) : 0, 11362
section iast
BytebuddyAgent [baseline] (809.504 ms) : 0, 809504
BytebuddyAgent [candidate] (804.621 ms) : 0, 804621
GlobalTracer [baseline] (307.039 ms) : 0, 307039
GlobalTracer [candidate] (305.288 ms) : 0, 305288
AppSec [baseline] (56.662 ms) : 0, 56662
AppSec [candidate] (57.662 ms) : 0, 57662
Remote Config [baseline] (623.093 µs) : 0, 623
Remote Config [candidate] (627.876 µs) : 0, 628
Telemetry [baseline] (7.49 ms) : 0, 7490
Telemetry [candidate] (7.502 ms) : 0, 7502
IAST [baseline] (22.452 ms) : 0, 22452
IAST [candidate] (20.826 ms) : 0, 20826
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.617 ms) : 0, 809617
BytebuddyAgent [candidate] (803.652 ms) : 0, 803652
GlobalTracer [baseline] (307.393 ms) : 0, 307393
GlobalTracer [candidate] (305.693 ms) : 0, 305693
AppSec [baseline] (56.167 ms) : 0, 56167
AppSec [candidate] (57.414 ms) : 0, 57414
Remote Config [baseline] (612.088 µs) : 0, 612
Remote Config [candidate] (615.762 µs) : 0, 616
Telemetry [baseline] (8.3 ms) : 0, 8300
Telemetry [candidate] (7.477 ms) : 0, 7477
IAST [baseline] (21.549 ms) : 0, 21549
IAST [candidate] (20.593 ms) : 0, 20593
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.68 ms) : 0, 806680
BytebuddyAgent [candidate] (799.536 ms) : 0, 799536
GlobalTracer [baseline] (309.003 ms) : 0, 309003
GlobalTracer [candidate] (306.974 ms) : 0, 306974
AppSec [baseline] (57.83 ms) : 0, 57830
AppSec [candidate] (57.76 ms) : 0, 57760
Remote Config [baseline] (632.839 µs) : 0, 633
Remote Config [candidate] (623.392 µs) : 0, 623
Telemetry [baseline] (7.538 ms) : 0, 7538
Telemetry [candidate] (7.441 ms) : 0, 7441
IAST [baseline] (21.686 ms) : 0, 21686
IAST [candidate] (21.161 ms) : 0, 21161
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-14T17:05:32 2024-11-14T17:12:27
git_branch master jpbempel/fix-int-parsing-probe-def
git_commit_date 1731601861 1731603283
git_commit_sha 105c9dc fd1bd00
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~fd1bd009d1
start_time 2024-11-14T17:05:18 2024-11-14T17:12:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731604697 1731604697
ci_job_id 707384228 707384228
ci_pipeline_id 49042162 49042162
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.352 µs) : 353, 394
.   : milestone, 373,
iast (485.134 µs) : 464, 506
.   : milestone, 485,
iast_FULL (640.579 µs) : 619, 662
.   : milestone, 641,
iast_GLOBAL (511.649 µs) : 490, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (483.666 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (446.151 µs) : 424, 468
.   : milestone, 446,
iast_TELEMETRY_OFF (478.498 µs) : 457, 500
.   : milestone, 478,
tracing (443.1 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (370.064 µs) : 350, 390
.   : milestone, 370,
iast (495.661 µs) : 475, 517
.   : milestone, 496,
iast_FULL (639.914 µs) : 619, 661
.   : milestone, 640,
iast_GLOBAL (519.626 µs) : 498, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (484.941 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (451.098 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (474.711 µs) : 453, 496
.   : milestone, 475,
tracing (440.652 µs) : 420, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.352 µs [352.637 µs, 394.067 µs] -
iast 485.134 µs [463.849 µs, 506.418 µs] 111.782 µs (29.9%)
iast_FULL 640.579 µs [619.22 µs, 661.938 µs] 267.227 µs (71.6%)
iast_GLOBAL 511.649 µs [490.308 µs, 532.99 µs] 138.297 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 483.666 µs [462.508 µs, 504.824 µs] 110.314 µs (29.5%)
iast_INACTIVE 446.151 µs [424.487 µs, 467.815 µs] 72.799 µs (19.5%)
iast_TELEMETRY_OFF 478.498 µs [457.072 µs, 499.923 µs] 105.146 µs (28.2%)
tracing 443.1 µs [422.143 µs, 464.056 µs] 69.748 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.064 µs [350.48 µs, 389.647 µs] -
iast 495.661 µs [474.561 µs, 516.761 µs] 125.597 µs (33.9%)
iast_FULL 639.914 µs [618.593 µs, 661.235 µs] 269.85 µs (72.9%)
iast_GLOBAL 519.626 µs [497.564 µs, 541.689 µs] 149.562 µs (40.4%)
iast_HARDCODED_SECRET_DISABLED 484.941 µs [463.728 µs, 506.155 µs] 114.878 µs (31.0%)
iast_INACTIVE 451.098 µs [430.064 µs, 472.132 µs] 81.034 µs (21.9%)
iast_TELEMETRY_OFF 474.711 µs [453.209 µs, 496.213 µs] 104.647 µs (28.3%)
tracing 440.652 µs [419.672 µs, 461.632 µs] 70.588 µs (19.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1320, 1360
.   : milestone, 1340,
appsec (1.745 ms) : 1721, 1770
.   : milestone, 1745,
appsec_no_iast (1.747 ms) : 1722, 1771
.   : milestone, 1747,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.522 ms) : 1498, 1546
.   : milestone, 1522,
tracing (1.47 ms) : 1447, 1494
.   : milestone, 1470,
section candidate
no_agent (1.343 ms) : 1323, 1363
.   : milestone, 1343,
appsec (1.728 ms) : 1703, 1752
.   : milestone, 1728,
appsec_no_iast (1.744 ms) : 1720, 1767
.   : milestone, 1744,
iast (1.472 ms) : 1449, 1495
.   : milestone, 1472,
profiling (1.491 ms) : 1468, 1514
.   : milestone, 1491,
tracing (1.48 ms) : 1456, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.36 ms] -
appsec 1.745 ms [1.721 ms, 1.77 ms] 405.313 µs (30.2%)
appsec_no_iast 1.747 ms [1.722 ms, 1.771 ms] 406.52 µs (30.3%)
iast 1.477 ms [1.454 ms, 1.5 ms] 136.877 µs (10.2%)
profiling 1.522 ms [1.498 ms, 1.546 ms] 181.907 µs (13.6%)
tracing 1.47 ms [1.447 ms, 1.494 ms] 130.428 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.323 ms, 1.363 ms] -
appsec 1.728 ms [1.703 ms, 1.752 ms] 384.357 µs (28.6%)
appsec_no_iast 1.744 ms [1.72 ms, 1.767 ms] 400.347 µs (29.8%)
iast 1.472 ms [1.449 ms, 1.495 ms] 128.873 µs (9.6%)
profiling 1.491 ms [1.468 ms, 1.514 ms] 147.728 µs (11.0%)
tracing 1.48 ms [1.456 ms, 1.504 ms] 136.783 µs (10.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-int-parsing-probe-def
git_commit_date 1731601861 1731603283
git_commit_sha 105c9dc fd1bd00
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~fd1bd009d1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731605224 1731605224
ci_job_id 707384229 707384229
ci_pipeline_id 49042162 49042162
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.503 s) : 15503000, 15503000
.   : milestone, 15503000,
appsec (15.39 s) : 15390000, 15390000
.   : milestone, 15390000,
iast (18.394 s) : 18394000, 18394000
.   : milestone, 18394000,
iast_GLOBAL (18.281 s) : 18281000, 18281000
.   : milestone, 18281000,
profiling (15.56 s) : 15560000, 15560000
.   : milestone, 15560000,
tracing (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
section candidate
no_agent (15.088 s) : 15088000, 15088000
.   : milestone, 15088000,
appsec (15.215 s) : 15215000, 15215000
.   : milestone, 15215000,
iast (19.137 s) : 19137000, 19137000
.   : milestone, 19137000,
iast_GLOBAL (18.576 s) : 18576000, 18576000
.   : milestone, 18576000,
profiling (14.808 s) : 14808000, 14808000
.   : milestone, 14808000,
tracing (15.323 s) : 15323000, 15323000
.   : milestone, 15323000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.503 s [15.503 s, 15.503 s] -
appsec 15.39 s [15.39 s, 15.39 s] -113.0 ms (-0.7%)
iast 18.394 s [18.394 s, 18.394 s] 2.891 s (18.6%)
iast_GLOBAL 18.281 s [18.281 s, 18.281 s] 2.778 s (17.9%)
profiling 15.56 s [15.56 s, 15.56 s] 57.0 ms (0.4%)
tracing 15.107 s [15.107 s, 15.107 s] -396.0 ms (-2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.088 s [15.088 s, 15.088 s] -
appsec 15.215 s [15.215 s, 15.215 s] 127.0 ms (0.8%)
iast 19.137 s [19.137 s, 19.137 s] 4.049 s (26.8%)
iast_GLOBAL 18.576 s [18.576 s, 18.576 s] 3.488 s (23.1%)
profiling 14.808 s [14.808 s, 14.808 s] -280.0 ms (-1.9%)
tracing 15.323 s [15.323 s, 15.323 s] 235.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~fd1bd009d1, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.325 ms) : 2284, 2366
.   : milestone, 2325,
iast (2.071 ms) : 2019, 2123
.   : milestone, 2071,
iast_GLOBAL (2.112 ms) : 2060, 2164
.   : milestone, 2112,
profiling (2.433 ms) : 2244, 2622
.   : milestone, 2433,
tracing (1.917 ms) : 1877, 1957
.   : milestone, 1917,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.326 ms) : 2285, 2366
.   : milestone, 2326,
iast (2.075 ms) : 2023, 2128
.   : milestone, 2075,
iast_GLOBAL (2.108 ms) : 2056, 2160
.   : milestone, 2108,
profiling (1.927 ms) : 1885, 1970
.   : milestone, 1927,
tracing (1.91 ms) : 1870, 1949
.   : milestone, 1910,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.325 ms [2.284 ms, 2.366 ms] 862.19 µs (58.9%)
iast 2.071 ms [2.019 ms, 2.123 ms] 608.714 µs (41.6%)
iast_GLOBAL 2.112 ms [2.06 ms, 2.164 ms] 649.483 µs (44.4%)
profiling 2.433 ms [2.244 ms, 2.622 ms] 970.16 µs (66.3%)
tracing 1.917 ms [1.877 ms, 1.957 ms] 454.266 µs (31.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.326 ms [2.285 ms, 2.366 ms] 859.442 µs (58.6%)
iast 2.075 ms [2.023 ms, 2.128 ms] 609.152 µs (41.5%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.16 ms] 642.082 µs (43.8%)
profiling 1.927 ms [1.885 ms, 1.97 ms] 460.852 µs (31.4%)
tracing 1.91 ms [1.87 ms, 1.949 ms] 443.508 µs (30.2%)

@jpbempel jpbempel merged commit 2f767ab into master Nov 15, 2024
108 of 110 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-int-parsing-probe-def branch November 15, 2024 18:22
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @evanchooly