Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number typing used in maps #7676

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix number typing used in maps #7676

merged 1 commit into from
Sep 26, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 24, 2024 •
edited by jira bot
Loading

What Does This Do

We are automatically widening numbers from Integer to Long and Float to Double to be able to compare them. But used as key for maps it does
not work because the type needs to be exact.
For fixing this we are moving to widening then numbers only at comparison time. Otherwise we keep the original typing.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2603

@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels Sep 24, 2024
@jpbempel jpbempel requested a review from a team as a code owner September 24, 2024 13:10
@jpbempel jpbempel requested review from shatzi and removed request for a team September 24, 2024 13:10
@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1727195989 1727196377
end_time 2024-09-24T16:41:04 2024-09-24T16:47:32
git_branch master jpbempel/fix-widening
git_commit_sha 043adb2 30a4b6c
start_time 2024-09-24T16:39:50 2024-09-24T16:46:18
See matching parameters
Baseline Candidate
ci_job_id 650061229 650061229
ci_pipeline_id 45033364 45033364
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1727195380 1727195380

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-631.181µs; -618.451µs] or [-5.851%; -5.733%]		 better
[-670.994µs; -605.462µs] or [-6.120%; -5.522%]		 better
[-688.529µs; -577.620µs] or [-6.229%; -5.226%]		 better
[-955.778µs; -420.709µs] or [-8.309%; -3.657%]		 better
[+4.618op/s; +6.589op/s] or [+5.126%; +7.314%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-25.482µs; +33.254µs] or [-9.723%; +12.689%]		 unstable
[-38.747µs; +46.684µs] or [-12.816%; +15.441%]		 unstable
[-53.555µs; +61.801µs] or [-16.845%; +19.438%]		 unstable
[-126.776µs; +95.581µs] or [-20.657%; +15.574%]		 same
scenario:basic unsure
[+1.373µs; +12.323µs] or [+0.518%; +4.649%]		 same same unstable
[-35.054µs; +57.756µs] or [-6.597%; +10.870%]		 unstable
[-233.119op/s; +98.166op/s] or [-8.859%; +3.730%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (302.331 µs) : 267, 338
.   : milestone, 302,
basic (294.776 µs) : 285, 304
.   : milestone, 295,
loop (10.964 ms) : 10935, 10992
.   : milestone, 10964,
section candidate
noprobe (306.299 µs) : 261, 351
.   : milestone, 306,
basic (302.882 µs) : 293, 312
.   : milestone, 303,
loop (10.326 ms) : 10293, 10358
.   : milestone, 10326,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 302.331 µs [266.509 µs, 338.152 µs]
basic 294.776 µs [285.243 µs, 304.309 µs]
loop 10.964 ms [10.935 ms, 10.992 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 306.299 µs [261.166 µs, 351.432 µs]
basic 302.882 µs [293.437 µs, 312.327 µs]
loop 10.326 ms [10.293 ms, 10.358 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-widening
git_commit_date 1727189655 1727195380
git_commit_sha 043adb2 30a4b6c
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~30a4b6c206
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727197702 1727197702
ci_job_id 650061223 650061223
ci_pipeline_id 45033364 45033364
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064081
Total [baseline] (8.524 s) : 0, 8523797
Agent [candidate] (1.071 s) : 0, 1071141
Total [candidate] (8.544 s) : 0, 8544461
section iast
Agent [baseline] (1.192 s) : 0, 1191602
Total [baseline] (9.049 s) : 0, 9049143
Agent [candidate] (1.192 s) : 0, 1192294
Total [candidate] (9.01 s) : 0, 9010166
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1190478
Total [baseline] (8.963 s) : 0, 8963280
Agent [candidate] (1.192 s) : 0, 1191796
Total [candidate] (8.964 s) : 0, 8964299
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1187002
Total [baseline] (9.003 s) : 0, 9003162
Agent [candidate] (1.198 s) : 0, 1197748
Total [candidate] (9.01 s) : 0, 9010444
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.192 s 127.521 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 126.397 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.187 s 122.921 ms (11.6%)
Total tracing 8.524 s -
Total iast 9.049 s 525.346 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.963 s 439.484 ms (5.2%)
Total iast_TELEMETRY_OFF 9.003 s 479.365 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent iast 1.192 s 121.153 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 120.655 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.198 s 126.607 ms (11.8%)
Total tracing 8.544 s -
Total iast 9.01 s 465.705 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.964 s 419.838 ms (4.9%)
Total iast_TELEMETRY_OFF 9.01 s 465.983 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.437 ms) : 0, 679437
BytebuddyAgent [candidate] (683.843 ms) : 0, 683843
GlobalTracer [baseline] (309.006 ms) : 0, 309006
GlobalTracer [candidate] (311.337 ms) : 0, 311337
AppSec [baseline] (53.786 ms) : 0, 53786
AppSec [candidate] (53.963 ms) : 0, 53963
Remote Config [baseline] (660.198 µs) : 0, 660
Remote Config [candidate] (674.798 µs) : 0, 675
Telemetry [baseline] (7.624 ms) : 0, 7624
Telemetry [candidate] (7.639 ms) : 0, 7639
section iast
BytebuddyAgent [baseline] (793.288 ms) : 0, 793288
BytebuddyAgent [candidate] (793.822 ms) : 0, 793822
GlobalTracer [baseline] (298.576 ms) : 0, 298576
GlobalTracer [candidate] (299.206 ms) : 0, 299206
AppSec [baseline] (55.371 ms) : 0, 55371
AppSec [candidate] (54.72 ms) : 0, 54720
IAST [baseline] (23.005 ms) : 0, 23005
IAST [candidate] (23.323 ms) : 0, 23323
Remote Config [baseline] (645.923 µs) : 0, 646
Remote Config [candidate] (587.82 µs) : 0, 588
Telemetry [baseline] (7.062 ms) : 0, 7062
Telemetry [candidate] (6.937 ms) : 0, 6937
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.546 ms) : 0, 792546
BytebuddyAgent [candidate] (793.301 ms) : 0, 793301
GlobalTracer [baseline] (298.811 ms) : 0, 298811
GlobalTracer [candidate] (299.046 ms) : 0, 299046
AppSec [baseline] (56.881 ms) : 0, 56881
AppSec [candidate] (56.213 ms) : 0, 56213
IAST [baseline] (20.958 ms) : 0, 20958
IAST [candidate] (21.921 ms) : 0, 21921
Remote Config [baseline] (604.994 µs) : 0, 605
Remote Config [candidate] (610.167 µs) : 0, 610
Telemetry [baseline] (7.039 ms) : 0, 7039
Telemetry [candidate] (7.051 ms) : 0, 7051
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.957 ms) : 0, 788957
BytebuddyAgent [candidate] (795.862 ms) : 0, 795862
GlobalTracer [baseline] (298.596 ms) : 0, 298596
GlobalTracer [candidate] (301.516 ms) : 0, 301516
AppSec [baseline] (54.296 ms) : 0, 54296
AppSec [candidate] (55.636 ms) : 0, 55636
IAST [baseline] (22.378 ms) : 0, 22378
IAST [candidate] (23.269 ms) : 0, 23269
Remote Config [baseline] (2.18 ms) : 0, 2180
Remote Config [candidate] (682.299 µs) : 0, 682
Telemetry [baseline] (6.929 ms) : 0, 6929
Telemetry [candidate] (6.961 ms) : 0, 6961
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065193
Total [baseline] (10.466 s) : 0, 10465799
Agent [candidate] (1.065 s) : 0, 1065485
Total [candidate] (10.356 s) : 0, 10356342
section appsec
Agent [baseline] (1.199 s) : 0, 1198930
Total [baseline] (10.628 s) : 0, 10627799
Agent [candidate] (1.201 s) : 0, 1201225
Total [candidate] (10.614 s) : 0, 10614042
section iast
Agent [baseline] (1.198 s) : 0, 1197884
Total [baseline] (10.837 s) : 0, 10837253
Agent [candidate] (1.201 s) : 0, 1201097
Total [candidate] (10.866 s) : 0, 10866131
section profiling
Agent [baseline] (1.265 s) : 0, 1264854
Total [baseline] (10.588 s) : 0, 10587657
Agent [candidate] (1.266 s) : 0, 1266424
Total [candidate] (10.529 s) : 0, 10529118
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.199 s 133.737 ms (12.6%)
Agent iast 1.198 s 132.691 ms (12.5%)
Agent profiling 1.265 s 199.661 ms (18.7%)
Total tracing 10.466 s -
Total appsec 10.628 s 162.0 ms (1.5%)
Total iast 10.837 s 371.454 ms (3.5%)
Total profiling 10.588 s 121.858 ms (1.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.201 s 135.74 ms (12.7%)
Agent iast 1.201 s 135.612 ms (12.7%)
Agent profiling 1.266 s 200.94 ms (18.9%)
Total tracing 10.356 s -
Total appsec 10.614 s 257.699 ms (2.5%)
Total iast 10.866 s 509.789 ms (4.9%)
Total profiling 10.529 s 172.776 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.848 ms) : 0, 679848
BytebuddyAgent [candidate] (680.02 ms) : 0, 680020
GlobalTracer [baseline] (309.804 ms) : 0, 309804
GlobalTracer [candidate] (309.894 ms) : 0, 309894
AppSec [baseline] (53.666 ms) : 0, 53666
AppSec [candidate] (53.648 ms) : 0, 53648
Remote Config [baseline] (673.265 µs) : 0, 673
Remote Config [candidate] (663.408 µs) : 0, 663
Telemetry [baseline] (7.643 ms) : 0, 7643
Telemetry [candidate] (7.648 ms) : 0, 7648
section appsec
BytebuddyAgent [baseline] (700.643 ms) : 0, 700643
BytebuddyAgent [candidate] (701.886 ms) : 0, 701886
GlobalTracer [baseline] (303.081 ms) : 0, 303081
GlobalTracer [candidate] (303.526 ms) : 0, 303526
AppSec [baseline] (161.51 ms) : 0, 161510
AppSec [candidate] (163.481 ms) : 0, 163481
IAST [baseline] (21.367 ms) : 0, 21367
IAST [candidate] (20.599 ms) : 0, 20599
Remote Config [baseline] (643.307 µs) : 0, 643
Remote Config [candidate] (641.206 µs) : 0, 641
Telemetry [baseline] (8.814 ms) : 0, 8814
Telemetry [candidate] (7.797 ms) : 0, 7797
section iast
BytebuddyAgent [baseline] (797.957 ms) : 0, 797957
BytebuddyAgent [candidate] (798.042 ms) : 0, 798042
GlobalTracer [baseline] (300.111 ms) : 0, 300111
GlobalTracer [candidate] (302.504 ms) : 0, 302504
AppSec [baseline] (55.543 ms) : 0, 55543
AppSec [candidate] (55.933 ms) : 0, 55933
IAST [baseline] (22.892 ms) : 0, 22892
IAST [candidate] (23.155 ms) : 0, 23155
Remote Config [baseline] (611.096 µs) : 0, 611
Remote Config [candidate] (628.064 µs) : 0, 628
Telemetry [baseline] (7.068 ms) : 0, 7068
Telemetry [candidate] (7.126 ms) : 0, 7126
section profiling
BytebuddyAgent [baseline] (673.438 ms) : 0, 673438
BytebuddyAgent [candidate] (674.604 ms) : 0, 674604
GlobalTracer [baseline] (393.559 ms) : 0, 393559
GlobalTracer [candidate] (394.603 ms) : 0, 394603
AppSec [baseline] (54.589 ms) : 0, 54589
AppSec [candidate] (54.791 ms) : 0, 54791
Remote Config [baseline] (659.082 µs) : 0, 659
Remote Config [candidate] (651.915 µs) : 0, 652
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.426 ms) : 0, 7426
ProfilingAgent [baseline] (96.642 ms) : 0, 96642
ProfilingAgent [candidate] (95.871 ms) : 0, 95871
Profiling [baseline] (96.665 ms) : 0, 96665
Profiling [candidate] (95.895 ms) : 0, 95895
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-24T16:38:59 2024-09-24T16:45:52
git_branch master jpbempel/fix-widening
git_commit_date 1727189655 1727195380
git_commit_sha 043adb2 30a4b6c
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~30a4b6c206
start_time 2024-09-24T16:38:46 2024-09-24T16:45:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727196700 1727196700
ci_job_id 650061224 650061224
ci_pipeline_id 45033364 45033364
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1338, 1379
.   : milestone, 1359,
appsec (1.721 ms) : 1698, 1744
.   : milestone, 1721,
appsec_no_iast (1.718 ms) : 1694, 1742
.   : milestone, 1718,
iast (1.487 ms) : 1465, 1509
.   : milestone, 1487,
profiling (1.502 ms) : 1479, 1525
.   : milestone, 1502,
tracing (1.464 ms) : 1439, 1489
.   : milestone, 1464,
section candidate
no_agent (1.363 ms) : 1344, 1383
.   : milestone, 1363,
appsec (1.715 ms) : 1690, 1740
.   : milestone, 1715,
appsec_no_iast (1.732 ms) : 1708, 1755
.   : milestone, 1732,
iast (1.481 ms) : 1459, 1504
.   : milestone, 1481,
profiling (1.498 ms) : 1473, 1523
.   : milestone, 1498,
tracing (1.464 ms) : 1441, 1488
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.338 ms, 1.379 ms] -
appsec 1.721 ms [1.698 ms, 1.744 ms] 361.945 µs (26.6%)
appsec_no_iast 1.718 ms [1.694 ms, 1.742 ms] 359.281 µs (26.4%)
iast 1.487 ms [1.465 ms, 1.509 ms] 128.274 µs (9.4%)
profiling 1.502 ms [1.479 ms, 1.525 ms] 142.852 µs (10.5%)
tracing 1.464 ms [1.439 ms, 1.489 ms] 105.161 µs (7.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.383 ms] -
appsec 1.715 ms [1.69 ms, 1.74 ms] 352.087 µs (25.8%)
appsec_no_iast 1.732 ms [1.708 ms, 1.755 ms] 368.43 µs (27.0%)
iast 1.481 ms [1.459 ms, 1.504 ms] 118.128 µs (8.7%)
profiling 1.498 ms [1.473 ms, 1.523 ms] 135.239 µs (9.9%)
tracing 1.464 ms [1.441 ms, 1.488 ms] 101.056 µs (7.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.92 µs) : 347, 387
.   : milestone, 367,
iast (485.42 µs) : 464, 507
.   : milestone, 485,
iast_FULL (557.21 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (509.178 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (491.408 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (446.781 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (481.849 µs) : 459, 505
.   : milestone, 482,
tracing (450.14 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (377.05 µs) : 358, 396
.   : milestone, 377,
iast (484.423 µs) : 463, 506
.   : milestone, 484,
iast_FULL (559.138 µs) : 538, 581
.   : milestone, 559,
iast_GLOBAL (520.9 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (487.568 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (459.221 µs) : 438, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (477.761 µs) : 455, 500
.   : milestone, 478,
tracing (449.613 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.92 µs [347.317 µs, 386.524 µs] -
iast 485.42 µs [464.212 µs, 506.628 µs] 118.5 µs (32.3%)
iast_FULL 557.21 µs [535.9 µs, 578.52 µs] 190.289 µs (51.9%)
iast_GLOBAL 509.178 µs [487.266 µs, 531.09 µs] 142.258 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED 491.408 µs [470.119 µs, 512.696 µs] 124.487 µs (33.9%)
iast_INACTIVE 446.781 µs [426.266 µs, 467.295 µs] 79.86 µs (21.8%)
iast_TELEMETRY_OFF 481.849 µs [459.1 µs, 504.598 µs] 114.928 µs (31.3%)
tracing 450.14 µs [429.385 µs, 470.894 µs] 83.219 µs (22.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.05 µs [357.644 µs, 396.456 µs] -
iast 484.423 µs [463.151 µs, 505.695 µs] 107.373 µs (28.5%)
iast_FULL 559.138 µs [537.609 µs, 580.666 µs] 182.087 µs (48.3%)
iast_GLOBAL 520.9 µs [498.754 µs, 543.045 µs] 143.85 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 487.568 µs [466.03 µs, 509.105 µs] 110.518 µs (29.3%)
iast_INACTIVE 459.221 µs [437.533 µs, 480.909 µs] 82.171 µs (21.8%)
iast_TELEMETRY_OFF 477.761 µs [455.199 µs, 500.324 µs] 100.711 µs (26.7%)
tracing 449.613 µs [428.892 µs, 470.335 µs] 72.563 µs (19.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-widening
git_commit_date 1727189655 1727195380
git_commit_sha 043adb2 30a4b6c
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~30a4b6c206
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727197217 1727197217
ci_job_id 650061225 650061225
ci_pipeline_id 45033364 45033364
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1480
.   : milestone, 1468,
appsec (2.302 ms) : 2261, 2343
.   : milestone, 2302,
iast (2.049 ms) : 1999, 2098
.   : milestone, 2049,
iast_GLOBAL (2.098 ms) : 2048, 2149
.   : milestone, 2098,
profiling (1.924 ms) : 1884, 1963
.   : milestone, 1924,
tracing (1.9 ms) : 1862, 1938
.   : milestone, 1900,
section candidate
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.303 ms) : 2263, 2343
.   : milestone, 2303,
iast (2.058 ms) : 2007, 2109
.   : milestone, 2058,
iast_GLOBAL (2.087 ms) : 2036, 2137
.   : milestone, 2087,
profiling (2.414 ms) : 2224, 2604
.   : milestone, 2414,
tracing (1.886 ms) : 1849, 1924
.   : milestone, 1886,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.48 ms] -
appsec 2.302 ms [2.261 ms, 2.343 ms] 834.078 µs (56.8%)
iast 2.049 ms [1.999 ms, 2.098 ms] 580.534 µs (39.5%)
iast_GLOBAL 2.098 ms [2.048 ms, 2.149 ms] 630.401 µs (42.9%)
profiling 1.924 ms [1.884 ms, 1.963 ms] 455.941 µs (31.1%)
tracing 1.9 ms [1.862 ms, 1.938 ms] 431.817 µs (29.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.303 ms [2.263 ms, 2.343 ms] 842.483 µs (57.7%)
iast 2.058 ms [2.007 ms, 2.109 ms] 597.47 µs (40.9%)
iast_GLOBAL 2.087 ms [2.036 ms, 2.137 ms] 626.421 µs (42.9%)
profiling 2.414 ms [2.224 ms, 2.604 ms] 953.736 µs (65.3%)
tracing 1.886 ms [1.849 ms, 1.924 ms] 426.098 µs (29.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~30a4b6c206, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.467 s) : 15467000, 15467000
.   : milestone, 15467000,
appsec (15.308 s) : 15308000, 15308000
.   : milestone, 15308000,
iast (18.724 s) : 18724000, 18724000
.   : milestone, 18724000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
.   : milestone, 18061000,
profiling (15.343 s) : 15343000, 15343000
.   : milestone, 15343000,
tracing (15.286 s) : 15286000, 15286000
.   : milestone, 15286000,
section candidate
no_agent (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
appsec (14.927 s) : 14927000, 14927000
.   : milestone, 14927000,
iast (18.932 s) : 18932000, 18932000
.   : milestone, 18932000,
iast_GLOBAL (18.062 s) : 18062000, 18062000
.   : milestone, 18062000,
profiling (15.58 s) : 15580000, 15580000
.   : milestone, 15580000,
tracing (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.467 s [15.467 s, 15.467 s] -
appsec 15.308 s [15.308 s, 15.308 s] -159.0 ms (-1.0%)
iast 18.724 s [18.724 s, 18.724 s] 3.257 s (21.1%)
iast_GLOBAL 18.061 s [18.061 s, 18.061 s] 2.594 s (16.8%)
profiling 15.343 s [15.343 s, 15.343 s] -124.0 ms (-0.8%)
tracing 15.286 s [15.286 s, 15.286 s] -181.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.072 s [15.072 s, 15.072 s] -
appsec 14.927 s [14.927 s, 14.927 s] -145.0 ms (-1.0%)
iast 18.932 s [18.932 s, 18.932 s] 3.86 s (25.6%)
iast_GLOBAL 18.062 s [18.062 s, 18.062 s] 2.99 s (19.8%)
profiling 15.58 s [15.58 s, 15.58 s] 508.0 ms (3.4%)
tracing 14.99 s [14.99 s, 14.99 s] -82.0 ms (-0.5%)

@jpbempel
Fix number typing used in maps
30a4b6c 
We are automatically widening numbers from Integer to Long and Float
to Double to be able to compare them. But used as key for maps it does
 not work because the type needs to be exact.
For fixing this we are moving to widening then numbers only at
comparison time. Otherwise we keep the original typing.
@jpbempel jpbempel merged commit 845dfba into master Sep 26, 2024
103 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-widening branch September 26, 2024 07:42
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 26, 2024
jpbempel added a commit that referenced this pull request Nov 14, 2024
@jpbempel
Fix integer json parsing probe definition
fd1bd00 
Following #7676 issue, numbers parsed from the json probe definition
are still considered as long value which still makes then unfittable
to be used as key for Integer -> Integer map.
Now we parse integers (without dot numbers) as long and see if they
fit into an integer, then downgrade them as DSL value with integer
type.
@jpbempel jpbempel mentioned this pull request Nov 14, 2024
Merged
5 tasks
jpbempel added a commit that referenced this pull request Nov 15, 2024
@jpbempel
Fix integer json parsing probe definition (#7957)
2f767ab 
Following #7676 issue, numbers parsed from the json probe definition
are still considered as long value which still makes then unfittable
to be used as key for Integer -> Integer map.
Now we parse integers (without dot numbers) as long and see if they
fit into an integer, then downgrade them as DSL value with integer
type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi