Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🍒 7916] Remove SSI guardrails entries for hbase and hive #7935

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

PerfectSlayer
Copy link
Contributor

Backport #7916 to release/v1.42.x

Such software will be handled by shell script blocking

(cherry picked from commit a9bd665)
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner November 12, 2024 14:48
@PerfectSlayer PerfectSlayer added this to the 1.42.2 milestone Nov 12, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1731423453 1731423828
end_time 2024-11-12T14:58:48 2024-11-12T15:05:03
git_branch master bruce.bujon/backport-pr-7916
git_commit_sha 6082863 557327a
start_time 2024-11-12T14:57:34 2024-11-12T15:03:49
See matching parameters
Baseline Candidate
ci_job_id 703779564 703779564
ci_pipeline_id 48802488 48802488
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1731422874 1731422874

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-24.973µs; +37.449µs] or [-9.568%; +14.348%]
unstable
[-36.794µs; +50.863µs] or [-12.235%; +16.913%]
unstable
[-47.094µs; +64.748µs] or [-14.979%; +20.594%]
unstable
[-126.270µs; +118.940µs] or [-20.551%; +19.358%]
same
scenario:basic unsure
[-11.701µs; -0.835µs] or [-4.258%; -0.304%]
same same unstable
[-40.400µs; +49.180µs] or [-7.414%; +9.026%]
unstable
[-179.953op/s; +179.953op/s] or [-7.018%; +7.018%]
scenario:loop unsure
[+17.246µs; +40.421µs] or [+0.170%; +0.399%]
same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (300.74 µs) : 273, 329
.   : milestone, 301,
basic (303.786 µs) : 294, 313
.   : milestone, 304,
loop (10.316 ms) : 10276, 10356
.   : milestone, 10316,
section candidate
noprobe (307.774 µs) : 256, 360
.   : milestone, 308,
basic (299.629 µs) : 290, 309
.   : milestone, 300,
loop (10.326 ms) : 10292, 10360
.   : milestone, 10326,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 300.74 µs [272.559 µs, 328.92 µs]
basic 303.786 µs [294.387 µs, 313.184 µs]
loop 10.316 ms [10.276 ms, 10.356 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 307.774 µs [255.799 µs, 359.749 µs]
basic 299.629 µs [290.221 µs, 309.037 µs]
loop 10.326 ms [10.292 ms, 10.36 ms]

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch release/v1.42.x bruce.bujon/backport-pr-7916
git_commit_date 1731074042 1731422874
git_commit_sha df0ec27 557327a
See matching parameters
Baseline Candidate
ci_job_date 1731423908 1731423908
ci_job_id 703779562 703779562
ci_pipeline_id 48802488 48802488
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce unsure
[+23.039op/s; +7965.417op/s] or [+0.017%; +5.880%]

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bruce.bujon/backport-pr-7916
git_commit_date 1731422807 1731422874
git_commit_sha 6082863 557327a
release_version 1.43.0-SNAPSHOT~6082863645 1.43.0-SNAPSHOT~557327aa08
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731425310 1731425310
ci_job_id 703779556 703779556
ci_pipeline_id 48802488 48802488
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090988
Total [baseline] (8.665 s) : 0, 8665309
Agent [candidate] (1.089 s) : 0, 1089238
Total [candidate] (8.581 s) : 0, 8580996
section iast
Agent [baseline] (1.208 s) : 0, 1208136
Total [baseline] (9.147 s) : 0, 9146896
Agent [candidate] (1.22 s) : 0, 1220340
Total [candidate] (9.17 s) : 0, 9170193
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.21 s) : 0, 1210489
Total [baseline] (9.106 s) : 0, 9106348
Agent [candidate] (1.22 s) : 0, 1219702
Total [candidate] (9.18 s) : 0, 9179501
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1208195
Total [baseline] (9.199 s) : 0, 9199148
Agent [candidate] (1.207 s) : 0, 1207065
Total [candidate] (9.137 s) : 0, 9137061
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.208 s 117.148 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 119.501 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.208 s 117.207 ms (10.7%)
Total tracing 8.665 s -
Total iast 9.147 s 481.587 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.106 s 441.039 ms (5.1%)
Total iast_TELEMETRY_OFF 9.199 s 533.839 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.22 s 131.102 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.22 s 130.464 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.207 s 117.827 ms (10.8%)
Total tracing 8.581 s -
Total iast 9.17 s 589.197 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.18 s 598.505 ms (7.0%)
Total iast_TELEMETRY_OFF 9.137 s 556.065 ms (6.5%)
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.064 ms) : 0, 694064
BytebuddyAgent [candidate] (691.619 ms) : 0, 691619
GlobalTracer [baseline] (317.786 ms) : 0, 317786
GlobalTracer [candidate] (316.065 ms) : 0, 316065
AppSec [baseline] (54.505 ms) : 0, 54505
AppSec [candidate] (54.255 ms) : 0, 54255
Remote Config [baseline] (681.849 µs) : 0, 682
Remote Config [candidate] (666.769 µs) : 0, 667
Telemetry [baseline] (10.051 ms) : 0, 10051
Telemetry [candidate] (12.774 ms) : 0, 12774
section iast
BytebuddyAgent [baseline] (803.664 ms) : 0, 803664
BytebuddyAgent [candidate] (813.021 ms) : 0, 813021
GlobalTracer [baseline] (304.325 ms) : 0, 304325
GlobalTracer [candidate] (306.533 ms) : 0, 306533
AppSec [baseline] (56.852 ms) : 0, 56852
AppSec [candidate] (57.39 ms) : 0, 57390
IAST [baseline] (21.369 ms) : 0, 21369
IAST [candidate] (21.298 ms) : 0, 21298
Remote Config [baseline] (619.898 µs) : 0, 620
Remote Config [candidate] (615.885 µs) : 0, 616
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.514 ms) : 0, 7514
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.616 ms) : 0, 804616
BytebuddyAgent [candidate] (810.8 ms) : 0, 810800
GlobalTracer [baseline] (305.256 ms) : 0, 305256
GlobalTracer [candidate] (307.54 ms) : 0, 307540
AppSec [baseline] (58.007 ms) : 0, 58007
AppSec [candidate] (58.301 ms) : 0, 58301
IAST [baseline] (20.644 ms) : 0, 20644
IAST [candidate] (20.873 ms) : 0, 20873
Remote Config [baseline] (620.515 µs) : 0, 621
Remote Config [candidate] (644.929 µs) : 0, 645
Telemetry [baseline] (7.558 ms) : 0, 7558
Telemetry [candidate] (7.648 ms) : 0, 7648
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.291 ms) : 0, 802291
BytebuddyAgent [candidate] (801.315 ms) : 0, 801315
GlobalTracer [baseline] (305.158 ms) : 0, 305158
GlobalTracer [candidate] (305.264 ms) : 0, 305264
AppSec [baseline] (58.397 ms) : 0, 58397
AppSec [candidate] (57.443 ms) : 0, 57443
IAST [baseline] (20.426 ms) : 0, 20426
IAST [candidate] (21.174 ms) : 0, 21174
Remote Config [baseline] (608.306 µs) : 0, 608
Remote Config [candidate] (611.63 µs) : 0, 612
Telemetry [baseline] (7.515 ms) : 0, 7515
Telemetry [candidate] (7.454 ms) : 0, 7454
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092332
Total [baseline] (10.432 s) : 0, 10431559
Agent [candidate] (1.086 s) : 0, 1086143
Total [candidate] (10.386 s) : 0, 10385906
section appsec
Agent [baseline] (1.218 s) : 0, 1217615
Total [baseline] (10.721 s) : 0, 10720761
Agent [candidate] (1.217 s) : 0, 1217359
Total [candidate] (10.686 s) : 0, 10685735
section iast
Agent [baseline] (1.214 s) : 0, 1214371
Total [baseline] (10.909 s) : 0, 10908696
Agent [candidate] (1.207 s) : 0, 1207450
Total [candidate] (10.913 s) : 0, 10913010
section profiling
Agent [baseline] (1.294 s) : 0, 1294224
Total [baseline] (10.793 s) : 0, 10793299
Agent [candidate] (1.281 s) : 0, 1281401
Total [candidate] (10.76 s) : 0, 10759744
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.218 s 125.283 ms (11.5%)
Agent iast 1.214 s 122.04 ms (11.2%)
Agent profiling 1.294 s 201.892 ms (18.5%)
Total tracing 10.432 s -
Total appsec 10.721 s 289.202 ms (2.8%)
Total iast 10.909 s 477.137 ms (4.6%)
Total profiling 10.793 s 361.74 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.217 s 131.216 ms (12.1%)
Agent iast 1.207 s 121.307 ms (11.2%)
Agent profiling 1.281 s 195.258 ms (18.0%)
Total tracing 10.386 s -
Total appsec 10.686 s 299.828 ms (2.9%)
Total iast 10.913 s 527.104 ms (5.1%)
Total profiling 10.76 s 373.838 ms (3.6%)
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.552 ms) : 0, 693552
BytebuddyAgent [candidate] (689.182 ms) : 0, 689182
GlobalTracer [baseline] (318.267 ms) : 0, 318267
GlobalTracer [candidate] (316.674 ms) : 0, 316674
AppSec [baseline] (54.7 ms) : 0, 54700
AppSec [candidate] (54.262 ms) : 0, 54262
Remote Config [baseline] (677.624 µs) : 0, 678
Remote Config [candidate] (672.906 µs) : 0, 673
Telemetry [baseline] (11.291 ms) : 0, 11291
Telemetry [candidate] (11.567 ms) : 0, 11567
section appsec
BytebuddyAgent [baseline] (705.556 ms) : 0, 705556
BytebuddyAgent [candidate] (705.762 ms) : 0, 705762
GlobalTracer [baseline] (313.461 ms) : 0, 313461
GlobalTracer [candidate] (313.966 ms) : 0, 313966
AppSec [baseline] (165.532 ms) : 0, 165532
AppSec [candidate] (165.702 ms) : 0, 165702
Remote Config [baseline] (640.951 µs) : 0, 641
Remote Config [candidate] (649.918 µs) : 0, 650
Telemetry [baseline] (7.811 ms) : 0, 7811
Telemetry [candidate] (8.211 ms) : 0, 8211
IAST [baseline] (21.738 ms) : 0, 21738
IAST [candidate] (18.666 ms) : 0, 18666
section iast
BytebuddyAgent [baseline] (807.075 ms) : 0, 807075
BytebuddyAgent [candidate] (802.483 ms) : 0, 802483
GlobalTracer [baseline] (306.497 ms) : 0, 306497
GlobalTracer [candidate] (304.922 ms) : 0, 304922
AppSec [baseline] (57.175 ms) : 0, 57175
AppSec [candidate] (56.099 ms) : 0, 56099
Remote Config [baseline] (620.01 µs) : 0, 620
Remote Config [candidate] (609.653 µs) : 0, 610
Telemetry [baseline] (7.501 ms) : 0, 7501
Telemetry [candidate] (7.454 ms) : 0, 7454
IAST [baseline] (21.709 ms) : 0, 21709
IAST [candidate] (22.084 ms) : 0, 22084
section profiling
BytebuddyAgent [baseline] (690.706 ms) : 0, 690706
BytebuddyAgent [candidate] (682.61 ms) : 0, 682610
GlobalTracer [baseline] (403.677 ms) : 0, 403677
GlobalTracer [candidate] (399.803 ms) : 0, 399803
AppSec [baseline] (55.226 ms) : 0, 55226
AppSec [candidate] (54.856 ms) : 0, 54856
Remote Config [baseline] (669.559 µs) : 0, 670
Remote Config [candidate] (668.467 µs) : 0, 668
Telemetry [baseline] (12.722 ms) : 0, 12722
Telemetry [candidate] (13.639 ms) : 0, 13639
ProfilingAgent [baseline] (91.673 ms) : 0, 91673
ProfilingAgent [candidate] (90.878 ms) : 0, 90878
Profiling [baseline] (91.696 ms) : 0, 91696
Profiling [candidate] (90.902 ms) : 0, 90902
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-12T14:58:45 2024-11-12T15:05:39
git_branch master bruce.bujon/backport-pr-7916
git_commit_date 1731422807 1731422874
git_commit_sha 6082863 557327a
release_version 1.43.0-SNAPSHOT~6082863645 1.43.0-SNAPSHOT~557327aa08
start_time 2024-11-12T14:58:32 2024-11-12T15:05:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731424288 1731424288
ci_job_id 703779558 703779558
ci_pipeline_id 48802488 48802488
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1328, 1365
.   : milestone, 1346,
appsec (1.725 ms) : 1701, 1750
.   : milestone, 1725,
appsec_no_iast (1.735 ms) : 1712, 1759
.   : milestone, 1735,
iast (1.485 ms) : 1462, 1508
.   : milestone, 1485,
profiling (1.463 ms) : 1440, 1487
.   : milestone, 1463,
tracing (1.458 ms) : 1433, 1483
.   : milestone, 1458,
section candidate
no_agent (1.341 ms) : 1321, 1361
.   : milestone, 1341,
appsec (1.739 ms) : 1717, 1762
.   : milestone, 1739,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
iast (1.47 ms) : 1447, 1493
.   : milestone, 1470,
profiling (1.471 ms) : 1448, 1494
.   : milestone, 1471,
tracing (1.485 ms) : 1461, 1509
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.328 ms, 1.365 ms] -
appsec 1.725 ms [1.701 ms, 1.75 ms] 379.167 µs (28.2%)
appsec_no_iast 1.735 ms [1.712 ms, 1.759 ms] 389.077 µs (28.9%)
iast 1.485 ms [1.462 ms, 1.508 ms] 138.773 µs (10.3%)
profiling 1.463 ms [1.44 ms, 1.487 ms] 116.971 µs (8.7%)
tracing 1.458 ms [1.433 ms, 1.483 ms] 111.9 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.321 ms, 1.361 ms] -
appsec 1.739 ms [1.717 ms, 1.762 ms] 398.283 µs (29.7%)
appsec_no_iast 1.736 ms [1.712 ms, 1.76 ms] 394.693 µs (29.4%)
iast 1.47 ms [1.447 ms, 1.493 ms] 129.167 µs (9.6%)
profiling 1.471 ms [1.448 ms, 1.494 ms] 129.743 µs (9.7%)
tracing 1.485 ms [1.461 ms, 1.509 ms] 143.672 µs (10.7%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.072 µs) : 348, 391
.   : milestone, 369,
iast (491.687 µs) : 470, 514
.   : milestone, 492,
iast_FULL (642.546 µs) : 621, 664
.   : milestone, 643,
iast_GLOBAL (506.595 µs) : 485, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (479.2 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (444.194 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (471.712 µs) : 450, 493
.   : milestone, 472,
tracing (444.025 µs) : 423, 465
.   : milestone, 444,
section candidate
no_agent (370.343 µs) : 351, 390
.   : milestone, 370,
iast (482.391 µs) : 461, 504
.   : milestone, 482,
iast_FULL (639.943 µs) : 619, 661
.   : milestone, 640,
iast_GLOBAL (514.937 µs) : 494, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (484.822 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (443.458 µs) : 423, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (472.64 µs) : 451, 494
.   : milestone, 473,
tracing (445.815 µs) : 425, 466
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.072 µs [347.512 µs, 390.632 µs] -
iast 491.687 µs [469.577 µs, 513.796 µs] 122.615 µs (33.2%)
iast_FULL 642.546 µs [621.151 µs, 663.941 µs] 273.474 µs (74.1%)
iast_GLOBAL 506.595 µs [485.029 µs, 528.161 µs] 137.523 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 479.2 µs [457.995 µs, 500.405 µs] 110.128 µs (29.8%)
iast_INACTIVE 444.194 µs [423.123 µs, 465.265 µs] 75.122 µs (20.4%)
iast_TELEMETRY_OFF 471.712 µs [450.075 µs, 493.348 µs] 102.64 µs (27.8%)
tracing 444.025 µs [423.016 µs, 465.033 µs] 74.953 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.343 µs [350.616 µs, 390.071 µs] -
iast 482.391 µs [461.188 µs, 503.594 µs] 112.048 µs (30.3%)
iast_FULL 639.943 µs [618.566 µs, 661.32 µs] 269.6 µs (72.8%)
iast_GLOBAL 514.937 µs [493.504 µs, 536.37 µs] 144.594 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 484.822 µs [463.201 µs, 506.443 µs] 114.479 µs (30.9%)
iast_INACTIVE 443.458 µs [422.725 µs, 464.192 µs] 73.115 µs (19.7%)
iast_TELEMETRY_OFF 472.64 µs [451.405 µs, 493.874 µs] 102.296 µs (27.6%)
tracing 445.815 µs [425.191 µs, 466.44 µs] 75.472 µs (20.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bruce.bujon/backport-pr-7916
git_commit_date 1731422807 1731422874
git_commit_sha 6082863 557327a
release_version 1.43.0-SNAPSHOT~6082863645 1.43.0-SNAPSHOT~557327aa08
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731424685 1731424685
ci_job_id 703779559 703779559
ci_pipeline_id 48802488 48802488
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.292 ms) : 2252, 2333
.   : milestone, 2292,
iast (2.057 ms) : 2005, 2108
.   : milestone, 2057,
iast_GLOBAL (2.109 ms) : 2057, 2161
.   : milestone, 2109,
profiling (1.937 ms) : 1895, 1979
.   : milestone, 1937,
tracing (1.9 ms) : 1861, 1940
.   : milestone, 1900,
section candidate
no_agent (1.456 ms) : 1445, 1467
.   : milestone, 1456,
appsec (2.317 ms) : 2276, 2358
.   : milestone, 2317,
iast (2.064 ms) : 2012, 2116
.   : milestone, 2064,
iast_GLOBAL (2.105 ms) : 2052, 2157
.   : milestone, 2105,
profiling (1.917 ms) : 1876, 1959
.   : milestone, 1917,
tracing (1.905 ms) : 1865, 1944
.   : milestone, 1905,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.292 ms [2.252 ms, 2.333 ms] 834.556 µs (57.3%)
iast 2.057 ms [2.005 ms, 2.108 ms] 598.984 µs (41.1%)
iast_GLOBAL 2.109 ms [2.057 ms, 2.161 ms] 650.799 µs (44.6%)
profiling 1.937 ms [1.895 ms, 1.979 ms] 479.316 µs (32.9%)
tracing 1.9 ms [1.861 ms, 1.94 ms] 442.762 µs (30.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.467 ms] -
appsec 2.317 ms [2.276 ms, 2.358 ms] 861.049 µs (59.1%)
iast 2.064 ms [2.012 ms, 2.116 ms] 608.469 µs (41.8%)
iast_GLOBAL 2.105 ms [2.052 ms, 2.157 ms] 648.92 µs (44.6%)
profiling 1.917 ms [1.876 ms, 1.959 ms] 461.519 µs (31.7%)
tracing 1.905 ms [1.865 ms, 1.944 ms] 448.965 µs (30.8%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~557327aa08, baseline=1.43.0-SNAPSHOT~6082863645
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.707 s) : 15707000, 15707000
.   : milestone, 15707000,
appsec (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,
iast (18.384 s) : 18384000, 18384000
.   : milestone, 18384000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
.   : milestone, 18102000,
profiling (15.044 s) : 15044000, 15044000
.   : milestone, 15044000,
tracing (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
section candidate
no_agent (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
appsec (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
iast (18.604 s) : 18604000, 18604000
.   : milestone, 18604000,
iast_GLOBAL (18.364 s) : 18364000, 18364000
.   : milestone, 18364000,
profiling (15.245 s) : 15245000, 15245000
.   : milestone, 15245000,
tracing (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.707 s [15.707 s, 15.707 s] -
appsec 15.134 s [15.134 s, 15.134 s] -573.0 ms (-3.6%)
iast 18.384 s [18.384 s, 18.384 s] 2.677 s (17.0%)
iast_GLOBAL 18.102 s [18.102 s, 18.102 s] 2.395 s (15.2%)
profiling 15.044 s [15.044 s, 15.044 s] -663.0 ms (-4.2%)
tracing 14.922 s [14.922 s, 14.922 s] -785.0 ms (-5.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.024 s [15.024 s, 15.024 s] -
appsec 15.104 s [15.104 s, 15.104 s] 80.0 ms (0.5%)
iast 18.604 s [18.604 s, 18.604 s] 3.58 s (23.8%)
iast_GLOBAL 18.364 s [18.364 s, 18.364 s] 3.34 s (22.2%)
profiling 15.245 s [15.245 s, 15.245 s] 221.0 ms (1.5%)
tracing 14.969 s [14.969 s, 14.969 s] -55.0 ms (-0.4%)

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch release/v1.42.x bruce.bujon/backport-pr-7916
git_commit_date 1731074042 1731422874
git_commit_sha df0ec27 557327a
See matching parameters
Baseline Candidate
ci_job_date 1731423965 1731423965
ci_job_id 703779563 703779563
ci_pipeline_id 48802488 48802488
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@PerfectSlayer PerfectSlayer merged commit 09fedd7 into release/v1.42.x Nov 13, 2024
102 checks passed
@PerfectSlayer PerfectSlayer deleted the bruce.bujon/backport-pr-7916 branch November 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants