-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SSI guardrails entries for hbase and hive #7916
Conversation
Such software will be handled by shell script blocking
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083394
Total [baseline] (8.543 s) : 0, 8543484
Agent [candidate] (1.081 s) : 0, 1081192
Total [candidate] (8.575 s) : 0, 8574678
section iast
Agent [baseline] (1.205 s) : 0, 1205363
Total [baseline] (9.119 s) : 0, 9119273
Agent [candidate] (1.203 s) : 0, 1203413
Total [candidate] (9.088 s) : 0, 9088067
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.221 s) : 0, 1221454
Total [baseline] (9.192 s) : 0, 9191821
Agent [candidate] (1.206 s) : 0, 1205670
Total [candidate] (9.08 s) : 0, 9079948
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1207301
Total [baseline] (9.141 s) : 0, 9140990
Agent [candidate] (1.202 s) : 0, 1202135
Total [candidate] (9.077 s) : 0, 9076533
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.143 ms) : 0, 689143
BytebuddyAgent [candidate] (687.592 ms) : 0, 687592
GlobalTracer [baseline] (315.17 ms) : 0, 315170
GlobalTracer [candidate] (314.708 ms) : 0, 314708
AppSec [baseline] (54.271 ms) : 0, 54271
AppSec [candidate] (54.07 ms) : 0, 54070
Remote Config [baseline] (684.302 µs) : 0, 684
Remote Config [candidate] (679.136 µs) : 0, 679
Telemetry [baseline] (10.482 ms) : 0, 10482
Telemetry [candidate] (10.466 ms) : 0, 10466
section iast
BytebuddyAgent [baseline] (801.748 ms) : 0, 801748
BytebuddyAgent [candidate] (800.473 ms) : 0, 800473
GlobalTracer [baseline] (304.269 ms) : 0, 304269
GlobalTracer [candidate] (303.851 ms) : 0, 303851
AppSec [baseline] (56.4 ms) : 0, 56400
AppSec [candidate] (56.891 ms) : 0, 56891
Remote Config [baseline] (609.873 µs) : 0, 610
Remote Config [candidate] (617.795 µs) : 0, 618
Telemetry [baseline] (7.417 ms) : 0, 7417
Telemetry [candidate] (7.448 ms) : 0, 7448
IAST [baseline] (21.273 ms) : 0, 21273
IAST [candidate] (20.469 ms) : 0, 20469
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.307 ms) : 0, 812307
BytebuddyAgent [candidate] (801.86 ms) : 0, 801860
GlobalTracer [baseline] (307.491 ms) : 0, 307491
GlobalTracer [candidate] (304.002 ms) : 0, 304002
AppSec [baseline] (56.842 ms) : 0, 56842
AppSec [candidate] (57.521 ms) : 0, 57521
Remote Config [baseline] (640.151 µs) : 0, 640
Remote Config [candidate] (614.0 µs) : 0, 614
Telemetry [baseline] (7.678 ms) : 0, 7678
Telemetry [candidate] (7.427 ms) : 0, 7427
IAST [baseline] (22.719 ms) : 0, 22719
IAST [candidate] (20.556 ms) : 0, 20556
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.074 ms) : 0, 803074
BytebuddyAgent [candidate] (798.752 ms) : 0, 798752
GlobalTracer [baseline] (305.005 ms) : 0, 305005
GlobalTracer [candidate] (304.097 ms) : 0, 304097
AppSec [baseline] (57.373 ms) : 0, 57373
AppSec [candidate] (57.524 ms) : 0, 57524
Remote Config [baseline] (602.613 µs) : 0, 603
Remote Config [candidate] (601.287 µs) : 0, 601
Telemetry [baseline] (7.386 ms) : 0, 7386
Telemetry [candidate] (7.367 ms) : 0, 7367
IAST [baseline] (20.165 ms) : 0, 20165
IAST [candidate] (20.127 ms) : 0, 20127
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086692
Total [baseline] (10.306 s) : 0, 10305608
Agent [candidate] (1.077 s) : 0, 1077141
Total [candidate] (10.441 s) : 0, 10441120
section appsec
Agent [baseline] (1.212 s) : 0, 1211836
Total [baseline] (10.572 s) : 0, 10571814
Agent [candidate] (1.217 s) : 0, 1217155
Total [candidate] (10.585 s) : 0, 10585071
section iast
Agent [baseline] (1.211 s) : 0, 1211401
Total [baseline] (10.961 s) : 0, 10960563
Agent [candidate] (1.214 s) : 0, 1213650
Total [candidate] (10.804 s) : 0, 10804304
section profiling
Agent [baseline] (1.275 s) : 0, 1274929
Total [baseline] (10.677 s) : 0, 10677240
Agent [candidate] (1.275 s) : 0, 1274585
Total [candidate] (10.59 s) : 0, 10590212
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.882 ms) : 0, 690882
BytebuddyAgent [candidate] (684.919 ms) : 0, 684919
GlobalTracer [baseline] (316.046 ms) : 0, 316046
GlobalTracer [candidate] (314.102 ms) : 0, 314102
AppSec [baseline] (54.722 ms) : 0, 54722
AppSec [candidate] (54.044 ms) : 0, 54044
Remote Config [baseline] (681.802 µs) : 0, 682
Remote Config [candidate] (665.975 µs) : 0, 666
Telemetry [baseline] (10.648 ms) : 0, 10648
Telemetry [candidate] (9.802 ms) : 0, 9802
section appsec
BytebuddyAgent [baseline] (702.662 ms) : 0, 702662
BytebuddyAgent [candidate] (705.322 ms) : 0, 705322
GlobalTracer [baseline] (311.697 ms) : 0, 311697
GlobalTracer [candidate] (313.225 ms) : 0, 313225
AppSec [baseline] (165.598 ms) : 0, 165598
AppSec [candidate] (166.447 ms) : 0, 166447
Remote Config [baseline] (627.267 µs) : 0, 627
Remote Config [candidate] (634.594 µs) : 0, 635
Telemetry [baseline] (8.052 ms) : 0, 8052
Telemetry [candidate] (7.771 ms) : 0, 7771
IAST [baseline] (19.285 ms) : 0, 19285
IAST [candidate] (20.255 ms) : 0, 20255
section iast
BytebuddyAgent [baseline] (806.194 ms) : 0, 806194
BytebuddyAgent [candidate] (807.606 ms) : 0, 807606
GlobalTracer [baseline] (305.323 ms) : 0, 305323
GlobalTracer [candidate] (305.895 ms) : 0, 305895
AppSec [baseline] (57.537 ms) : 0, 57537
AppSec [candidate] (56.15 ms) : 0, 56150
Remote Config [baseline] (622.815 µs) : 0, 623
Remote Config [candidate] (619.304 µs) : 0, 619
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.4 ms) : 0, 7400
IAST [baseline] (20.555 ms) : 0, 20555
IAST [candidate] (22.255 ms) : 0, 22255
section profiling
BytebuddyAgent [baseline] (681.033 ms) : 0, 681033
BytebuddyAgent [candidate] (679.694 ms) : 0, 679694
GlobalTracer [baseline] (396.822 ms) : 0, 396822
GlobalTracer [candidate] (396.765 ms) : 0, 396765
AppSec [baseline] (54.408 ms) : 0, 54408
AppSec [candidate] (54.627 ms) : 0, 54627
Remote Config [baseline] (666.613 µs) : 0, 667
Remote Config [candidate] (674.763 µs) : 0, 675
Telemetry [baseline] (11.959 ms) : 0, 11959
Telemetry [candidate] (11.346 ms) : 0, 11346
ProfilingAgent [baseline] (91.421 ms) : 0, 91421
ProfilingAgent [candidate] (92.776 ms) : 0, 92776
Profiling [baseline] (91.444 ms) : 0, 91444
Profiling [candidate] (92.8 ms) : 0, 92800
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section baseline
no_agent (376.716 µs) : 355, 398
. : milestone, 377,
iast (492.518 µs) : 471, 514
. : milestone, 493,
iast_FULL (648.068 µs) : 627, 669
. : milestone, 648,
iast_GLOBAL (528.474 µs) : 506, 551
. : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (495.269 µs) : 474, 517
. : milestone, 495,
iast_INACTIVE (455.09 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (484.36 µs) : 462, 506
. : milestone, 484,
tracing (449.115 µs) : 428, 470
. : milestone, 449,
section candidate
no_agent (375.071 µs) : 355, 395
. : milestone, 375,
iast (491.239 µs) : 470, 512
. : milestone, 491,
iast_FULL (651.785 µs) : 630, 673
. : milestone, 652,
iast_GLOBAL (535.241 µs) : 511, 559
. : milestone, 535,
iast_HARDCODED_SECRET_DISABLED (491.315 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (457.315 µs) : 436, 479
. : milestone, 457,
iast_TELEMETRY_OFF (480.877 µs) : 460, 502
. : milestone, 481,
tracing (460.063 µs) : 438, 482
. : milestone, 460,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section baseline
no_agent (1.336 ms) : 1316, 1356
. : milestone, 1336,
appsec (1.717 ms) : 1694, 1740
. : milestone, 1717,
appsec_no_iast (1.732 ms) : 1707, 1757
. : milestone, 1732,
iast (1.483 ms) : 1461, 1506
. : milestone, 1483,
profiling (1.485 ms) : 1462, 1508
. : milestone, 1485,
tracing (1.478 ms) : 1454, 1502
. : milestone, 1478,
section candidate
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.736 ms) : 1712, 1760
. : milestone, 1736,
appsec_no_iast (1.735 ms) : 1710, 1760
. : milestone, 1735,
iast (1.495 ms) : 1472, 1517
. : milestone, 1495,
profiling (1.481 ms) : 1458, 1504
. : milestone, 1481,
tracing (1.49 ms) : 1463, 1516
. : milestone, 1490,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.35 ms) : 2308, 2391
. : milestone, 2350,
iast (2.076 ms) : 2024, 2128
. : milestone, 2076,
iast_GLOBAL (2.126 ms) : 2073, 2179
. : milestone, 2126,
profiling (1.922 ms) : 1881, 1962
. : milestone, 1922,
tracing (1.925 ms) : 1885, 1965
. : milestone, 1925,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.339 ms) : 2298, 2380
. : milestone, 2339,
iast (2.087 ms) : 2034, 2139
. : milestone, 2087,
iast_GLOBAL (2.112 ms) : 2061, 2164
. : milestone, 2112,
profiling (1.942 ms) : 1900, 1983
. : milestone, 1942,
tracing (1.913 ms) : 1874, 1953
. : milestone, 1913,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~a9bd665705, baseline=1.43.0-SNAPSHOT~04249697bb
dateFormat X
axisFormat %s
section baseline
no_agent (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
appsec (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
iast (18.955 s) : 18955000, 18955000
. : milestone, 18955000,
iast_GLOBAL (18.169 s) : 18169000, 18169000
. : milestone, 18169000,
profiling (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
tracing (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
section candidate
no_agent (15.564 s) : 15564000, 15564000
. : milestone, 15564000,
appsec (15.402 s) : 15402000, 15402000
. : milestone, 15402000,
iast (18.735 s) : 18735000, 18735000
. : milestone, 18735000,
iast_GLOBAL (18.463 s) : 18463000, 18463000
. : milestone, 18463000,
profiling (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
tracing (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
What Does This Do
This PR removes SSI guardrails entries for HBase and Hive.
Motivation
Hadoop, Hbase and Hive will be blocked using the shell script blocking rules from the injector repository.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMLP-177 [APMLP-178]