Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🍒 7883] Protect currentContext access for reactor inner operators #7895

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

amarziali
Copy link
Collaborator

Backport #7883 to release/v1.42.x

@amarziali amarziali requested a review from a team as a code owner November 6, 2024 08:10
@amarziali amarziali added type: bug inst: reactor Reactor instrumentation labels Nov 6, 2024
@amarziali amarziali added this to the 1.42.1 milestone Nov 6, 2024
@amarziali amarziali enabled auto-merge (squash) November 6, 2024 08:12
@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1730881178 1730881554
end_time 2024-11-06T08:20:53 2024-11-06T08:27:09
git_branch master andrea.marziali/backport-pr-7883
git_commit_sha 21c0b2d 9ef1718
start_time 2024-11-06T08:19:39 2024-11-06T08:25:55
See matching parameters
Baseline Candidate
ci_job_id 696810304 696810304
ci_pipeline_id 48321402 48321402
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1730880611 1730880611

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+628.227µs; +635.838µs] or [+6.176%; +6.251%]
worse
[+618.904µs; +673.945µs] or [+5.990%; +6.523%]
worse
[+571.705µs; +674.901µs] or [+5.483%; +6.472%]
worse
[+709.405µs; +1178.540µs] or [+6.597%; +10.960%]
worse
[-6.266op/s; -4.942op/s] or [-6.548%; -5.164%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-20.421µs; +14.665µs] or [-7.741%; +5.559%]
unstable
[-34.305µs; +23.103µs] or [-11.310%; +7.617%]
unstable
[-45.380µs; +33.188µs] or [-14.354%; +10.498%]
unstable
[-100.986µs; +81.781µs] or [-16.874%; +13.665%]
same
scenario:basic unsure
[-12.028µs; -2.502µs] or [-4.347%; -0.904%]
same same unstable
[-36.246µs; +66.766µs] or [-6.659%; +12.266%]
same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (303.308 µs) : 274, 333
.   : milestone, 303,
basic (304.444 µs) : 296, 313
.   : milestone, 304,
loop (10.332 ms) : 10304, 10359
.   : milestone, 10332,
section candidate
noprobe (297.707 µs) : 273, 323
.   : milestone, 298,
basic (298.453 µs) : 290, 307
.   : milestone, 298,
loop (10.978 ms) : 10955, 11002
.   : milestone, 10978,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 303.308 µs [273.778 µs, 332.837 µs]
basic 304.444 µs [295.529 µs, 313.36 µs]
loop 10.332 ms [10.304 ms, 10.359 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 297.707 µs [272.661 µs, 322.752 µs]
basic 298.453 µs [290.18 µs, 306.726 µs]
loop 10.978 ms [10.955 ms, 11.002 ms]

@amarziali amarziali merged commit 92bc5b5 into release/v1.42.x Nov 6, 2024
91 of 98 checks passed
@amarziali amarziali deleted the andrea.marziali/backport-pr-7883 branch November 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: reactor Reactor instrumentation type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants