Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect currentContext access for reactor inner operators #7883

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Protect currentContext access for reactor inner operators #7883

merged 1 commit into from
Nov 5, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

CoreSubscriber instrumentation access to the subscriber context via the currentContext method.
While this is not expected to throw, it may happen that inner operators like reactor.core.publisher.FluxWindowPredicate$WindowFlux might throw a NPE because it's implementation is defined as

interface InnerOperator<I, O> extends InnerConsumer<I>, InnerProducer<O> {
    default Context currentContext() {
        return this.actual().currentContext();
    }
}

and actual() returns null

I also put a test to ensure that we do not have unhandled exception in that instrumentation. As well I protected other potential unsafe access context and cleaned up a leftover

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner November 5, 2024 11:07
@amarziali amarziali added type: bug inst: reactor Reactor instrumentation labels Nov 5, 2024
@amarziali amarziali enabled auto-merge (squash) November 5, 2024 11:13
@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/reactor-npe
git_commit_date 1730797550 1730804607
git_commit_sha 318e5c8 490c9af
release_version 1.43.0-SNAPSHOT~318e5c8bcf 1.43.0-SNAPSHOT~490c9afce2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730807622 1730807622
ci_job_id 695424285 695424285
ci_pipeline_id 48240626 48240626
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.596 s) : 0, 1596139
Total [baseline] (11.874 s) : 0, 11874125
Agent [candidate] (1.586 s) : 0, 1586424
Total [candidate] (11.91 s) : 0, 11910211
section iast
Agent [baseline] (1.756 s) : 0, 1755757
Total [baseline] (12.907 s) : 0, 12907248
Agent [candidate] (1.761 s) : 0, 1760666
Total [candidate] (12.809 s) : 0, 12809463
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.761 s) : 0, 1760993
Total [baseline] (12.81 s) : 0, 12809636
Agent [candidate] (1.761 s) : 0, 1760526
Total [candidate] (12.784 s) : 0, 12784187
section iast_TELEMETRY_OFF
Agent [baseline] (1.754 s) : 0, 1754477
Total [baseline] (12.825 s) : 0, 12825195
Agent [candidate] (1.754 s) : 0, 1753736
Total [candidate] (12.854 s) : 0, 12854170
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.596 s -
Agent iast 1.756 s 159.618 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.761 s 164.854 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.754 s 158.338 ms (9.9%)
Total tracing 11.874 s -
Total iast 12.907 s 1.033 s (8.7%)
Total iast_HARDCODED_SECRET_DISABLED 12.81 s 935.511 ms (7.9%)
Total iast_TELEMETRY_OFF 12.825 s 951.07 ms (8.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.586 s -
Agent iast 1.761 s 174.242 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.761 s 174.102 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.754 s 167.312 ms (10.5%)
Total tracing 11.91 s -
Total iast 12.809 s 899.252 ms (7.6%)
Total iast_HARDCODED_SECRET_DISABLED 12.784 s 873.976 ms (7.3%)
Total iast_TELEMETRY_OFF 12.854 s 943.959 ms (7.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.02 s) : 0, 1019570
BytebuddyAgent [candidate] (1.013 s) : 0, 1012730
GlobalTracer [baseline] (467.893 ms) : 0, 467893
GlobalTracer [candidate] (466.079 ms) : 0, 466079
AppSec [baseline] (75.351 ms) : 0, 75351
AppSec [candidate] (75.382 ms) : 0, 75382
Remote Config [baseline] (810.448 µs) : 0, 810
Remote Config [candidate] (808.29 µs) : 0, 808
Telemetry [baseline] (12.207 ms) : 0, 12207
Telemetry [candidate] (11.216 ms) : 0, 11216
section iast
BytebuddyAgent [baseline] (1.176 s) : 0, 1175878
BytebuddyAgent [candidate] (1.179 s) : 0, 1178569
GlobalTracer [baseline] (445.025 ms) : 0, 445025
GlobalTracer [candidate] (446.353 ms) : 0, 446353
AppSec [baseline] (76.42 ms) : 0, 76420
AppSec [candidate] (77.444 ms) : 0, 77444
IAST [baseline] (28.112 ms) : 0, 28112
IAST [candidate] (27.634 ms) : 0, 27634
Remote Config [baseline] (735.347 µs) : 0, 735
Remote Config [candidate] (753.31 µs) : 0, 753
Telemetry [baseline] (9.381 ms) : 0, 9381
Telemetry [candidate] (9.595 ms) : 0, 9595
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.179 s) : 0, 1178714
BytebuddyAgent [candidate] (1.178 s) : 0, 1178387
GlobalTracer [baseline] (446.303 ms) : 0, 446303
GlobalTracer [candidate] (446.642 ms) : 0, 446642
AppSec [baseline] (77.521 ms) : 0, 77521
AppSec [candidate] (78.164 ms) : 0, 78164
IAST [baseline] (27.776 ms) : 0, 27776
IAST [candidate] (26.763 ms) : 0, 26763
Remote Config [baseline] (762.804 µs) : 0, 763
Remote Config [candidate] (753.87 µs) : 0, 754
Telemetry [baseline] (9.704 ms) : 0, 9704
Telemetry [candidate] (9.509 ms) : 0, 9509
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.173 s) : 0, 1172844
BytebuddyAgent [candidate] (1.173 s) : 0, 1172710
GlobalTracer [baseline] (446.032 ms) : 0, 446032
GlobalTracer [candidate] (445.909 ms) : 0, 445909
AppSec [baseline] (78.011 ms) : 0, 78011
AppSec [candidate] (78.379 ms) : 0, 78379
IAST [baseline] (26.308 ms) : 0, 26308
IAST [candidate] (26.302 ms) : 0, 26302
Remote Config [baseline] (745.193 µs) : 0, 745
Remote Config [candidate] (745.245 µs) : 0, 745
Telemetry [baseline] (10.313 ms) : 0, 10313
Telemetry [candidate] (9.424 ms) : 0, 9424
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.596 s) : 0, 1595930
Total [baseline] (14.392 s) : 0, 14392429
Agent [candidate] (1.59 s) : 0, 1589590
Total [candidate] (14.341 s) : 0, 14341121
section appsec
Agent [baseline] (1.796 s) : 0, 1795611
Total [baseline] (14.582 s) : 0, 14582191
Agent [candidate] (1.793 s) : 0, 1792576
Total [candidate] (14.695 s) : 0, 14695446
section iast
Agent [baseline] (1.769 s) : 0, 1768577
Total [baseline] (14.986 s) : 0, 14985631
Agent [candidate] (1.764 s) : 0, 1763793
Total [candidate] (14.997 s) : 0, 14997137
section profiling
Agent [baseline] (1.914 s) : 0, 1914068
Total [baseline] (14.647 s) : 0, 14646995
Agent [candidate] (1.917 s) : 0, 1916695
Total [candidate] (14.651 s) : 0, 14650694
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.596 s -
Agent appsec 1.796 s 199.681 ms (12.5%)
Agent iast 1.769 s 172.648 ms (10.8%)
Agent profiling 1.914 s 318.138 ms (19.9%)
Total tracing 14.392 s -
Total appsec 14.582 s 189.762 ms (1.3%)
Total iast 14.986 s 593.202 ms (4.1%)
Total profiling 14.647 s 254.566 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.59 s -
Agent appsec 1.793 s 202.986 ms (12.8%)
Agent iast 1.764 s 174.203 ms (11.0%)
Agent profiling 1.917 s 327.105 ms (20.6%)
Total tracing 14.341 s -
Total appsec 14.695 s 354.325 ms (2.5%)
Total iast 14.997 s 656.016 ms (4.6%)
Total profiling 14.651 s 309.573 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.019 s) : 0, 1019245
BytebuddyAgent [candidate] (1.016 s) : 0, 1015566
GlobalTracer [baseline] (467.278 ms) : 0, 467278
GlobalTracer [candidate] (466.61 ms) : 0, 466610
AppSec [baseline] (75.933 ms) : 0, 75933
AppSec [candidate] (75.7 ms) : 0, 75700
Remote Config [baseline] (838.981 µs) : 0, 839
Remote Config [candidate] (819.496 µs) : 0, 819
Telemetry [baseline] (12.343 ms) : 0, 12343
Telemetry [candidate] (10.605 ms) : 0, 10605
section appsec
BytebuddyAgent [baseline] (1.043 s) : 0, 1042902
BytebuddyAgent [candidate] (1.041 s) : 0, 1040707
GlobalTracer [baseline] (463.883 ms) : 0, 463883
GlobalTracer [candidate] (462.682 ms) : 0, 462682
AppSec [baseline] (243.639 ms) : 0, 243639
AppSec [candidate] (244.012 ms) : 0, 244012
IAST [baseline] (25.915 ms) : 0, 25915
IAST [candidate] (28.214 ms) : 0, 28214
Remote Config [baseline] (798.714 µs) : 0, 799
Remote Config [candidate] (796.509 µs) : 0, 797
Telemetry [baseline] (11.179 ms) : 0, 11179
Telemetry [candidate] (10.009 ms) : 0, 10009
section iast
BytebuddyAgent [baseline] (1.184 s) : 0, 1184240
BytebuddyAgent [candidate] (1.181 s) : 0, 1181200
GlobalTracer [baseline] (447.628 ms) : 0, 447628
GlobalTracer [candidate] (446.446 ms) : 0, 446446
AppSec [baseline] (76.289 ms) : 0, 76289
AppSec [candidate] (77.783 ms) : 0, 77783
IAST [baseline] (28.824 ms) : 0, 28824
IAST [candidate] (27.773 ms) : 0, 27773
Remote Config [baseline] (762.351 µs) : 0, 762
Remote Config [candidate] (742.826 µs) : 0, 743
Telemetry [baseline] (10.452 ms) : 0, 10452
Telemetry [candidate] (9.509 ms) : 0, 9509
section profiling
BytebuddyAgent [baseline] (1.007 s) : 0, 1006768
BytebuddyAgent [candidate] (1.009 s) : 0, 1008536
GlobalTracer [baseline] (595.52 ms) : 0, 595520
GlobalTracer [candidate] (596.942 ms) : 0, 596942
AppSec [baseline] (76.077 ms) : 0, 76077
AppSec [candidate] (76.507 ms) : 0, 76507
Remote Config [baseline] (845.477 µs) : 0, 845
Remote Config [candidate] (865.46 µs) : 0, 865
Telemetry [baseline] (11.632 ms) : 0, 11632
Telemetry [candidate] (13.26 ms) : 0, 13260
ProfilingAgent [baseline] (165.408 ms) : 0, 165408
ProfilingAgent [candidate] (162.561 ms) : 0, 162561
Profiling [baseline] (165.462 ms) : 0, 165462
Profiling [candidate] (162.615 ms) : 0, 162615
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-05T11:12:39 2024-11-05T11:21:48
git_branch master andrea.marziali/reactor-npe
git_commit_date 1730797550 1730804607
git_commit_sha 318e5c8 490c9af
release_version 1.43.0-SNAPSHOT~318e5c8bcf 1.43.0-SNAPSHOT~490c9afce2
start_time 2024-11-05T11:12:23 2024-11-05T11:21:32
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730806171 1730806171
ci_job_id 695424286 695424286
ci_pipeline_id 48240626 48240626
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 21 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-116.796µs; -46.528µs] or [-5.868%; -2.338%]		 unstable
[-254.118op/s; +548.235op/s] or [-10.800%; +23.300%]		 1.909ms 2500.000op/s 1.990ms 2352.941op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.699 ms) : 1674, 1723
.   : milestone, 1699,
appsec (2.196 ms) : 2164, 2228
.   : milestone, 2196,
appsec_no_iast (2.181 ms) : 2149, 2213
.   : milestone, 2181,
iast (1.874 ms) : 1844, 1904
.   : milestone, 1874,
profiling (1.99 ms) : 1955, 2025
.   : milestone, 1990,
tracing (1.878 ms) : 1846, 1910
.   : milestone, 1878,
section candidate
no_agent (1.708 ms) : 1684, 1731
.   : milestone, 1708,
appsec (2.193 ms) : 2162, 2225
.   : milestone, 2193,
appsec_no_iast (2.217 ms) : 2186, 2249
.   : milestone, 2217,
iast (1.897 ms) : 1867, 1927
.   : milestone, 1897,
profiling (1.909 ms) : 1879, 1939
.   : milestone, 1909,
tracing (1.875 ms) : 1843, 1906
.   : milestone, 1875,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.699 ms [1.674 ms, 1.723 ms] -
appsec 2.196 ms [2.164 ms, 2.228 ms] 497.084 µs (29.3%)
appsec_no_iast 2.181 ms [2.149 ms, 2.213 ms] 482.607 µs (28.4%)
iast 1.874 ms [1.844 ms, 1.904 ms] 175.296 µs (10.3%)
profiling 1.99 ms [1.955 ms, 2.025 ms] 291.587 µs (17.2%)
tracing 1.878 ms [1.846 ms, 1.91 ms] 179.378 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.708 ms [1.684 ms, 1.731 ms] -
appsec 2.193 ms [2.162 ms, 2.225 ms] 485.713 µs (28.4%)
appsec_no_iast 2.217 ms [2.186 ms, 2.249 ms] 509.732 µs (29.8%)
iast 1.897 ms [1.867 ms, 1.927 ms] 189.373 µs (11.1%)
profiling 1.909 ms [1.879 ms, 1.939 ms] 200.927 µs (11.8%)
tracing 1.875 ms [1.843 ms, 1.906 ms] 166.916 µs (9.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (455.911 µs) : 427, 484
.   : milestone, 456,
iast (586.211 µs) : 553, 619
.   : milestone, 586,
iast_FULL (831.896 µs) : 799, 865
.   : milestone, 832,
iast_GLOBAL (618.375 µs) : 585, 651
.   : milestone, 618,
iast_HARDCODED_SECRET_DISABLED (590.72 µs) : 558, 623
.   : milestone, 591,
iast_INACTIVE (536.93 µs) : 506, 568
.   : milestone, 537,
iast_TELEMETRY_OFF (578.942 µs) : 547, 611
.   : milestone, 579,
tracing (535.274 µs) : 505, 565
.   : milestone, 535,
section candidate
no_agent (445.659 µs) : 417, 475
.   : milestone, 446,
iast (580.054 µs) : 547, 613
.   : milestone, 580,
iast_FULL (825.56 µs) : 794, 857
.   : milestone, 826,
iast_GLOBAL (617.252 µs) : 584, 650
.   : milestone, 617,
iast_HARDCODED_SECRET_DISABLED (591.882 µs) : 560, 624
.   : milestone, 592,
iast_INACTIVE (544.447 µs) : 514, 575
.   : milestone, 544,
iast_TELEMETRY_OFF (573.343 µs) : 542, 604
.   : milestone, 573,
tracing (538.513 µs) : 509, 568
.   : milestone, 539,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 455.911 µs [427.398 µs, 484.424 µs] -
iast 586.211 µs [553.397 µs, 619.025 µs] 130.3 µs (28.6%)
iast_FULL 831.896 µs [799.095 µs, 864.698 µs] 375.986 µs (82.5%)
iast_GLOBAL 618.375 µs [585.499 µs, 651.251 µs] 162.464 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 590.72 µs [558.405 µs, 623.034 µs] 134.809 µs (29.6%)
iast_INACTIVE 536.93 µs [506.152 µs, 567.709 µs] 81.02 µs (17.8%)
iast_TELEMETRY_OFF 578.942 µs [546.71 µs, 611.173 µs] 123.031 µs (27.0%)
tracing 535.274 µs [505.352 µs, 565.197 µs] 79.363 µs (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 445.659 µs [416.702 µs, 474.615 µs] -
iast 580.054 µs [547.36 µs, 612.748 µs] 134.395 µs (30.2%)
iast_FULL 825.56 µs [793.807 µs, 857.313 µs] 379.901 µs (85.2%)
iast_GLOBAL 617.252 µs [584.333 µs, 650.171 µs] 171.593 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 591.882 µs [559.608 µs, 624.156 µs] 146.223 µs (32.8%)
iast_INACTIVE 544.447 µs [513.735 µs, 575.158 µs] 98.788 µs (22.2%)
iast_TELEMETRY_OFF 573.343 µs [542.209 µs, 604.476 µs] 127.684 µs (28.7%)
tracing 538.513 µs [508.693 µs, 568.332 µs] 92.854 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/reactor-npe
git_commit_date 1730797550 1730804607
git_commit_sha 318e5c8 490c9af
release_version 1.43.0-SNAPSHOT~318e5c8bcf 1.43.0-SNAPSHOT~490c9afce2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730806434 1730806434
ci_job_id 695424287 695424287
ci_pipeline_id 48240626 48240626
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.184 s) : 15184000, 15184000
.   : milestone, 15184000,
appsec (15.23 s) : 15230000, 15230000
.   : milestone, 15230000,
iast (18.975 s) : 18975000, 18975000
.   : milestone, 18975000,
iast_GLOBAL (18.286 s) : 18286000, 18286000
.   : milestone, 18286000,
profiling (15.383 s) : 15383000, 15383000
.   : milestone, 15383000,
tracing (15.241 s) : 15241000, 15241000
.   : milestone, 15241000,
section candidate
no_agent (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
appsec (15.325 s) : 15325000, 15325000
.   : milestone, 15325000,
iast (18.675 s) : 18675000, 18675000
.   : milestone, 18675000,
iast_GLOBAL (18.19 s) : 18190000, 18190000
.   : milestone, 18190000,
profiling (15.708 s) : 15708000, 15708000
.   : milestone, 15708000,
tracing (15.092 s) : 15092000, 15092000
.   : milestone, 15092000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.184 s [15.184 s, 15.184 s] -
appsec 15.23 s [15.23 s, 15.23 s] 46.0 ms (0.3%)
iast 18.975 s [18.975 s, 18.975 s] 3.791 s (25.0%)
iast_GLOBAL 18.286 s [18.286 s, 18.286 s] 3.102 s (20.4%)
profiling 15.383 s [15.383 s, 15.383 s] 199.0 ms (1.3%)
tracing 15.241 s [15.241 s, 15.241 s] 57.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.369 s [15.369 s, 15.369 s] -
appsec 15.325 s [15.325 s, 15.325 s] -44.0 ms (-0.3%)
iast 18.675 s [18.675 s, 18.675 s] 3.306 s (21.5%)
iast_GLOBAL 18.19 s [18.19 s, 18.19 s] 2.821 s (18.4%)
profiling 15.708 s [15.708 s, 15.708 s] 339.0 ms (2.2%)
tracing 15.092 s [15.092 s, 15.092 s] -277.0 ms (-1.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~490c9afce2, baseline=1.43.0-SNAPSHOT~318e5c8bcf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.345 ms) : 2304, 2385
.   : milestone, 2345,
iast (2.086 ms) : 2035, 2138
.   : milestone, 2086,
iast_GLOBAL (2.138 ms) : 2086, 2190
.   : milestone, 2138,
profiling (1.939 ms) : 1897, 1981
.   : milestone, 1939,
tracing (1.925 ms) : 1885, 1965
.   : milestone, 1925,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.349 ms) : 2308, 2391
.   : milestone, 2349,
iast (2.092 ms) : 2040, 2144
.   : milestone, 2092,
iast_GLOBAL (2.132 ms) : 2080, 2184
.   : milestone, 2132,
profiling (1.956 ms) : 1914, 1998
.   : milestone, 1956,
tracing (1.929 ms) : 1889, 1970
.   : milestone, 1929,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.345 ms [2.304 ms, 2.385 ms] 872.406 µs (59.3%)
iast 2.086 ms [2.035 ms, 2.138 ms] 613.655 µs (41.7%)
iast_GLOBAL 2.138 ms [2.086 ms, 2.19 ms] 665.592 µs (45.2%)
profiling 1.939 ms [1.897 ms, 1.981 ms] 466.682 µs (31.7%)
tracing 1.925 ms [1.885 ms, 1.965 ms] 452.45 µs (30.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.349 ms [2.308 ms, 2.391 ms] 879.803 µs (59.9%)
iast 2.092 ms [2.04 ms, 2.144 ms] 622.018 µs (42.3%)
iast_GLOBAL 2.132 ms [2.08 ms, 2.184 ms] 662.319 µs (45.1%)
profiling 1.956 ms [1.914 ms, 1.998 ms] 485.992 µs (33.1%)
tracing 1.929 ms [1.889 ms, 1.97 ms] 459.676 µs (31.3%)

@amarziali amarziali merged commit 281aa19 into master Nov 5, 2024
97 of 99 checks passed
@amarziali amarziali deleted the andrea.marziali/reactor-npe branch November 5, 2024 12:15
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 5, 2024
@ygree ygree modified the milestones: 1.43.0, 1.42.1 Nov 5, 2024
ygree pushed a commit that referenced this pull request Nov 5, 2024
@amarziali @ygree
Protect currentContext access for reactor inner operators (#7883)
6473a81
@amarziali amarziali mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

Assignees
No one assigned
Labels
inst: reactor Reactor instrumentation type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amarziali @smola @ygree