-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7866] Remove hadoop from the denylist #7868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082366
Total [baseline] (10.307 s) : 0, 10306883
Agent [candidate] (1.075 s) : 0, 1075064
Total [candidate] (10.556 s) : 0, 10556360
section appsec
Agent [baseline] (1.221 s) : 0, 1220657
Total [baseline] (10.705 s) : 0, 10705154
Agent [candidate] (1.209 s) : 0, 1208600
Total [candidate] (10.553 s) : 0, 10553442
section iast
Agent [baseline] (1.214 s) : 0, 1214071
Total [baseline] (10.994 s) : 0, 10994142
Agent [candidate] (1.2 s) : 0, 1199840
Total [candidate] (10.851 s) : 0, 10851267
section profiling
Agent [baseline] (1.278 s) : 0, 1278048
Total [baseline] (10.711 s) : 0, 10711000
Agent [candidate] (1.27 s) : 0, 1270046
Total [candidate] (10.668 s) : 0, 10668044
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.354 ms) : 0, 688354
BytebuddyAgent [candidate] (685.02 ms) : 0, 685020
GlobalTracer [baseline] (315.843 ms) : 0, 315843
GlobalTracer [candidate] (314.131 ms) : 0, 314131
AppSec [baseline] (54.032 ms) : 0, 54032
AppSec [candidate] (54.063 ms) : 0, 54063
Remote Config [baseline] (661.335 µs) : 0, 661
Remote Config [candidate] (663.214 µs) : 0, 663
Telemetry [baseline] (9.812 ms) : 0, 9812
Telemetry [candidate] (7.528 ms) : 0, 7528
section appsec
BytebuddyAgent [baseline] (707.997 ms) : 0, 707997
BytebuddyAgent [candidate] (701.77 ms) : 0, 701770
GlobalTracer [baseline] (314.2 ms) : 0, 314200
GlobalTracer [candidate] (310.027 ms) : 0, 310027
AppSec [baseline] (166.593 ms) : 0, 166593
AppSec [candidate] (164.031 ms) : 0, 164031
Remote Config [baseline] (644.647 µs) : 0, 645
Remote Config [candidate] (639.725 µs) : 0, 640
Telemetry [baseline] (7.77 ms) : 0, 7770
Telemetry [candidate] (8.853 ms) : 0, 8853
IAST [baseline] (19.473 ms) : 0, 19473
IAST [candidate] (19.195 ms) : 0, 19195
section iast
BytebuddyAgent [baseline] (808.983 ms) : 0, 808983
BytebuddyAgent [candidate] (798.614 ms) : 0, 798614
GlobalTracer [baseline] (304.512 ms) : 0, 304512
GlobalTracer [candidate] (301.409 ms) : 0, 301409
AppSec [baseline] (56.224 ms) : 0, 56224
AppSec [candidate] (56.433 ms) : 0, 56433
Remote Config [baseline] (616.469 µs) : 0, 616
Remote Config [candidate] (610.166 µs) : 0, 610
Telemetry [baseline] (7.45 ms) : 0, 7450
Telemetry [candidate] (7.005 ms) : 0, 7005
IAST [baseline] (22.53 ms) : 0, 22530
IAST [candidate] (22.124 ms) : 0, 22124
section profiling
ProfilingAgent [baseline] (92.695 ms) : 0, 92695
ProfilingAgent [candidate] (96.517 ms) : 0, 96517
BytebuddyAgent [baseline] (681.595 ms) : 0, 681595
BytebuddyAgent [candidate] (676.891 ms) : 0, 676891
GlobalTracer [baseline] (398.601 ms) : 0, 398601
GlobalTracer [candidate] (395.332 ms) : 0, 395332
AppSec [baseline] (54.373 ms) : 0, 54373
AppSec [candidate] (54.516 ms) : 0, 54516
Remote Config [baseline] (669.54 µs) : 0, 670
Remote Config [candidate] (651.96 µs) : 0, 652
Telemetry [baseline] (11.377 ms) : 0, 11377
Telemetry [candidate] (7.446 ms) : 0, 7446
Profiling [baseline] (92.719 ms) : 0, 92719
Profiling [candidate] (96.541 ms) : 0, 96541
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079659
Total [baseline] (8.592 s) : 0, 8591785
Agent [candidate] (1.08 s) : 0, 1079954
Total [candidate] (8.613 s) : 0, 8613155
section iast
Agent [baseline] (1.206 s) : 0, 1206434
Total [baseline] (9.167 s) : 0, 9167405
Agent [candidate] (1.206 s) : 0, 1206099
Total [candidate] (9.107 s) : 0, 9107261
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1205905
Total [baseline] (9.12 s) : 0, 9119501
Agent [candidate] (1.203 s) : 0, 1202797
Total [candidate] (9.068 s) : 0, 9067969
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201538
Total [baseline] (9.105 s) : 0, 9104631
Agent [candidate] (1.195 s) : 0, 1194741
Total [candidate] (9.08 s) : 0, 9080401
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.394 ms) : 0, 686394
BytebuddyAgent [candidate] (688.091 ms) : 0, 688091
GlobalTracer [baseline] (314.891 ms) : 0, 314891
GlobalTracer [candidate] (315.119 ms) : 0, 315119
AppSec [baseline] (54.199 ms) : 0, 54199
AppSec [candidate] (54.698 ms) : 0, 54698
Remote Config [baseline] (672.06 µs) : 0, 672
Remote Config [candidate] (669.915 µs) : 0, 670
Telemetry [baseline] (9.849 ms) : 0, 9849
Telemetry [candidate] (7.596 ms) : 0, 7596
section iast
BytebuddyAgent [baseline] (802.56 ms) : 0, 802560
BytebuddyAgent [candidate] (803.526 ms) : 0, 803526
GlobalTracer [baseline] (303.954 ms) : 0, 303954
GlobalTracer [candidate] (303.133 ms) : 0, 303133
AppSec [baseline] (57.421 ms) : 0, 57421
AppSec [candidate] (56.289 ms) : 0, 56289
IAST [baseline] (20.684 ms) : 0, 20684
IAST [candidate] (21.609 ms) : 0, 21609
Remote Config [baseline] (603.953 µs) : 0, 604
Remote Config [candidate] (624.247 µs) : 0, 624
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.154 ms) : 0, 7154
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.331 ms) : 0, 802331
BytebuddyAgent [candidate] (800.762 ms) : 0, 800762
GlobalTracer [baseline] (304.468 ms) : 0, 304468
GlobalTracer [candidate] (302.163 ms) : 0, 302163
AppSec [baseline] (57.133 ms) : 0, 57133
AppSec [candidate] (56.291 ms) : 0, 56291
IAST [baseline] (20.345 ms) : 0, 20345
IAST [candidate] (22.221 ms) : 0, 22221
Remote Config [baseline] (593.84 µs) : 0, 594
Remote Config [candidate] (605.231 µs) : 0, 605
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (7.058 ms) : 0, 7058
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.65 ms) : 0, 798650
BytebuddyAgent [candidate] (794.678 ms) : 0, 794678
GlobalTracer [baseline] (303.966 ms) : 0, 303966
GlobalTracer [candidate] (301.074 ms) : 0, 301074
AppSec [baseline] (57.39 ms) : 0, 57390
AppSec [candidate] (54.739 ms) : 0, 54739
IAST [baseline] (19.95 ms) : 0, 19950
IAST [candidate] (23.117 ms) : 0, 23117
Remote Config [baseline] (594.984 µs) : 0, 595
Remote Config [candidate] (598.235 µs) : 0, 598
Telemetry [baseline] (7.357 ms) : 0, 7357
Telemetry [candidate] (6.888 ms) : 0, 6888
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1365
. : milestone, 1346,
appsec (1.719 ms) : 1696, 1742
. : milestone, 1719,
appsec_no_iast (1.709 ms) : 1684, 1733
. : milestone, 1709,
iast (1.475 ms) : 1453, 1498
. : milestone, 1475,
profiling (1.526 ms) : 1502, 1550
. : milestone, 1526,
tracing (1.488 ms) : 1463, 1513
. : milestone, 1488,
section candidate
no_agent (1.347 ms) : 1328, 1367
. : milestone, 1347,
appsec (1.719 ms) : 1695, 1744
. : milestone, 1719,
appsec_no_iast (1.703 ms) : 1679, 1728
. : milestone, 1703,
iast (1.462 ms) : 1439, 1485
. : milestone, 1462,
profiling (1.521 ms) : 1496, 1545
. : milestone, 1521,
tracing (1.466 ms) : 1441, 1490
. : milestone, 1466,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section baseline
no_agent (373.794 µs) : 354, 393
. : milestone, 374,
iast (485.852 µs) : 465, 507
. : milestone, 486,
iast_FULL (645.08 µs) : 624, 666
. : milestone, 645,
iast_GLOBAL (513.921 µs) : 492, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (489.475 µs) : 468, 511
. : milestone, 489,
iast_INACTIVE (439.369 µs) : 419, 460
. : milestone, 439,
iast_TELEMETRY_OFF (484.29 µs) : 462, 506
. : milestone, 484,
tracing (438.072 µs) : 418, 458
. : milestone, 438,
section candidate
no_agent (368.304 µs) : 349, 388
. : milestone, 368,
iast (490.565 µs) : 469, 512
. : milestone, 491,
iast_FULL (552.692 µs) : 532, 574
. : milestone, 553,
iast_GLOBAL (511.881 µs) : 490, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (485.921 µs) : 465, 507
. : milestone, 486,
iast_INACTIVE (449.937 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (470.768 µs) : 450, 492
. : milestone, 471,
tracing (442.822 µs) : 422, 464
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.333 ms) : 2292, 2374
. : milestone, 2333,
iast (2.078 ms) : 2025, 2131
. : milestone, 2078,
iast_GLOBAL (2.127 ms) : 2073, 2180
. : milestone, 2127,
profiling (1.953 ms) : 1910, 1995
. : milestone, 1953,
tracing (1.925 ms) : 1885, 1966
. : milestone, 1925,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.342 ms) : 2301, 2384
. : milestone, 2342,
iast (2.078 ms) : 2026, 2131
. : milestone, 2078,
iast_GLOBAL (2.121 ms) : 2068, 2173
. : milestone, 2121,
profiling (1.949 ms) : 1907, 1992
. : milestone, 1949,
tracing (1.922 ms) : 1882, 1963
. : milestone, 1922,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~6aeece7207, baseline=1.42.0-SNAPSHOT~6bf7492637
dateFormat X
axisFormat %s
section baseline
no_agent (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.982 s) : 18982000, 18982000
. : milestone, 18982000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.386 s) : 15386000, 15386000
. : milestone, 15386000,
tracing (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
section candidate
no_agent (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
appsec (15.419 s) : 15419000, 15419000
. : milestone, 15419000,
iast (19.065 s) : 19065000, 19065000
. : milestone, 19065000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
profiling (15.566 s) : 15566000, 15566000
. : milestone, 15566000,
tracing (15.367 s) : 15367000, 15367000
. : milestone, 15367000,
|
PerfectSlayer
approved these changes
Nov 1, 2024
dougqh
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Cherry pick #7866
Motivation
DJM relies on the Hadoop instrumentation to integrate with Spark jobs. We didn't originally consider DJM to be in scope for SSI, hence the original addition. However as some customers are already using DJM with SSI we are removing it from the list.
Additional Notes
DJM will add additional integration tests for the integration and SSI at a later date
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]