-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hadoop from the denylist #7866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked the related card and labelled the issue. Can you add a detailed comment about why we are reverting as description?
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 53 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1101573
Total [baseline] (8.623 s) : 0, 8623166
Agent [candidate] (1.084 s) : 0, 1084133
Total [candidate] (8.582 s) : 0, 8581734
section iast
Agent [baseline] (1.209 s) : 0, 1209398
Total [baseline] (9.149 s) : 0, 9148516
Agent [candidate] (1.206 s) : 0, 1206379
Total [candidate] (9.136 s) : 0, 9135875
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.225 s) : 0, 1225321
Total [baseline] (9.138 s) : 0, 9138239
Agent [candidate] (1.22 s) : 0, 1219655
Total [candidate] (9.135 s) : 0, 9135264
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1202657
Total [baseline] (9.162 s) : 0, 9161974
Agent [candidate] (1.214 s) : 0, 1214263
Total [candidate] (9.179 s) : 0, 9178744
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.194 ms) : 0, 701194
BytebuddyAgent [candidate] (689.34 ms) : 0, 689340
GlobalTracer [baseline] (322.052 ms) : 0, 322052
GlobalTracer [candidate] (316.488 ms) : 0, 316488
AppSec [baseline] (54.97 ms) : 0, 54970
AppSec [candidate] (53.995 ms) : 0, 53995
Remote Config [baseline] (688.442 µs) : 0, 688
Remote Config [candidate] (660.652 µs) : 0, 661
Telemetry [baseline] (8.592 ms) : 0, 8592
Telemetry [candidate] (9.816 ms) : 0, 9816
section iast
BytebuddyAgent [baseline] (804.709 ms) : 0, 804709
BytebuddyAgent [candidate] (802.194 ms) : 0, 802194
GlobalTracer [baseline] (305.908 ms) : 0, 305908
GlobalTracer [candidate] (304.531 ms) : 0, 304531
AppSec [baseline] (57.24 ms) : 0, 57240
AppSec [candidate] (56.276 ms) : 0, 56276
IAST [baseline] (19.819 ms) : 0, 19819
IAST [candidate] (21.52 ms) : 0, 21520
Remote Config [baseline] (587.91 µs) : 0, 588
Remote Config [candidate] (598.212 µs) : 0, 598
Telemetry [baseline] (7.273 ms) : 0, 7273
Telemetry [candidate] (7.427 ms) : 0, 7427
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (815.623 ms) : 0, 815623
BytebuddyAgent [candidate] (811.927 ms) : 0, 811927
GlobalTracer [baseline] (309.195 ms) : 0, 309195
GlobalTracer [candidate] (307.804 ms) : 0, 307804
AppSec [baseline] (57.766 ms) : 0, 57766
AppSec [candidate] (57.899 ms) : 0, 57899
IAST [baseline] (20.617 ms) : 0, 20617
IAST [candidate] (19.96 ms) : 0, 19960
Remote Config [baseline] (598.633 µs) : 0, 599
Remote Config [candidate] (607.553 µs) : 0, 608
Telemetry [baseline] (7.506 ms) : 0, 7506
Telemetry [candidate] (7.494 ms) : 0, 7494
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.477 ms) : 0, 798477
BytebuddyAgent [candidate] (807.139 ms) : 0, 807139
GlobalTracer [baseline] (304.302 ms) : 0, 304302
GlobalTracer [candidate] (306.804 ms) : 0, 306804
AppSec [baseline] (53.987 ms) : 0, 53987
AppSec [candidate] (58.58 ms) : 0, 58580
IAST [baseline] (24.054 ms) : 0, 24054
IAST [candidate] (19.811 ms) : 0, 19811
Remote Config [baseline] (606.477 µs) : 0, 606
Remote Config [candidate] (600.988 µs) : 0, 601
Telemetry [baseline] (7.438 ms) : 0, 7438
Telemetry [candidate] (7.401 ms) : 0, 7401
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080598
Total [baseline] (10.399 s) : 0, 10398951
Agent [candidate] (1.089 s) : 0, 1089154
Total [candidate] (10.529 s) : 0, 10528808
section appsec
Agent [baseline] (1.22 s) : 0, 1219599
Total [baseline] (10.671 s) : 0, 10671154
Agent [candidate] (1.215 s) : 0, 1215484
Total [candidate] (10.663 s) : 0, 10663113
section iast
Agent [baseline] (1.206 s) : 0, 1205779
Total [baseline] (10.937 s) : 0, 10937013
Agent [candidate] (1.218 s) : 0, 1217530
Total [candidate] (10.935 s) : 0, 10935475
section profiling
Agent [baseline] (1.289 s) : 0, 1288672
Total [baseline] (10.784 s) : 0, 10784136
Agent [candidate] (1.29 s) : 0, 1289549
Total [candidate] (10.83 s) : 0, 10829633
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.921 ms) : 0, 686921
BytebuddyAgent [candidate] (692.001 ms) : 0, 692001
GlobalTracer [baseline] (315.518 ms) : 0, 315518
GlobalTracer [candidate] (317.48 ms) : 0, 317480
AppSec [baseline] (53.95 ms) : 0, 53950
AppSec [candidate] (54.576 ms) : 0, 54576
Remote Config [baseline] (662.181 µs) : 0, 662
Remote Config [candidate] (671.688 µs) : 0, 672
Telemetry [baseline] (9.762 ms) : 0, 9762
Telemetry [candidate] (10.57 ms) : 0, 10570
section appsec
BytebuddyAgent [baseline] (706.797 ms) : 0, 706797
BytebuddyAgent [candidate] (703.853 ms) : 0, 703853
GlobalTracer [baseline] (314.518 ms) : 0, 314518
GlobalTracer [candidate] (313.108 ms) : 0, 313108
AppSec [baseline] (166.061 ms) : 0, 166061
AppSec [candidate] (166.021 ms) : 0, 166021
IAST [baseline] (19.359 ms) : 0, 19359
IAST [candidate] (20.102 ms) : 0, 20102
Remote Config [baseline] (641.238 µs) : 0, 641
Remote Config [candidate] (638.611 µs) : 0, 639
Telemetry [baseline] (8.087 ms) : 0, 8087
Telemetry [candidate] (8.062 ms) : 0, 8062
section iast
BytebuddyAgent [baseline] (801.775 ms) : 0, 801775
BytebuddyAgent [candidate] (809.64 ms) : 0, 809640
GlobalTracer [baseline] (305.19 ms) : 0, 305190
GlobalTracer [candidate] (307.628 ms) : 0, 307628
AppSec [baseline] (57.205 ms) : 0, 57205
AppSec [candidate] (57.906 ms) : 0, 57906
IAST [baseline] (19.912 ms) : 0, 19912
IAST [candidate] (20.395 ms) : 0, 20395
Remote Config [baseline] (604.443 µs) : 0, 604
Remote Config [candidate] (610.443 µs) : 0, 610
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (7.458 ms) : 0, 7458
section profiling
BytebuddyAgent [baseline] (686.279 ms) : 0, 686279
BytebuddyAgent [candidate] (686.875 ms) : 0, 686875
GlobalTracer [baseline] (402.564 ms) : 0, 402564
GlobalTracer [candidate] (402.167 ms) : 0, 402167
AppSec [baseline] (54.894 ms) : 0, 54894
AppSec [candidate] (54.973 ms) : 0, 54973
Remote Config [baseline] (678.123 µs) : 0, 678
Remote Config [candidate] (680.685 µs) : 0, 681
Telemetry [baseline] (12.103 ms) : 0, 12103
Telemetry [candidate] (11.984 ms) : 0, 11984
ProfilingAgent [baseline] (92.947 ms) : 0, 92947
ProfilingAgent [candidate] (93.549 ms) : 0, 93549
Profiling [baseline] (92.972 ms) : 0, 92972
Profiling [candidate] (93.572 ms) : 0, 93572
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section baseline
no_agent (373.008 µs) : 354, 392
. : milestone, 373,
iast (485.009 µs) : 464, 506
. : milestone, 485,
iast_FULL (644.764 µs) : 624, 666
. : milestone, 645,
iast_GLOBAL (507.36 µs) : 486, 528
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (487.388 µs) : 466, 509
. : milestone, 487,
iast_INACTIVE (445.574 µs) : 425, 466
. : milestone, 446,
iast_TELEMETRY_OFF (474.977 µs) : 454, 496
. : milestone, 475,
tracing (449.105 µs) : 428, 470
. : milestone, 449,
section candidate
no_agent (372.15 µs) : 353, 391
. : milestone, 372,
iast (485.558 µs) : 464, 507
. : milestone, 486,
iast_FULL (641.304 µs) : 620, 663
. : milestone, 641,
iast_GLOBAL (524.244 µs) : 502, 546
. : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (492.744 µs) : 471, 515
. : milestone, 493,
iast_INACTIVE (447.306 µs) : 426, 468
. : milestone, 447,
iast_TELEMETRY_OFF (475.57 µs) : 454, 497
. : milestone, 476,
tracing (442.248 µs) : 422, 462
. : milestone, 442,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1363
. : milestone, 1343,
appsec (1.702 ms) : 1679, 1724
. : milestone, 1702,
appsec_no_iast (1.741 ms) : 1717, 1764
. : milestone, 1741,
iast (1.484 ms) : 1462, 1506
. : milestone, 1484,
profiling (1.477 ms) : 1454, 1500
. : milestone, 1477,
tracing (1.491 ms) : 1467, 1515
. : milestone, 1491,
section candidate
no_agent (1.343 ms) : 1323, 1363
. : milestone, 1343,
appsec (1.715 ms) : 1692, 1739
. : milestone, 1715,
appsec_no_iast (1.743 ms) : 1719, 1766
. : milestone, 1743,
iast (1.465 ms) : 1443, 1488
. : milestone, 1465,
profiling (1.473 ms) : 1450, 1495
. : milestone, 1473,
tracing (1.472 ms) : 1448, 1497
. : milestone, 1472,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section baseline
no_agent (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
appsec (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
iast (18.832 s) : 18832000, 18832000
. : milestone, 18832000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
. : milestone, 18068000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
section candidate
no_agent (15.794 s) : 15794000, 15794000
. : milestone, 15794000,
appsec (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
iast (18.657 s) : 18657000, 18657000
. : milestone, 18657000,
iast_GLOBAL (18.121 s) : 18121000, 18121000
. : milestone, 18121000,
profiling (15.076 s) : 15076000, 15076000
. : milestone, 15076000,
tracing (15.407 s) : 15407000, 15407000
. : milestone, 15407000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~65c048f8b0, baseline=1.42.0-SNAPSHOT~03ad4845ab
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1480
. : milestone, 1468,
appsec (2.338 ms) : 2297, 2380
. : milestone, 2338,
iast (2.083 ms) : 2030, 2135
. : milestone, 2083,
iast_GLOBAL (2.129 ms) : 2075, 2182
. : milestone, 2129,
profiling (1.928 ms) : 1887, 1969
. : milestone, 1928,
tracing (1.925 ms) : 1884, 1965
. : milestone, 1925,
section candidate
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.349 ms) : 2307, 2390
. : milestone, 2349,
iast (2.078 ms) : 2026, 2131
. : milestone, 2078,
iast_GLOBAL (2.116 ms) : 2064, 2169
. : milestone, 2116,
profiling (1.946 ms) : 1904, 1989
. : milestone, 1946,
tracing (1.906 ms) : 1866, 1945
. : milestone, 1906,
|
What Does This Do
Removes Hadoop from the requirements.json SSI denylist
Motivation
DJM relies on the Hadoop instrumentation to integrate with Spark jobs. We didn't originally consider DJM to be in scope for SSI, hence the original addition. However as some customers are already using DJM with SSI we are removing it from the list.
Additional Notes
DJM will add additional integration tests for the integration and SSI at a later date
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMLP-175