Fix telemetry logs default flag #7833

smola · 2024-10-24T06:42:48Z

What Does This Do

Set DEFAULT_TELEMETRY_LOG_COLLECTION_ENABLED to true.
This was supposed to be done in v1.40.0, per Enable telemetry logs by default #7631, but the default value was not correctly set. This effectively enabled the telemetry logger by default, but not sending the logs to the backend.
This is a telemetry logs regression in v1.40.0 for services that had it enabled by default until then (those using IAST, CI Visibility, Dynamic Instrumentation, or Java 8).

Motivation

Additional Notes

This is now tested on system-tests, but requires Rely on telemetry default config system-tests#3301 which will be effective only after merging this PR.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
~~[ ] Update the public documentation in case of new configuration flag or behavior~~

pr-commenter · 2024-10-24T07:26:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/fix-telemetry-logs-default
git_commit_date	1729717305	1729751989
git_commit_sha	`0cf47ed`	`2889014`
release_version	1.42.0-SNAPSHOT~0cf47ed20e	1.42.0-SNAPSHOT~288901461f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1729754509	1729754509
ci_job_id	682445062	682445062
ci_pipeline_id	47305075	47305075
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast:Telemetry	worse [+190.234µs; +435.472µs] or [+2.697%; +6.173%]	7.367ms	7.055ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry	worse [+379.450µs; +595.940µs] or [+5.451%; +8.562%]	7.448ms	6.961ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry	worse [+221.957µs; +610.140µs] or [+3.206%; +8.813%]	7.339ms	6.923ms
scenario:startup:petclinic:iast:Telemetry	worse [+237.241µs; +498.500µs] or [+3.365%; +7.071%]	7.418ms	7.050ms

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077661
Total [baseline] (8.566 s) : 0, 8565598
Agent [candidate] (1.081 s) : 0, 1081214
Total [candidate] (8.556 s) : 0, 8556137
section iast
Agent [baseline] (1.199 s) : 0, 1199485
Total [baseline] (9.12 s) : 0, 9119657
Agent [candidate] (1.203 s) : 0, 1203110
Total [candidate] (9.093 s) : 0, 9093466
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1199177
Total [baseline] (9.076 s) : 0, 9076262
Agent [candidate] (1.202 s) : 0, 1201627
Total [candidate] (9.074 s) : 0, 9074329
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1195268
Total [baseline] (9.073 s) : 0, 9072613
Agent [candidate] (1.206 s) : 0, 1206286
Total [candidate] (9.136 s) : 0, 9136226

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.078 s	-
Agent	iast	1.199 s	121.824 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.199 s	121.516 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.195 s	117.607 ms (10.9%)
Total	tracing	8.566 s	-
Total	iast	9.12 s	554.059 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.076 s	510.665 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.073 s	507.015 ms (5.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.203 s	121.897 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.202 s	120.414 ms (11.1%)
Agent	iast_TELEMETRY_OFF	1.206 s	125.072 ms (11.6%)
Total	tracing	8.556 s	-
Total	iast	9.093 s	537.329 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.074 s	518.192 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.136 s	580.089 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.37 ms) : 0, 687370
BytebuddyAgent [candidate] (689.994 ms) : 0, 689994
GlobalTracer [baseline] (313.171 ms) : 0, 313171
GlobalTracer [candidate] (312.365 ms) : 0, 312365
AppSec [baseline] (53.983 ms) : 0, 53983
AppSec [candidate] (53.797 ms) : 0, 53797
Remote Config [baseline] (657.252 µs) : 0, 657
Remote Config [candidate] (653.309 µs) : 0, 653
Telemetry [baseline] (8.796 ms) : 0, 8796
Telemetry [candidate] (10.706 ms) : 0, 10706
section iast
BytebuddyAgent [baseline] (800.487 ms) : 0, 800487
BytebuddyAgent [candidate] (802.698 ms) : 0, 802698
GlobalTracer [baseline] (300.565 ms) : 0, 300565
GlobalTracer [candidate] (301.658 ms) : 0, 301658
AppSec [baseline] (57.084 ms) : 0, 57084
AppSec [candidate] (56.136 ms) : 0, 56136
IAST [baseline] (20.103 ms) : 0, 20103
IAST [candidate] (20.989 ms) : 0, 20989
Remote Config [baseline] (584.056 µs) : 0, 584
Remote Config [candidate] (587.585 µs) : 0, 588
Telemetry [baseline] (7.055 ms) : 0, 7055
Telemetry [candidate] (7.367 ms) : 0, 7367
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.826 ms) : 0, 799826
BytebuddyAgent [candidate] (801.042 ms) : 0, 801042
GlobalTracer [baseline] (300.808 ms) : 0, 300808
GlobalTracer [candidate] (301.355 ms) : 0, 301355
AppSec [baseline] (57.171 ms) : 0, 57171
AppSec [candidate] (56.546 ms) : 0, 56546
IAST [baseline] (20.248 ms) : 0, 20248
IAST [candidate] (21.053 ms) : 0, 21053
Remote Config [baseline] (587.957 µs) : 0, 588
Remote Config [candidate] (587.98 µs) : 0, 588
Telemetry [baseline] (6.961 ms) : 0, 6961
Telemetry [candidate] (7.448 ms) : 0, 7448
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.498 ms) : 0, 796498
BytebuddyAgent [candidate] (804.084 ms) : 0, 804084
GlobalTracer [baseline] (300.395 ms) : 0, 300395
GlobalTracer [candidate] (302.727 ms) : 0, 302727
AppSec [baseline] (56.874 ms) : 0, 56874
AppSec [candidate] (57.812 ms) : 0, 57812
IAST [baseline] (20.424 ms) : 0, 20424
IAST [candidate] (20.033 ms) : 0, 20033
Remote Config [baseline] (577.146 µs) : 0, 577
Remote Config [candidate] (597.674 µs) : 0, 598
Telemetry [baseline] (6.923 ms) : 0, 6923
Telemetry [candidate] (7.339 ms) : 0, 7339

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073267
Total [baseline] (10.394 s) : 0, 10394158
Agent [candidate] (1.078 s) : 0, 1077574
Total [candidate] (10.305 s) : 0, 10305070
section appsec
Agent [baseline] (1.21 s) : 0, 1209864
Total [baseline] (10.599 s) : 0, 10598734
Agent [candidate] (1.211 s) : 0, 1210555
Total [candidate] (10.571 s) : 0, 10571129
section iast
Agent [baseline] (1.199 s) : 0, 1199043
Total [baseline] (10.831 s) : 0, 10831276
Agent [candidate] (1.22 s) : 0, 1219857
Total [candidate] (10.836 s) : 0, 10836150
section profiling
Agent [baseline] (1.277 s) : 0, 1277460
Total [baseline] (10.701 s) : 0, 10701040
Agent [candidate] (1.287 s) : 0, 1286908
Total [candidate] (10.742 s) : 0, 10742133

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.073 s	-
Agent	appsec	1.21 s	136.598 ms (12.7%)
Agent	iast	1.199 s	125.776 ms (11.7%)
Agent	profiling	1.277 s	204.194 ms (19.0%)
Total	tracing	10.394 s	-
Total	appsec	10.599 s	204.577 ms (2.0%)
Total	iast	10.831 s	437.119 ms (4.2%)
Total	profiling	10.701 s	306.882 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.078 s	-
Agent	appsec	1.211 s	132.981 ms (12.3%)
Agent	iast	1.22 s	142.283 ms (13.2%)
Agent	profiling	1.287 s	209.334 ms (19.4%)
Total	tracing	10.305 s	-
Total	appsec	10.571 s	266.059 ms (2.6%)
Total	iast	10.836 s	531.08 ms (5.2%)
Total	profiling	10.742 s	437.062 ms (4.2%)

gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.726 ms) : 0, 684726
BytebuddyAgent [candidate] (687.415 ms) : 0, 687415
GlobalTracer [baseline] (311.854 ms) : 0, 311854
GlobalTracer [candidate] (312.565 ms) : 0, 312565
AppSec [baseline] (53.603 ms) : 0, 53603
AppSec [candidate] (54.032 ms) : 0, 54032
Remote Config [baseline] (652.685 µs) : 0, 653
Remote Config [candidate] (659.245 µs) : 0, 659
Telemetry [baseline] (8.848 ms) : 0, 8848
Telemetry [candidate] (9.222 ms) : 0, 9222
section appsec
BytebuddyAgent [baseline] (702.779 ms) : 0, 702779
BytebuddyAgent [candidate] (703.206 ms) : 0, 703206
GlobalTracer [baseline] (309.449 ms) : 0, 309449
GlobalTracer [candidate] (309.406 ms) : 0, 309406
AppSec [baseline] (165.485 ms) : 0, 165485
AppSec [candidate] (166.205 ms) : 0, 166205
IAST [baseline] (20.936 ms) : 0, 20936
IAST [candidate] (19.132 ms) : 0, 19132
Remote Config [baseline] (643.624 µs) : 0, 644
Remote Config [candidate] (627.244 µs) : 0, 627
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (7.948 ms) : 0, 7948
section iast
BytebuddyAgent [baseline] (799.813 ms) : 0, 799813
BytebuddyAgent [candidate] (815.089 ms) : 0, 815089
GlobalTracer [baseline] (300.629 ms) : 0, 300629
GlobalTracer [candidate] (305.125 ms) : 0, 305125
AppSec [baseline] (57.131 ms) : 0, 57131
AppSec [candidate] (57.253 ms) : 0, 57253
IAST [baseline] (20.23 ms) : 0, 20230
IAST [candidate] (20.512 ms) : 0, 20512
Remote Config [baseline] (603.392 µs) : 0, 603
Remote Config [candidate] (597.039 µs) : 0, 597
Telemetry [baseline] (7.05 ms) : 0, 7050
Telemetry [candidate] (7.418 ms) : 0, 7418
section profiling
BytebuddyAgent [baseline] (685.019 ms) : 0, 685019
BytebuddyAgent [candidate] (688.734 ms) : 0, 688734
GlobalTracer [baseline] (395.13 ms) : 0, 395130
GlobalTracer [candidate] (399.106 ms) : 0, 399106
AppSec [baseline] (54.284 ms) : 0, 54284
AppSec [candidate] (55.044 ms) : 0, 55044
Remote Config [baseline] (646.583 µs) : 0, 647
Remote Config [candidate] (674.779 µs) : 0, 675
Telemetry [baseline] (12.304 ms) : 0, 12304
Telemetry [candidate] (14.719 ms) : 0, 14719
ProfilingAgent [baseline] (91.187 ms) : 0, 91187
ProfilingAgent [candidate] (89.477 ms) : 0, 89477
Profiling [baseline] (91.211 ms) : 0, 91211
Profiling [candidate] (89.5 ms) : 0, 89500

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-10-24T06:52:23	2024-10-24T06:59:20
git_branch	master	smola/fix-telemetry-logs-default
git_commit_date	1729717305	1729751989
git_commit_sha	`0cf47ed`	`2889014`
release_version	1.42.0-SNAPSHOT~0cf47ed20e	1.42.0-SNAPSHOT~288901461f
start_time	2024-10-24T06:52:09	2024-10-24T06:59:06

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1729753508	1729753508
ci_job_id	682445063	682445063
ci_pipeline_id	47305075	47305075
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.816 µs) : 359, 398
.   : milestone, 379,
iast (494.659 µs) : 473, 516
.   : milestone, 495,
iast_FULL (566.401 µs) : 545, 588
.   : milestone, 566,
iast_GLOBAL (519.859 µs) : 499, 541
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (488.776 µs) : 468, 510
.   : milestone, 489,
iast_INACTIVE (454.751 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (493.121 µs) : 471, 515
.   : milestone, 493,
tracing (450.342 µs) : 430, 471
.   : milestone, 450,
section candidate
no_agent (379.208 µs) : 358, 400
.   : milestone, 379,
iast (498.821 µs) : 477, 520
.   : milestone, 499,
iast_FULL (568.251 µs) : 547, 589
.   : milestone, 568,
iast_GLOBAL (531.51 µs) : 509, 554
.   : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (489.12 µs) : 468, 510
.   : milestone, 489,
iast_INACTIVE (451.302 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (487.503 µs) : 465, 510
.   : milestone, 488,
tracing (456.233 µs) : 435, 477
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.816 µs [359.399 µs, 398.233 µs]	-
iast	494.659 µs [473.443 µs, 515.875 µs]	115.843 µs (30.6%)
iast_FULL	566.401 µs [545.201 µs, 587.601 µs]	187.585 µs (49.5%)
iast_GLOBAL	519.859 µs [498.514 µs, 541.203 µs]	141.042 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	488.776 µs [467.61 µs, 509.942 µs]	109.96 µs (29.0%)
iast_INACTIVE	454.751 µs [433.937 µs, 475.564 µs]	75.934 µs (20.0%)
iast_TELEMETRY_OFF	493.121 µs [471.093 µs, 515.148 µs]	114.304 µs (30.2%)
tracing	450.342 µs [429.619 µs, 471.065 µs]	71.525 µs (18.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.208 µs [358.378 µs, 400.038 µs]	-
iast	498.821 µs [477.398 µs, 520.244 µs]	119.614 µs (31.5%)
iast_FULL	568.251 µs [547.018 µs, 589.484 µs]	189.044 µs (49.9%)
iast_GLOBAL	531.51 µs [509.42 µs, 553.6 µs]	152.302 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED	489.12 µs [468.27 µs, 509.97 µs]	109.912 µs (29.0%)
iast_INACTIVE	451.302 µs [430.949 µs, 471.655 µs]	72.094 µs (19.0%)
iast_TELEMETRY_OFF	487.503 µs [465.471 µs, 509.536 µs]	108.296 µs (28.6%)
tracing	456.233 µs [435.484 µs, 476.981 µs]	77.025 µs (20.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1364
.   : milestone, 1344,
appsec (1.751 ms) : 1726, 1776
.   : milestone, 1751,
appsec_no_iast (1.742 ms) : 1718, 1767
.   : milestone, 1742,
iast (1.509 ms) : 1485, 1532
.   : milestone, 1509,
profiling (1.531 ms) : 1507, 1555
.   : milestone, 1531,
tracing (1.48 ms) : 1454, 1506
.   : milestone, 1480,
section candidate
no_agent (1.333 ms) : 1314, 1353
.   : milestone, 1333,
appsec (1.735 ms) : 1713, 1758
.   : milestone, 1735,
appsec_no_iast (1.728 ms) : 1703, 1753
.   : milestone, 1728,
iast (1.473 ms) : 1450, 1496
.   : milestone, 1473,
profiling (1.487 ms) : 1464, 1510
.   : milestone, 1487,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.344 ms [1.324 ms, 1.364 ms]	-
appsec	1.751 ms [1.726 ms, 1.776 ms]	407.06 µs (30.3%)
appsec_no_iast	1.742 ms [1.718 ms, 1.767 ms]	398.382 µs (29.6%)
iast	1.509 ms [1.485 ms, 1.532 ms]	164.883 µs (12.3%)
profiling	1.531 ms [1.507 ms, 1.555 ms]	187.577 µs (14.0%)
tracing	1.48 ms [1.454 ms, 1.506 ms]	136.253 µs (10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.333 ms [1.314 ms, 1.353 ms]	-
appsec	1.735 ms [1.713 ms, 1.758 ms]	402.13 µs (30.2%)
appsec_no_iast	1.728 ms [1.703 ms, 1.753 ms]	394.717 µs (29.6%)
iast	1.473 ms [1.45 ms, 1.496 ms]	139.657 µs (10.5%)
profiling	1.487 ms [1.464 ms, 1.51 ms]	153.581 µs (11.5%)
tracing	1.471 ms [1.447 ms, 1.495 ms]	137.686 µs (10.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	smola/fix-telemetry-logs-default
git_commit_date	1729717305	1729751989
git_commit_sha	`0cf47ed`	`2889014`
release_version	1.42.0-SNAPSHOT~0cf47ed20e	1.42.0-SNAPSHOT~288901461f

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1729754027	1729754027
ci_job_id	682445064	682445064
ci_pipeline_id	47305075	47305075
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1484
.   : milestone, 1472,
appsec (2.329 ms) : 2287, 2370
.   : milestone, 2329,
iast (2.075 ms) : 2023, 2128
.   : milestone, 2075,
iast_GLOBAL (2.121 ms) : 2068, 2173
.   : milestone, 2121,
profiling (1.941 ms) : 1899, 1984
.   : milestone, 1941,
tracing (1.909 ms) : 1869, 1949
.   : milestone, 1909,
section candidate
no_agent (1.465 ms) : 1452, 1477
.   : milestone, 1465,
appsec (2.316 ms) : 2274, 2357
.   : milestone, 2316,
iast (2.077 ms) : 2024, 2129
.   : milestone, 2077,
iast_GLOBAL (2.104 ms) : 2052, 2157
.   : milestone, 2104,
profiling (1.926 ms) : 1884, 1969
.   : milestone, 1926,
tracing (1.915 ms) : 1875, 1956
.   : milestone, 1915,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.484 ms]	-
appsec	2.329 ms [2.287 ms, 2.37 ms]	856.904 µs (58.2%)
iast	2.075 ms [2.023 ms, 2.128 ms]	603.378 µs (41.0%)
iast_GLOBAL	2.121 ms [2.068 ms, 2.173 ms]	648.886 µs (44.1%)
profiling	1.941 ms [1.899 ms, 1.984 ms]	469.354 µs (31.9%)
tracing	1.909 ms [1.869 ms, 1.949 ms]	437.141 µs (29.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.452 ms, 1.477 ms]	-
appsec	2.316 ms [2.274 ms, 2.357 ms]	850.835 µs (58.1%)
iast	2.077 ms [2.024 ms, 2.129 ms]	612.192 µs (41.8%)
iast_GLOBAL	2.104 ms [2.052 ms, 2.157 ms]	639.618 µs (43.7%)
profiling	1.926 ms [1.884 ms, 1.969 ms]	461.749 µs (31.5%)
tracing	1.915 ms [1.875 ms, 1.956 ms]	450.561 µs (30.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~288901461f, baseline=1.42.0-SNAPSHOT~0cf47ed20e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
appsec (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
iast (18.634 s) : 18634000, 18634000
.   : milestone, 18634000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
.   : milestone, 17972000,
profiling (15.55 s) : 15550000, 15550000
.   : milestone, 15550000,
tracing (14.864 s) : 14864000, 14864000
.   : milestone, 14864000,
section candidate
no_agent (14.989 s) : 14989000, 14989000
.   : milestone, 14989000,
appsec (15.263 s) : 15263000, 15263000
.   : milestone, 15263000,
iast (18.801 s) : 18801000, 18801000
.   : milestone, 18801000,
iast_GLOBAL (18.145 s) : 18145000, 18145000
.   : milestone, 18145000,
profiling (15.006 s) : 15006000, 15006000
.   : milestone, 15006000,
tracing (15.241 s) : 15241000, 15241000
.   : milestone, 15241000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.022 s [15.022 s, 15.022 s]	-
appsec	14.948 s [14.948 s, 14.948 s]	-74.0 ms (-0.5%)
iast	18.634 s [18.634 s, 18.634 s]	3.612 s (24.0%)
iast_GLOBAL	17.972 s [17.972 s, 17.972 s]	2.95 s (19.6%)
profiling	15.55 s [15.55 s, 15.55 s]	528.0 ms (3.5%)
tracing	14.864 s [14.864 s, 14.864 s]	-158.0 ms (-1.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.989 s [14.989 s, 14.989 s]	-
appsec	15.263 s [15.263 s, 15.263 s]	274.0 ms (1.8%)
iast	18.801 s [18.801 s, 18.801 s]	3.812 s (25.4%)
iast_GLOBAL	18.145 s [18.145 s, 18.145 s]	3.156 s (21.1%)
profiling	15.006 s [15.006 s, 15.006 s]	17.0 ms (0.1%)
tracing	15.241 s [15.241 s, 15.241 s]	252.0 ms (1.7%)

Fix telemetry logs default flag

2889014

smola added type: bug comp: telemetry Telemetry labels Oct 24, 2024

smola marked this pull request as ready for review October 24, 2024 07:46

smola requested a review from a team as a code owner October 24, 2024 07:46

smola requested a review from ygree October 24, 2024 07:46

smola mentioned this pull request Oct 24, 2024

Rely on telemetry default config DataDog/system-tests#3301

Merged

7 tasks

Mariovido approved these changes Oct 24, 2024

View reviewed changes

smola merged commit 6c04a2f into master Oct 24, 2024
106 checks passed

smola deleted the smola/fix-telemetry-logs-default branch October 24, 2024 13:35

github-actions bot added this to the 1.42.0 milestone Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix telemetry logs default flag #7833

Fix telemetry logs default flag #7833

smola commented Oct 24, 2024 •

edited

Loading

pr-commenter bot commented Oct 24, 2024

Fix telemetry logs default flag #7833

Fix telemetry logs default flag #7833

Conversation

smola commented Oct 24, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Oct 24, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

smola commented Oct 24, 2024 •

edited

Loading