Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable telemetry logs by default #7631

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Enable telemetry logs by default #7631

merged 1 commit into from
Sep 23, 2024

Conversation

smola
Copy link
Member

@smola smola commented Sep 17, 2024 •
edited
Loading

What Does This Do

Enable telemetry logs by default. These were already enabled by default for services using JDK 8, Code Security (IAST), Dynamic Instrumentation, or CI Visibility. They will be enabled for all services from now on.

Users who want to opt out can set -Ddd.telemetry.log-collection.enabled=false (system property) or DD_TELEMETRY_LOG_COLLECTION_ENABLED=false (environment variable).

Note that these are not application logs, but internal dd-trace-java logs which we use for troubleshooting. They are heavily redacted by sending only the log formats and not log parameters (e.g. when we do log.error("An error happened at url: {}", url)), we will send just "An error happened at url: {}", without any placeholder substitution. We also send error stacktraces, including exception type (but not exception message), and any stackframes from dd-trace-java itself or the standard library.

Motivation

We use these logs to proactively detect and fix dd-trace-java bugs.

Additional Notes

Previous activation milestones:

Jira: APPSEC-53432

Contributor Checklist

@smola smola force-pushed the smola/enable-telemetry-logs-globally branch from c40213a to b645139 Compare September 17, 2024 15:14
@smola smola marked this pull request as ready for review September 17, 2024 15:31
@smola smola requested a review from a team as a code owner September 17, 2024 15:31
@smola smola requested a review from ygree September 17, 2024 15:31
@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/enable-telemetry-logs-globally
git_commit_date 1726577115 1726586026
git_commit_sha 2d2c029 b645139
release_version 1.40.0-SNAPSHOT~2d2c02962a 1.40.0-SNAPSHOT~b645139a6d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726588457 1726588457
ci_job_id 642317118 642317118
ci_pipeline_id 44512168 44512168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 15 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Telemetry better
[-540.012µs; -285.570µs] or [-7.237%; -3.827%]		 7.049ms 7.461ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062069
Total [baseline] (10.355 s) : 0, 10355354
Agent [candidate] (1.064 s) : 0, 1063891
Total [candidate] (10.415 s) : 0, 10414830
section appsec
Agent [baseline] (1.205 s) : 0, 1204575
Total [baseline] (10.614 s) : 0, 10613814
Agent [candidate] (1.199 s) : 0, 1198658
Total [candidate] (10.601 s) : 0, 10601394
section iast
Agent [baseline] (1.189 s) : 0, 1189304
Total [baseline] (10.82 s) : 0, 10819702
Agent [candidate] (1.195 s) : 0, 1194749
Total [candidate] (10.866 s) : 0, 10866309
section profiling
Agent [baseline] (1.262 s) : 0, 1262418
Total [baseline] (10.617 s) : 0, 10616972
Agent [candidate] (1.271 s) : 0, 1270964
Total [candidate] (10.548 s) : 0, 10547663
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.205 s 142.506 ms (13.4%)
Agent iast 1.189 s 127.235 ms (12.0%)
Agent profiling 1.262 s 200.349 ms (18.9%)
Total tracing 10.355 s -
Total appsec 10.614 s 258.46 ms (2.5%)
Total iast 10.82 s 464.348 ms (4.5%)
Total profiling 10.617 s 261.619 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.199 s 134.768 ms (12.7%)
Agent iast 1.195 s 130.859 ms (12.3%)
Agent profiling 1.271 s 207.073 ms (19.5%)
Total tracing 10.415 s -
Total appsec 10.601 s 186.564 ms (1.8%)
Total iast 10.866 s 451.479 ms (4.3%)
Total profiling 10.548 s 132.832 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.342 ms) : 0, 678342
BytebuddyAgent [candidate] (679.742 ms) : 0, 679742
GlobalTracer [baseline] (309.153 ms) : 0, 309153
GlobalTracer [candidate] (309.566 ms) : 0, 309566
AppSec [baseline] (52.633 ms) : 0, 52633
AppSec [candidate] (52.665 ms) : 0, 52665
Remote Config [baseline] (660.062 µs) : 0, 660
Remote Config [candidate] (661.241 µs) : 0, 661
Telemetry [baseline] (7.568 ms) : 0, 7568
Telemetry [candidate] (7.595 ms) : 0, 7595
section appsec
BytebuddyAgent [baseline] (705.618 ms) : 0, 705618
BytebuddyAgent [candidate] (702.078 ms) : 0, 702078
GlobalTracer [baseline] (303.816 ms) : 0, 303816
GlobalTracer [candidate] (303.486 ms) : 0, 303486
AppSec [baseline] (161.398 ms) : 0, 161398
AppSec [candidate] (161.098 ms) : 0, 161098
Remote Config [baseline] (625.061 µs) : 0, 625
Remote Config [candidate] (624.391 µs) : 0, 624
Telemetry [baseline] (9.021 ms) : 0, 9021
Telemetry [candidate] (8.133 ms) : 0, 8133
IAST [baseline] (20.688 ms) : 0, 20688
IAST [candidate] (19.078 ms) : 0, 19078
section iast
BytebuddyAgent [baseline] (791.95 ms) : 0, 791950
BytebuddyAgent [candidate] (796.067 ms) : 0, 796067
GlobalTracer [baseline] (298.541 ms) : 0, 298541
GlobalTracer [candidate] (299.624 ms) : 0, 299624
AppSec [baseline] (56.064 ms) : 0, 56064
AppSec [candidate] (54.412 ms) : 0, 54412
Remote Config [baseline] (619.358 µs) : 0, 619
Remote Config [candidate] (619.772 µs) : 0, 620
Telemetry [baseline] (7.396 ms) : 0, 7396
Telemetry [candidate] (7.173 ms) : 0, 7173
IAST [baseline] (21.016 ms) : 0, 21016
IAST [candidate] (23.047 ms) : 0, 23047
section profiling
ProfilingAgent [baseline] (96.489 ms) : 0, 96489
ProfilingAgent [candidate] (96.819 ms) : 0, 96819
BytebuddyAgent [baseline] (673.828 ms) : 0, 673828
BytebuddyAgent [candidate] (678.72 ms) : 0, 678720
GlobalTracer [baseline] (392.569 ms) : 0, 392569
GlobalTracer [candidate] (394.196 ms) : 0, 394196
AppSec [baseline] (53.172 ms) : 0, 53172
AppSec [candidate] (53.948 ms) : 0, 53948
Remote Config [baseline] (650.787 µs) : 0, 651
Remote Config [candidate] (655.621 µs) : 0, 656
Telemetry [baseline] (7.435 ms) : 0, 7435
Telemetry [candidate] (7.519 ms) : 0, 7519
Profiling [baseline] (96.513 ms) : 0, 96513
Profiling [candidate] (96.843 ms) : 0, 96843
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078106
Total [baseline] (8.557 s) : 0, 8556998
Agent [candidate] (1.077 s) : 0, 1076913
Total [candidate] (8.601 s) : 0, 8600669
section iast
Agent [baseline] (1.187 s) : 0, 1187347
Total [baseline] (8.986 s) : 0, 8985513
Agent [candidate] (1.196 s) : 0, 1195708
Total [candidate] (8.996 s) : 0, 8995764
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190698
Total [baseline] (9.009 s) : 0, 9009162
Agent [candidate] (1.19 s) : 0, 1190093
Total [candidate] (9.024 s) : 0, 9023793
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188096
Total [baseline] (8.981 s) : 0, 8980906
Agent [candidate] (1.205 s) : 0, 1204527
Total [candidate] (9.021 s) : 0, 9020993
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.187 s 109.241 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 112.591 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.188 s 109.99 ms (10.2%)
Total tracing 8.557 s -
Total iast 8.986 s 428.515 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.009 s 452.164 ms (5.3%)
Total iast_TELEMETRY_OFF 8.981 s 423.908 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.196 s 118.795 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 113.18 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.205 s 127.614 ms (11.8%)
Total tracing 8.601 s -
Total iast 8.996 s 395.095 ms (4.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.024 s 423.124 ms (4.9%)
Total iast_TELEMETRY_OFF 9.021 s 420.325 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.448 ms) : 0, 689448
BytebuddyAgent [candidate] (688.845 ms) : 0, 688845
GlobalTracer [baseline] (313.081 ms) : 0, 313081
GlobalTracer [candidate] (312.623 ms) : 0, 312623
AppSec [baseline] (53.305 ms) : 0, 53305
AppSec [candidate] (53.254 ms) : 0, 53254
Remote Config [baseline] (678.839 µs) : 0, 679
Remote Config [candidate] (658.952 µs) : 0, 659
Telemetry [baseline] (7.695 ms) : 0, 7695
Telemetry [candidate] (7.655 ms) : 0, 7655
section iast
BytebuddyAgent [baseline] (790.336 ms) : 0, 790336
BytebuddyAgent [candidate] (796.908 ms) : 0, 796908
GlobalTracer [baseline] (298.108 ms) : 0, 298108
GlobalTracer [candidate] (299.731 ms) : 0, 299731
AppSec [baseline] (54.88 ms) : 0, 54880
AppSec [candidate] (55.636 ms) : 0, 55636
IAST [baseline] (22.179 ms) : 0, 22179
IAST [candidate] (21.947 ms) : 0, 21947
Remote Config [baseline] (634.043 µs) : 0, 634
Remote Config [candidate] (600.16 µs) : 0, 600
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (7.049 ms) : 0, 7049
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.123 ms) : 0, 792123
BytebuddyAgent [candidate] (792.401 ms) : 0, 792401
GlobalTracer [baseline] (298.691 ms) : 0, 298691
GlobalTracer [candidate] (298.589 ms) : 0, 298589
AppSec [baseline] (53.429 ms) : 0, 53429
AppSec [candidate] (53.933 ms) : 0, 53933
IAST [baseline] (24.638 ms) : 0, 24638
IAST [candidate] (22.953 ms) : 0, 22953
Remote Config [baseline] (639.689 µs) : 0, 640
Remote Config [candidate] (626.61 µs) : 0, 627
Telemetry [baseline] (7.42 ms) : 0, 7420
Telemetry [candidate] (7.849 ms) : 0, 7849
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.427 ms) : 0, 789427
BytebuddyAgent [candidate] (801.603 ms) : 0, 801603
GlobalTracer [baseline] (299.35 ms) : 0, 299350
GlobalTracer [candidate] (303.145 ms) : 0, 303145
AppSec [baseline] (51.883 ms) : 0, 51883
AppSec [candidate] (55.43 ms) : 0, 55430
IAST [baseline] (25.005 ms) : 0, 25005
IAST [candidate] (22.682 ms) : 0, 22682
Remote Config [baseline] (588.231 µs) : 0, 588
Remote Config [candidate] (599.651 µs) : 0, 600
Telemetry [baseline] (8.081 ms) : 0, 8081
Telemetry [candidate] (7.103 ms) : 0, 7103
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-17T15:24:55 2024-09-17T15:31:39
git_branch master smola/enable-telemetry-logs-globally
git_commit_date 1726577115 1726586026
git_commit_sha 2d2c029 b645139
release_version 1.40.0-SNAPSHOT~2d2c02962a 1.40.0-SNAPSHOT~b645139a6d
start_time 2024-09-17T15:24:42 2024-09-17T15:31:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726587441 1726587441
ci_job_id 642317120 642317120
ci_pipeline_id 44512168 44512168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.319 ms) : 1300, 1338
.   : milestone, 1319,
appsec (1.702 ms) : 1678, 1727
.   : milestone, 1702,
appsec_no_iast (1.697 ms) : 1674, 1721
.   : milestone, 1697,
iast (1.456 ms) : 1433, 1478
.   : milestone, 1456,
profiling (1.461 ms) : 1438, 1483
.   : milestone, 1461,
tracing (1.456 ms) : 1431, 1481
.   : milestone, 1456,
section candidate
no_agent (1.316 ms) : 1296, 1336
.   : milestone, 1316,
appsec (1.723 ms) : 1700, 1746
.   : milestone, 1723,
appsec_no_iast (1.695 ms) : 1671, 1720
.   : milestone, 1695,
iast (1.462 ms) : 1439, 1485
.   : milestone, 1462,
profiling (1.462 ms) : 1439, 1485
.   : milestone, 1462,
tracing (1.451 ms) : 1428, 1475
.   : milestone, 1451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.319 ms [1.3 ms, 1.338 ms] -
appsec 1.702 ms [1.678 ms, 1.727 ms] 383.102 µs (29.0%)
appsec_no_iast 1.697 ms [1.674 ms, 1.721 ms] 378.185 µs (28.7%)
iast 1.456 ms [1.433 ms, 1.478 ms] 136.757 µs (10.4%)
profiling 1.461 ms [1.438 ms, 1.483 ms] 141.721 µs (10.7%)
tracing 1.456 ms [1.431 ms, 1.481 ms] 137.16 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.316 ms [1.296 ms, 1.336 ms] -
appsec 1.723 ms [1.7 ms, 1.746 ms] 407.343 µs (31.0%)
appsec_no_iast 1.695 ms [1.671 ms, 1.72 ms] 379.214 µs (28.8%)
iast 1.462 ms [1.439 ms, 1.485 ms] 146.305 µs (11.1%)
profiling 1.462 ms [1.439 ms, 1.485 ms] 145.872 µs (11.1%)
tracing 1.451 ms [1.428 ms, 1.475 ms] 135.435 µs (10.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a
    dateFormat X
    axisFormat %s
section baseline
no_agent (353.421 µs) : 333, 374
.   : milestone, 353,
iast (467.375 µs) : 446, 489
.   : milestone, 467,
iast_FULL (530.785 µs) : 510, 552
.   : milestone, 531,
iast_GLOBAL (484.934 µs) : 464, 506
.   : milestone, 485,
iast_HARDCODED_SECRET_DISABLED (461.781 µs) : 440, 483
.   : milestone, 462,
iast_INACTIVE (426.434 µs) : 405, 447
.   : milestone, 426,
iast_TELEMETRY_OFF (455.273 µs) : 433, 478
.   : milestone, 455,
tracing (426.435 µs) : 406, 447
.   : milestone, 426,
section candidate
no_agent (347.47 µs) : 326, 369
.   : milestone, 347,
iast (461.064 µs) : 440, 482
.   : milestone, 461,
iast_FULL (538.598 µs) : 517, 560
.   : milestone, 539,
iast_GLOBAL (493.832 µs) : 472, 516
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (468.095 µs) : 446, 490
.   : milestone, 468,
iast_INACTIVE (427.773 µs) : 407, 449
.   : milestone, 428,
iast_TELEMETRY_OFF (457.623 µs) : 435, 480
.   : milestone, 458,
tracing (421.911 µs) : 401, 443
.   : milestone, 422,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 353.421 µs [332.813 µs, 374.029 µs] -
iast 467.375 µs [445.84 µs, 488.91 µs] 113.954 µs (32.2%)
iast_FULL 530.785 µs [509.632 µs, 551.939 µs] 177.364 µs (50.2%)
iast_GLOBAL 484.934 µs [463.545 µs, 506.324 µs] 131.513 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 461.781 µs [440.365 µs, 483.198 µs] 108.36 µs (30.7%)
iast_INACTIVE 426.434 µs [405.434 µs, 447.433 µs] 73.013 µs (20.7%)
iast_TELEMETRY_OFF 455.273 µs [432.619 µs, 477.928 µs] 101.852 µs (28.8%)
tracing 426.435 µs [405.912 µs, 446.958 µs] 73.013 µs (20.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 347.47 µs [326.24 µs, 368.7 µs] -
iast 461.064 µs [440.024 µs, 482.104 µs] 113.594 µs (32.7%)
iast_FULL 538.598 µs [517.072 µs, 560.124 µs] 191.128 µs (55.0%)
iast_GLOBAL 493.832 µs [471.787 µs, 515.877 µs] 146.362 µs (42.1%)
iast_HARDCODED_SECRET_DISABLED 468.095 µs [445.708 µs, 490.482 µs] 120.625 µs (34.7%)
iast_INACTIVE 427.773 µs [406.727 µs, 448.82 µs] 80.303 µs (23.1%)
iast_TELEMETRY_OFF 457.623 µs [434.854 µs, 480.391 µs] 110.152 µs (31.7%)
tracing 421.911 µs [401.005 µs, 442.816 µs] 74.441 µs (21.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/enable-telemetry-logs-globally
git_commit_date 1726577115 1726586026
git_commit_sha 2d2c029 b645139
release_version 1.40.0-SNAPSHOT~2d2c02962a 1.40.0-SNAPSHOT~b645139a6d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726587964 1726587964
ci_job_id 642317122 642317122
ci_pipeline_id 44512168 44512168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.444 ms) : 1432, 1455
.   : milestone, 1444,
appsec (2.269 ms) : 2228, 2310
.   : milestone, 2269,
iast (2.03 ms) : 1979, 2081
.   : milestone, 2030,
iast_GLOBAL (2.071 ms) : 2020, 2122
.   : milestone, 2071,
profiling (1.895 ms) : 1855, 1935
.   : milestone, 1895,
tracing (1.88 ms) : 1842, 1919
.   : milestone, 1880,
section candidate
no_agent (1.442 ms) : 1430, 1453
.   : milestone, 1442,
appsec (2.259 ms) : 2218, 2300
.   : milestone, 2259,
iast (2.016 ms) : 1966, 2066
.   : milestone, 2016,
iast_GLOBAL (2.056 ms) : 2006, 2106
.   : milestone, 2056,
profiling (1.887 ms) : 1848, 1927
.   : milestone, 1887,
tracing (1.865 ms) : 1827, 1903
.   : milestone, 1865,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.444 ms [1.432 ms, 1.455 ms] -
appsec 2.269 ms [2.228 ms, 2.31 ms] 825.387 µs (57.2%)
iast 2.03 ms [1.979 ms, 2.081 ms] 586.384 µs (40.6%)
iast_GLOBAL 2.071 ms [2.02 ms, 2.122 ms] 627.416 µs (43.5%)
profiling 1.895 ms [1.855 ms, 1.935 ms] 450.875 µs (31.2%)
tracing 1.88 ms [1.842 ms, 1.919 ms] 436.385 µs (30.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.442 ms [1.43 ms, 1.453 ms] -
appsec 2.259 ms [2.218 ms, 2.3 ms] 817.043 µs (56.7%)
iast 2.016 ms [1.966 ms, 2.066 ms] 573.959 µs (39.8%)
iast_GLOBAL 2.056 ms [2.006 ms, 2.106 ms] 614.416 µs (42.6%)
profiling 1.887 ms [1.848 ms, 1.927 ms] 445.413 µs (30.9%)
tracing 1.865 ms [1.827 ms, 1.903 ms] 423.279 µs (29.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~b645139a6d, baseline=1.40.0-SNAPSHOT~2d2c02962a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
appsec (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
iast (18.638 s) : 18638000, 18638000
.   : milestone, 18638000,
iast_GLOBAL (18.157 s) : 18157000, 18157000
.   : milestone, 18157000,
profiling (15.604 s) : 15604000, 15604000
.   : milestone, 15604000,
tracing (15.07 s) : 15070000, 15070000
.   : milestone, 15070000,
section candidate
no_agent (15.698 s) : 15698000, 15698000
.   : milestone, 15698000,
appsec (15.079 s) : 15079000, 15079000
.   : milestone, 15079000,
iast (18.897 s) : 18897000, 18897000
.   : milestone, 18897000,
iast_GLOBAL (18.362 s) : 18362000, 18362000
.   : milestone, 18362000,
profiling (15.278 s) : 15278000, 15278000
.   : milestone, 15278000,
tracing (15.202 s) : 15202000, 15202000
.   : milestone, 15202000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.037 s [15.037 s, 15.037 s] -
appsec 15.082 s [15.082 s, 15.082 s] 45.0 ms (0.3%)
iast 18.638 s [18.638 s, 18.638 s] 3.601 s (23.9%)
iast_GLOBAL 18.157 s [18.157 s, 18.157 s] 3.12 s (20.7%)
profiling 15.604 s [15.604 s, 15.604 s] 567.0 ms (3.8%)
tracing 15.07 s [15.07 s, 15.07 s] 33.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.698 s [15.698 s, 15.698 s] -
appsec 15.079 s [15.079 s, 15.079 s] -619.0 ms (-3.9%)
iast 18.897 s [18.897 s, 18.897 s] 3.199 s (20.4%)
iast_GLOBAL 18.362 s [18.362 s, 18.362 s] 2.664 s (17.0%)
profiling 15.278 s [15.278 s, 15.278 s] -420.0 ms (-2.7%)
tracing 15.202 s [15.202 s, 15.202 s] -496.0 ms (-3.2%)

@smola smola merged commit c33c480 into master Sep 23, 2024
102 checks passed
@smola smola deleted the smola/enable-telemetry-logs-globally branch September 23, 2024 06:56
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 23, 2024
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@smola @jordan-wong
Enable telemetry logs by default (#7631)
cbce83f
@smola smola mentioned this pull request Oct 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @PerfectSlayer