Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒 7795] Fix default value for long-running spans with DJM #7810

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[🍒 7795] Fix default value for long-running spans with DJM #7810

merged 1 commit into from
Oct 18, 2024

Conversation

paul-laffon-dd
Copy link
Contributor

Cherry pick #7795

What Does This Do

Change the default config values for DJM before the first call to Config.get() that resolve the Config values.

Motivation

Long running spans not being enabled when using -Ddd.data.jobs.enabled=true since the config values were already resolved before the default values are changed

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@paul-laffon-dd paul-laffon-dd requested a review from a team as a code owner October 18, 2024 13:58
@nikita-tkachenko-datadog nikita-tkachenko-datadog added this to the 1.41.1 milestone Oct 18, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master paul.laffon/backport-pr-7795
git_commit_date 1729257196 1729259841
git_commit_sha 00856e0 8f37b2b
release_version 1.42.0-SNAPSHOT~00856e02d3 1.42.0-SNAPSHOT~8f37b2bdd9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729262060 1729262060
ci_job_id 676904983 676904983
ci_pipeline_id 46916248 46916248
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 50 metrics, 10 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent worse
[+5.713ms; +9.859ms] or [+6.357%; +10.969%]		 97.665ms 89.879ms
scenario:startup:petclinic:profiling:Telemetry better
[-7.195ms; -6.709ms] or [-49.764%; -46.404%]		 7.506ms 14.458ms
scenario:startup:petclinic:profiling:Profiling worse
[+5.714ms; +9.860ms] or [+6.356%; +10.967%]		 97.689ms 89.902ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087404
Total [baseline] (10.476 s) : 0, 10476202
Agent [candidate] (1.072 s) : 0, 1072200
Total [candidate] (10.443 s) : 0, 10442583
section appsec
Agent [baseline] (1.209 s) : 0, 1208733
Total [baseline] (10.628 s) : 0, 10627626
Agent [candidate] (1.209 s) : 0, 1208957
Total [candidate] (10.66 s) : 0, 10660292
section iast
Agent [baseline] (1.2 s) : 0, 1200437
Total [baseline] (10.883 s) : 0, 10883416
Agent [candidate] (1.203 s) : 0, 1202601
Total [candidate] (10.903 s) : 0, 10902738
section profiling
Agent [baseline] (1.28 s) : 0, 1280237
Total [baseline] (10.672 s) : 0, 10672002
Agent [candidate] (1.278 s) : 0, 1278243
Total [candidate] (10.682 s) : 0, 10681600
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent appsec 1.209 s 121.329 ms (11.2%)
Agent iast 1.2 s 113.033 ms (10.4%)
Agent profiling 1.28 s 192.833 ms (17.7%)
Total tracing 10.476 s -
Total appsec 10.628 s 151.425 ms (1.4%)
Total iast 10.883 s 407.215 ms (3.9%)
Total profiling 10.672 s 195.8 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.209 s 136.756 ms (12.8%)
Agent iast 1.203 s 130.401 ms (12.2%)
Agent profiling 1.278 s 206.042 ms (19.2%)
Total tracing 10.443 s -
Total appsec 10.66 s 217.709 ms (2.1%)
Total iast 10.903 s 460.155 ms (4.4%)
Total profiling 10.682 s 239.017 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.252 ms) : 0, 693252
BytebuddyAgent [candidate] (684.086 ms) : 0, 684086
GlobalTracer [baseline] (316.969 ms) : 0, 316969
GlobalTracer [candidate] (312.477 ms) : 0, 312477
AppSec [baseline] (54.435 ms) : 0, 54435
AppSec [candidate] (53.785 ms) : 0, 53785
Remote Config [baseline] (673.74 µs) : 0, 674
Remote Config [candidate] (658.776 µs) : 0, 659
Telemetry [baseline] (8.291 ms) : 0, 8291
Telemetry [candidate] (7.489 ms) : 0, 7489
section appsec
BytebuddyAgent [baseline] (701.94 ms) : 0, 701940
BytebuddyAgent [candidate] (702.394 ms) : 0, 702394
GlobalTracer [baseline] (309.496 ms) : 0, 309496
GlobalTracer [candidate] (309.966 ms) : 0, 309966
AppSec [baseline] (165.997 ms) : 0, 165997
AppSec [candidate] (163.877 ms) : 0, 163877
IAST [baseline] (19.293 ms) : 0, 19293
IAST [candidate] (19.778 ms) : 0, 19778
Remote Config [baseline] (629.808 µs) : 0, 630
Remote Config [candidate] (633.385 µs) : 0, 633
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (8.487 ms) : 0, 8487
section iast
BytebuddyAgent [baseline] (799.908 ms) : 0, 799908
BytebuddyAgent [candidate] (800.432 ms) : 0, 800432
GlobalTracer [baseline] (300.856 ms) : 0, 300856
GlobalTracer [candidate] (302.0 ms) : 0, 302000
AppSec [baseline] (57.848 ms) : 0, 57848
AppSec [candidate] (56.399 ms) : 0, 56399
IAST [baseline] (20.499 ms) : 0, 20499
IAST [candidate] (22.318 ms) : 0, 22318
Remote Config [baseline] (602.739 µs) : 0, 603
Remote Config [candidate] (604.85 µs) : 0, 605
Telemetry [baseline] (7.084 ms) : 0, 7084
Telemetry [candidate] (7.105 ms) : 0, 7105
section profiling
BytebuddyAgent [baseline] (683.88 ms) : 0, 683880
BytebuddyAgent [candidate] (681.431 ms) : 0, 681431
GlobalTracer [baseline] (397.538 ms) : 0, 397538
GlobalTracer [candidate] (397.506 ms) : 0, 397506
AppSec [baseline] (54.864 ms) : 0, 54864
AppSec [candidate] (54.603 ms) : 0, 54603
Remote Config [baseline] (663.209 µs) : 0, 663
Remote Config [candidate] (668.787 µs) : 0, 669
Telemetry [baseline] (14.458 ms) : 0, 14458
Telemetry [candidate] (7.506 ms) : 0, 7506
ProfilingAgent [baseline] (89.879 ms) : 0, 89879
ProfilingAgent [candidate] (97.665 ms) : 0, 97665
Profiling [baseline] (89.902 ms) : 0, 89902
Profiling [candidate] (97.689 ms) : 0, 97689
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085563
Total [baseline] (8.618 s) : 0, 8618207
Agent [candidate] (1.085 s) : 0, 1084830
Total [candidate] (8.67 s) : 0, 8670184
section iast
Agent [baseline] (1.2 s) : 0, 1200096
Total [baseline] (9.116 s) : 0, 9116222
Agent [candidate] (1.201 s) : 0, 1201169
Total [candidate] (9.128 s) : 0, 9127502
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1200033
Total [baseline] (9.079 s) : 0, 9079491
Agent [candidate] (1.201 s) : 0, 1200845
Total [candidate] (9.067 s) : 0, 9066735
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1212990
Total [baseline] (9.141 s) : 0, 9140603
Agent [candidate] (1.205 s) : 0, 1205468
Total [candidate] (9.141 s) : 0, 9140870
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.2 s 114.534 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 114.47 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.213 s 127.427 ms (11.7%)
Total tracing 8.618 s -
Total iast 9.116 s 498.015 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.079 s 461.284 ms (5.4%)
Total iast_TELEMETRY_OFF 9.141 s 522.396 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.201 s 116.338 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 116.015 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.205 s 120.638 ms (11.1%)
Total tracing 8.67 s -
Total iast 9.128 s 457.318 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.067 s 396.551 ms (4.6%)
Total iast_TELEMETRY_OFF 9.141 s 470.687 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.059 ms) : 0, 694059
BytebuddyAgent [candidate] (692.493 ms) : 0, 692493
GlobalTracer [baseline] (314.169 ms) : 0, 314169
GlobalTracer [candidate] (315.578 ms) : 0, 315578
AppSec [baseline] (53.932 ms) : 0, 53932
AppSec [candidate] (54.571 ms) : 0, 54571
Remote Config [baseline] (666.593 µs) : 0, 667
Remote Config [candidate] (674.116 µs) : 0, 674
Telemetry [baseline] (8.906 ms) : 0, 8906
Telemetry [candidate] (7.657 ms) : 0, 7657
section iast
BytebuddyAgent [baseline] (800.405 ms) : 0, 800405
BytebuddyAgent [candidate] (799.719 ms) : 0, 799719
GlobalTracer [baseline] (301.02 ms) : 0, 301020
GlobalTracer [candidate] (301.628 ms) : 0, 301628
AppSec [baseline] (57.253 ms) : 0, 57253
AppSec [candidate] (55.639 ms) : 0, 55639
IAST [baseline] (20.114 ms) : 0, 20114
IAST [candidate] (22.822 ms) : 0, 22822
Remote Config [baseline] (604.291 µs) : 0, 604
Remote Config [candidate] (595.742 µs) : 0, 596
Telemetry [baseline] (7.057 ms) : 0, 7057
Telemetry [candidate] (7.028 ms) : 0, 7028
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.394 ms) : 0, 799394
BytebuddyAgent [candidate] (799.095 ms) : 0, 799095
GlobalTracer [baseline] (301.458 ms) : 0, 301458
GlobalTracer [candidate] (301.96 ms) : 0, 301960
AppSec [baseline] (54.449 ms) : 0, 54449
AppSec [candidate] (57.304 ms) : 0, 57304
IAST [baseline] (23.525 ms) : 0, 23525
IAST [candidate] (21.12 ms) : 0, 21120
Remote Config [baseline] (596.756 µs) : 0, 597
Remote Config [candidate] (596.463 µs) : 0, 596
Telemetry [baseline] (6.974 ms) : 0, 6974
Telemetry [candidate] (7.068 ms) : 0, 7068
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (808.073 ms) : 0, 808073
BytebuddyAgent [candidate] (801.94 ms) : 0, 801940
GlobalTracer [baseline] (305.115 ms) : 0, 305115
GlobalTracer [candidate] (303.688 ms) : 0, 303688
AppSec [baseline] (56.927 ms) : 0, 56927
AppSec [candidate] (55.696 ms) : 0, 55696
IAST [baseline] (21.323 ms) : 0, 21323
IAST [candidate] (22.723 ms) : 0, 22723
Remote Config [baseline] (626.058 µs) : 0, 626
Remote Config [candidate] (608.534 µs) : 0, 609
Telemetry [baseline] (7.124 ms) : 0, 7124
Telemetry [candidate] (7.0 ms) : 0, 7000
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-18T14:06:58 2024-10-18T14:13:51
git_branch master paul.laffon/backport-pr-7795
git_commit_date 1729257196 1729259841
git_commit_sha 00856e0 8f37b2b
release_version 1.42.0-SNAPSHOT~00856e02d3 1.42.0-SNAPSHOT~8f37b2bdd9
start_time 2024-10-18T14:06:44 2024-10-18T14:13:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729261179 1729261179
ci_job_id 676904986 676904986
ci_pipeline_id 46916248 46916248
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.338 µs) : 357, 396
.   : milestone, 376,
iast (503.251 µs) : 481, 525
.   : milestone, 503,
iast_FULL (551.927 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (515.074 µs) : 492, 538
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (492.585 µs) : 471, 514
.   : milestone, 493,
iast_INACTIVE (450.747 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (479.139 µs) : 458, 500
.   : milestone, 479,
tracing (450.524 µs) : 430, 471
.   : milestone, 451,
section candidate
no_agent (375.307 µs) : 356, 395
.   : milestone, 375,
iast (491.539 µs) : 470, 513
.   : milestone, 492,
iast_FULL (566.32 µs) : 545, 588
.   : milestone, 566,
iast_GLOBAL (505.909 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (489.3 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (455.66 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (484.029 µs) : 463, 505
.   : milestone, 484,
tracing (455.225 µs) : 434, 477
.   : milestone, 455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.338 µs [356.756 µs, 395.921 µs] -
iast 503.251 µs [481.247 µs, 525.255 µs] 126.913 µs (33.7%)
iast_FULL 551.927 µs [530.513 µs, 573.342 µs] 175.589 µs (46.7%)
iast_GLOBAL 515.074 µs [492.305 µs, 537.844 µs] 138.736 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 492.585 µs [470.939 µs, 514.231 µs] 116.246 µs (30.9%)
iast_INACTIVE 450.747 µs [429.918 µs, 471.576 µs] 74.408 µs (19.8%)
iast_TELEMETRY_OFF 479.139 µs [457.778 µs, 500.5 µs] 102.801 µs (27.3%)
tracing 450.524 µs [429.573 µs, 471.474 µs] 74.185 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.307 µs [355.678 µs, 394.935 µs] -
iast 491.539 µs [469.854 µs, 513.223 µs] 116.232 µs (31.0%)
iast_FULL 566.32 µs [544.702 µs, 587.939 µs] 191.014 µs (50.9%)
iast_GLOBAL 505.909 µs [484.753 µs, 527.066 µs] 130.603 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 489.3 µs [467.989 µs, 510.611 µs] 113.993 µs (30.4%)
iast_INACTIVE 455.66 µs [434.586 µs, 476.733 µs] 80.353 µs (21.4%)
iast_TELEMETRY_OFF 484.029 µs [462.774 µs, 505.283 µs] 108.722 µs (29.0%)
tracing 455.225 µs [433.798 µs, 476.653 µs] 79.919 µs (21.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1372
.   : milestone, 1353,
appsec (1.721 ms) : 1696, 1746
.   : milestone, 1721,
appsec_no_iast (1.732 ms) : 1708, 1756
.   : milestone, 1732,
iast (1.473 ms) : 1450, 1496
.   : milestone, 1473,
profiling (1.49 ms) : 1467, 1513
.   : milestone, 1490,
tracing (1.465 ms) : 1440, 1490
.   : milestone, 1465,
section candidate
no_agent (1.363 ms) : 1343, 1382
.   : milestone, 1363,
appsec (1.726 ms) : 1702, 1750
.   : milestone, 1726,
appsec_no_iast (1.738 ms) : 1713, 1762
.   : milestone, 1738,
iast (1.502 ms) : 1479, 1525
.   : milestone, 1502,
profiling (1.478 ms) : 1456, 1501
.   : milestone, 1478,
tracing (1.465 ms) : 1441, 1490
.   : milestone, 1465,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.372 ms] -
appsec 1.721 ms [1.696 ms, 1.746 ms] 368.197 µs (27.2%)
appsec_no_iast 1.732 ms [1.708 ms, 1.756 ms] 379.509 µs (28.1%)
iast 1.473 ms [1.45 ms, 1.496 ms] 120.298 µs (8.9%)
profiling 1.49 ms [1.467 ms, 1.513 ms] 137.236 µs (10.1%)
tracing 1.465 ms [1.44 ms, 1.49 ms] 112.313 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.382 ms] -
appsec 1.726 ms [1.702 ms, 1.75 ms] 363.255 µs (26.7%)
appsec_no_iast 1.738 ms [1.713 ms, 1.762 ms] 374.988 µs (27.5%)
iast 1.502 ms [1.479 ms, 1.525 ms] 138.933 µs (10.2%)
profiling 1.478 ms [1.456 ms, 1.501 ms] 115.373 µs (8.5%)
tracing 1.465 ms [1.441 ms, 1.49 ms] 102.289 µs (7.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master paul.laffon/backport-pr-7795
git_commit_date 1729257196 1729259841
git_commit_sha 00856e0 8f37b2b
release_version 1.42.0-SNAPSHOT~00856e02d3 1.42.0-SNAPSHOT~8f37b2bdd9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729261717 1729261717
ci_job_id 676904988 676904988
ci_pipeline_id 46916248 46916248
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1476
.   : milestone, 1465,
appsec (2.334 ms) : 2293, 2375
.   : milestone, 2334,
iast (2.079 ms) : 2027, 2131
.   : milestone, 2079,
iast_GLOBAL (2.108 ms) : 2056, 2160
.   : milestone, 2108,
profiling (2.426 ms) : 2238, 2614
.   : milestone, 2426,
tracing (1.903 ms) : 1864, 1942
.   : milestone, 1903,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.307 ms) : 2266, 2347
.   : milestone, 2307,
iast (2.067 ms) : 2015, 2119
.   : milestone, 2067,
iast_GLOBAL (2.109 ms) : 2057, 2161
.   : milestone, 2109,
profiling (1.946 ms) : 1903, 1988
.   : milestone, 1946,
tracing (1.913 ms) : 1873, 1953
.   : milestone, 1913,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.476 ms] -
appsec 2.334 ms [2.293 ms, 2.375 ms] 868.753 µs (59.3%)
iast 2.079 ms [2.027 ms, 2.131 ms] 614.429 µs (41.9%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.16 ms] 642.729 µs (43.9%)
profiling 2.426 ms [2.238 ms, 2.614 ms] 961.137 µs (65.6%)
tracing 1.903 ms [1.864 ms, 1.942 ms] 438.221 µs (29.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.307 ms [2.266 ms, 2.347 ms] 838.976 µs (57.2%)
iast 2.067 ms [2.015 ms, 2.119 ms] 599.266 µs (40.8%)
iast_GLOBAL 2.109 ms [2.057 ms, 2.161 ms] 641.213 µs (43.7%)
profiling 1.946 ms [1.903 ms, 1.988 ms] 477.919 µs (32.6%)
tracing 1.913 ms [1.873 ms, 1.953 ms] 445.341 µs (30.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~8f37b2bdd9, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
appsec (15.474 s) : 15474000, 15474000
.   : milestone, 15474000,
iast (18.524 s) : 18524000, 18524000
.   : milestone, 18524000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
.   : milestone, 18150000,
profiling (15.373 s) : 15373000, 15373000
.   : milestone, 15373000,
tracing (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
section candidate
no_agent (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
appsec (15.372 s) : 15372000, 15372000
.   : milestone, 15372000,
iast (19.286 s) : 19286000, 19286000
.   : milestone, 19286000,
iast_GLOBAL (18.074 s) : 18074000, 18074000
.   : milestone, 18074000,
profiling (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,
tracing (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.045 s [15.045 s, 15.045 s] -
appsec 15.474 s [15.474 s, 15.474 s] 429.0 ms (2.9%)
iast 18.524 s [18.524 s, 18.524 s] 3.479 s (23.1%)
iast_GLOBAL 18.15 s [18.15 s, 18.15 s] 3.105 s (20.6%)
profiling 15.373 s [15.373 s, 15.373 s] 328.0 ms (2.2%)
tracing 14.971 s [14.971 s, 14.971 s] -74.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.096 s [15.096 s, 15.096 s] -
appsec 15.372 s [15.372 s, 15.372 s] 276.0 ms (1.8%)
iast 19.286 s [19.286 s, 19.286 s] 4.19 s (27.8%)
iast_GLOBAL 18.074 s [18.074 s, 18.074 s] 2.978 s (19.7%)
profiling 15.119 s [15.119 s, 15.119 s] 23.0 ms (0.2%)
tracing 15.089 s [15.089 s, 15.089 s] -7.0 ms (-0.0%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit a4e2819 into release/v1.41.x Oct 18, 2024
100 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the paul.laffon/backport-pr-7795 branch October 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: apache spark Apache Spark instrumentation type: bug
Projects
None yet
Milestone
1.41.1
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-laffon-dd @nikita-tkachenko-datadog