Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for long-running spans with DJM #7795

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix default value for long-running spans with DJM #7795

merged 1 commit into from
Oct 22, 2024

Conversation

paul-laffon-dd
Copy link
Contributor

@paul-laffon-dd paul-laffon-dd commented Oct 17, 2024 •
edited
Loading

What Does This Do

Change the default config values for DJM before the first call to Config.get() that resolve the Config values.

Motivation

Long running spans not being enabled when using -Ddd.data.jobs.enabled=true since the config values were already resolved before the default values are changed

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master paul.laffon/default-long-running-span-djm
git_commit_date 1729190976 1729193779
git_commit_sha 9320a05 35b4f26
release_version 1.42.0-SNAPSHOT~9320a05d02 1.42.0-SNAPSHOT~35b4f26f84
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729196217 1729196217
ci_job_id 676097000 676097000
ci_pipeline_id 46860879 46860879
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084612
Total [baseline] (10.402 s) : 0, 10402060
Agent [candidate] (1.079 s) : 0, 1078608
Total [candidate] (10.473 s) : 0, 10472602
section appsec
Agent [baseline] (1.215 s) : 0, 1215252
Total [baseline] (10.64 s) : 0, 10640271
Agent [candidate] (1.212 s) : 0, 1211811
Total [candidate] (10.598 s) : 0, 10598201
section iast
Agent [baseline] (1.223 s) : 0, 1223294
Total [baseline] (10.974 s) : 0, 10973705
Agent [candidate] (1.203 s) : 0, 1202883
Total [candidate] (10.924 s) : 0, 10923786
section profiling
Agent [baseline] (1.281 s) : 0, 1281434
Total [baseline] (10.765 s) : 0, 10765381
Agent [candidate] (1.285 s) : 0, 1284711
Total [candidate] (10.701 s) : 0, 10700853
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent appsec 1.215 s 130.641 ms (12.0%)
Agent iast 1.223 s 138.683 ms (12.8%)
Agent profiling 1.281 s 196.822 ms (18.1%)
Total tracing 10.402 s -
Total appsec 10.64 s 238.211 ms (2.3%)
Total iast 10.974 s 571.645 ms (5.5%)
Total profiling 10.765 s 363.321 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.212 s 133.203 ms (12.3%)
Agent iast 1.203 s 124.274 ms (11.5%)
Agent profiling 1.285 s 206.102 ms (19.1%)
Total tracing 10.473 s -
Total appsec 10.598 s 125.599 ms (1.2%)
Total iast 10.924 s 451.184 ms (4.3%)
Total profiling 10.701 s 228.251 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.312 ms) : 0, 691312
BytebuddyAgent [candidate] (688.049 ms) : 0, 688049
GlobalTracer [baseline] (314.938 ms) : 0, 314938
GlobalTracer [candidate] (313.07 ms) : 0, 313070
AppSec [baseline] (54.265 ms) : 0, 54265
AppSec [candidate] (54.101 ms) : 0, 54101
Remote Config [baseline] (674.106 µs) : 0, 674
Remote Config [candidate] (664.381 µs) : 0, 664
Telemetry [baseline] (9.599 ms) : 0, 9599
Telemetry [candidate] (8.963 ms) : 0, 8963
section appsec
BytebuddyAgent [baseline] (705.556 ms) : 0, 705556
BytebuddyAgent [candidate] (703.563 ms) : 0, 703563
GlobalTracer [baseline] (311.102 ms) : 0, 311102
GlobalTracer [candidate] (310.302 ms) : 0, 310302
AppSec [baseline] (166.123 ms) : 0, 166123
AppSec [candidate] (166.761 ms) : 0, 166761
Remote Config [baseline] (640.09 µs) : 0, 640
Remote Config [candidate] (636.79 µs) : 0, 637
Telemetry [baseline] (7.859 ms) : 0, 7859
Telemetry [candidate] (7.124 ms) : 0, 7124
IAST [baseline] (20.393 ms) : 0, 20393
IAST [candidate] (19.341 ms) : 0, 19341
section iast
BytebuddyAgent [baseline] (814.104 ms) : 0, 814104
BytebuddyAgent [candidate] (801.923 ms) : 0, 801923
GlobalTracer [baseline] (307.152 ms) : 0, 307152
GlobalTracer [candidate] (301.68 ms) : 0, 301680
AppSec [baseline] (56.625 ms) : 0, 56625
AppSec [candidate] (57.329 ms) : 0, 57329
Remote Config [baseline] (633.802 µs) : 0, 634
Remote Config [candidate] (606.109 µs) : 0, 606
Telemetry [baseline] (7.307 ms) : 0, 7307
Telemetry [candidate] (7.037 ms) : 0, 7037
IAST [baseline] (23.519 ms) : 0, 23519
IAST [candidate] (20.556 ms) : 0, 20556
section profiling
ProfilingAgent [baseline] (91.169 ms) : 0, 91169
ProfilingAgent [candidate] (91.274 ms) : 0, 91274
BytebuddyAgent [baseline] (684.825 ms) : 0, 684825
BytebuddyAgent [candidate] (685.822 ms) : 0, 685822
GlobalTracer [baseline] (398.27 ms) : 0, 398270
GlobalTracer [candidate] (398.629 ms) : 0, 398629
AppSec [baseline] (55.07 ms) : 0, 55070
AppSec [candidate] (55.22 ms) : 0, 55220
Remote Config [baseline] (658.497 µs) : 0, 658
Remote Config [candidate] (665.058 µs) : 0, 665
Telemetry [baseline] (12.228 ms) : 0, 12228
Telemetry [candidate] (13.921 ms) : 0, 13921
Profiling [baseline] (91.193 ms) : 0, 91193
Profiling [candidate] (91.298 ms) : 0, 91298
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077594
Total [baseline] (8.571 s) : 0, 8571394
Agent [candidate] (1.086 s) : 0, 1085783
Total [candidate] (8.572 s) : 0, 8572377
section iast
Agent [baseline] (1.213 s) : 0, 1213419
Total [baseline] (9.123 s) : 0, 9122826
Agent [candidate] (1.206 s) : 0, 1205731
Total [candidate] (9.224 s) : 0, 9224239
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.214 s) : 0, 1213585
Total [baseline] (9.144 s) : 0, 9143939
Agent [candidate] (1.205 s) : 0, 1205030
Total [candidate] (9.089 s) : 0, 9088805
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1199746
Total [baseline] (9.116 s) : 0, 9115747
Agent [candidate] (1.203 s) : 0, 1203164
Total [candidate] (9.098 s) : 0, 9097697
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.213 s 135.825 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 135.99 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.2 s 122.152 ms (11.3%)
Total tracing 8.571 s -
Total iast 9.123 s 551.433 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.144 s 572.545 ms (6.7%)
Total iast_TELEMETRY_OFF 9.116 s 544.354 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.206 s 119.948 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 119.247 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.203 s 117.381 ms (10.8%)
Total tracing 8.572 s -
Total iast 9.224 s 651.862 ms (7.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.089 s 516.429 ms (6.0%)
Total iast_TELEMETRY_OFF 9.098 s 525.32 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.301 ms) : 0, 687301
BytebuddyAgent [candidate] (691.687 ms) : 0, 691687
GlobalTracer [baseline] (313.566 ms) : 0, 313566
GlobalTracer [candidate] (314.864 ms) : 0, 314864
AppSec [baseline] (54.148 ms) : 0, 54148
AppSec [candidate] (54.3 ms) : 0, 54300
Remote Config [baseline] (671.637 µs) : 0, 672
Remote Config [candidate] (679.983 µs) : 0, 680
Telemetry [baseline] (8.194 ms) : 0, 8194
Telemetry [candidate] (10.411 ms) : 0, 10411
section iast
BytebuddyAgent [baseline] (808.66 ms) : 0, 808660
BytebuddyAgent [candidate] (802.604 ms) : 0, 802604
GlobalTracer [baseline] (303.738 ms) : 0, 303738
GlobalTracer [candidate] (302.475 ms) : 0, 302475
AppSec [baseline] (57.035 ms) : 0, 57035
AppSec [candidate] (58.252 ms) : 0, 58252
IAST [baseline] (22.239 ms) : 0, 22239
IAST [candidate] (20.679 ms) : 0, 20679
Remote Config [baseline] (619.41 µs) : 0, 619
Remote Config [candidate] (625.272 µs) : 0, 625
Telemetry [baseline] (7.259 ms) : 0, 7259
Telemetry [candidate] (7.22 ms) : 0, 7220
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.261 ms) : 0, 808261
BytebuddyAgent [candidate] (802.358 ms) : 0, 802358
GlobalTracer [baseline] (303.965 ms) : 0, 303965
GlobalTracer [candidate] (302.376 ms) : 0, 302376
AppSec [baseline] (57.885 ms) : 0, 57885
AppSec [candidate] (58.068 ms) : 0, 58068
IAST [baseline] (21.707 ms) : 0, 21707
IAST [candidate] (20.666 ms) : 0, 20666
Remote Config [baseline] (622.677 µs) : 0, 623
Remote Config [candidate] (614.218 µs) : 0, 614
Telemetry [baseline] (7.262 ms) : 0, 7262
Telemetry [candidate] (7.154 ms) : 0, 7154
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.075 ms) : 0, 798075
BytebuddyAgent [candidate] (800.183 ms) : 0, 800183
GlobalTracer [baseline] (302.452 ms) : 0, 302452
GlobalTracer [candidate] (303.437 ms) : 0, 303437
AppSec [baseline] (57.584 ms) : 0, 57584
AppSec [candidate] (57.248 ms) : 0, 57248
IAST [baseline] (20.191 ms) : 0, 20191
IAST [candidate] (20.861 ms) : 0, 20861
Remote Config [baseline] (627.657 µs) : 0, 628
Remote Config [candidate] (596.182 µs) : 0, 596
Telemetry [baseline] (7.083 ms) : 0, 7083
Telemetry [candidate] (7.035 ms) : 0, 7035
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-17T19:47:23 2024-10-17T19:54:17
git_branch master paul.laffon/default-long-running-span-djm
git_commit_date 1729190976 1729193779
git_commit_sha 9320a05 35b4f26
release_version 1.42.0-SNAPSHOT~9320a05d02 1.42.0-SNAPSHOT~35b4f26f84
start_time 2024-10-17T19:47:09 2024-10-17T19:54:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729195207 1729195207
ci_job_id 676097001 676097001
ci_pipeline_id 46860879 46860879
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.363 ms) : 1343, 1383
.   : milestone, 1363,
appsec (1.727 ms) : 1704, 1750
.   : milestone, 1727,
appsec_no_iast (1.752 ms) : 1729, 1776
.   : milestone, 1752,
iast (1.495 ms) : 1472, 1518
.   : milestone, 1495,
profiling (1.496 ms) : 1473, 1520
.   : milestone, 1496,
tracing (1.472 ms) : 1449, 1496
.   : milestone, 1472,
section candidate
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.736 ms) : 1713, 1759
.   : milestone, 1736,
appsec_no_iast (1.731 ms) : 1707, 1756
.   : milestone, 1731,
iast (1.518 ms) : 1496, 1541
.   : milestone, 1518,
profiling (1.485 ms) : 1463, 1508
.   : milestone, 1485,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.383 ms] -
appsec 1.727 ms [1.704 ms, 1.75 ms] 364.0 µs (26.7%)
appsec_no_iast 1.752 ms [1.729 ms, 1.776 ms] 389.117 µs (28.5%)
iast 1.495 ms [1.472 ms, 1.518 ms] 131.996 µs (9.7%)
profiling 1.496 ms [1.473 ms, 1.52 ms] 132.966 µs (9.8%)
tracing 1.472 ms [1.449 ms, 1.496 ms] 109.22 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.736 ms [1.713 ms, 1.759 ms] 384.845 µs (28.5%)
appsec_no_iast 1.731 ms [1.707 ms, 1.756 ms] 380.199 µs (28.1%)
iast 1.518 ms [1.496 ms, 1.541 ms] 166.997 µs (12.4%)
profiling 1.485 ms [1.463 ms, 1.508 ms] 134.212 µs (9.9%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 113.211 µs (8.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.917 µs) : 358, 399
.   : milestone, 379,
iast (496.083 µs) : 474, 518
.   : milestone, 496,
iast_FULL (562.34 µs) : 541, 584
.   : milestone, 562,
iast_GLOBAL (522.19 µs) : 500, 545
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (491.013 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (454.838 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (480.088 µs) : 459, 502
.   : milestone, 480,
tracing (458.048 µs) : 437, 479
.   : milestone, 458,
section candidate
no_agent (379.005 µs) : 357, 401
.   : milestone, 379,
iast (490.545 µs) : 469, 512
.   : milestone, 491,
iast_FULL (563.423 µs) : 542, 585
.   : milestone, 563,
iast_GLOBAL (508.448 µs) : 487, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (499.095 µs) : 478, 521
.   : milestone, 499,
iast_INACTIVE (457.74 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (480.805 µs) : 460, 502
.   : milestone, 481,
tracing (459.672 µs) : 438, 481
.   : milestone, 460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.917 µs [358.465 µs, 399.37 µs] -
iast 496.083 µs [474.48 µs, 517.687 µs] 117.166 µs (30.9%)
iast_FULL 562.34 µs [540.931 µs, 583.75 µs] 183.423 µs (48.4%)
iast_GLOBAL 522.19 µs [499.798 µs, 544.582 µs] 143.273 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 491.013 µs [469.839 µs, 512.188 µs] 112.096 µs (29.6%)
iast_INACTIVE 454.838 µs [433.515 µs, 476.16 µs] 75.92 µs (20.0%)
iast_TELEMETRY_OFF 480.088 µs [458.642 µs, 501.534 µs] 101.17 µs (26.7%)
tracing 458.048 µs [437.103 µs, 478.993 µs] 79.13 µs (20.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.005 µs [357.414 µs, 400.596 µs] -
iast 490.545 µs [469.205 µs, 511.886 µs] 111.54 µs (29.4%)
iast_FULL 563.423 µs [541.517 µs, 585.33 µs] 184.418 µs (48.7%)
iast_GLOBAL 508.448 µs [487.389 µs, 529.508 µs] 129.444 µs (34.2%)
iast_HARDCODED_SECRET_DISABLED 499.095 µs [477.56 µs, 520.631 µs] 120.09 µs (31.7%)
iast_INACTIVE 457.74 µs [436.942 µs, 478.538 µs] 78.735 µs (20.8%)
iast_TELEMETRY_OFF 480.805 µs [459.614 µs, 501.996 µs] 101.8 µs (26.9%)
tracing 459.672 µs [438.024 µs, 481.32 µs] 80.667 µs (21.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master paul.laffon/default-long-running-span-djm
git_commit_date 1729190976 1729193779
git_commit_sha 9320a05 35b4f26
release_version 1.42.0-SNAPSHOT~9320a05d02 1.42.0-SNAPSHOT~35b4f26f84
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729195721 1729195721
ci_job_id 676097002 676097002
ci_pipeline_id 46860879 46860879
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.323 ms) : 2282, 2363
.   : milestone, 2323,
iast (2.092 ms) : 2039, 2145
.   : milestone, 2092,
iast_GLOBAL (2.128 ms) : 2074, 2181
.   : milestone, 2128,
profiling (1.923 ms) : 1882, 1964
.   : milestone, 1923,
tracing (1.918 ms) : 1879, 1958
.   : milestone, 1918,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.34 ms) : 2299, 2381
.   : milestone, 2340,
iast (2.076 ms) : 2024, 2128
.   : milestone, 2076,
iast_GLOBAL (2.125 ms) : 2072, 2179
.   : milestone, 2125,
profiling (1.938 ms) : 1897, 1979
.   : milestone, 1938,
tracing (1.922 ms) : 1882, 1961
.   : milestone, 1922,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.323 ms [2.282 ms, 2.363 ms] 848.941 µs (57.6%)
iast 2.092 ms [2.039 ms, 2.145 ms] 618.302 µs (42.0%)
iast_GLOBAL 2.128 ms [2.074 ms, 2.181 ms] 653.9 µs (44.4%)
profiling 1.923 ms [1.882 ms, 1.964 ms] 449.265 µs (30.5%)
tracing 1.918 ms [1.879 ms, 1.958 ms] 444.5 µs (30.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.34 ms [2.299 ms, 2.381 ms] 872.502 µs (59.5%)
iast 2.076 ms [2.024 ms, 2.128 ms] 608.943 µs (41.5%)
iast_GLOBAL 2.125 ms [2.072 ms, 2.179 ms] 658.174 µs (44.9%)
profiling 1.938 ms [1.897 ms, 1.979 ms] 470.718 µs (32.1%)
tracing 1.922 ms [1.882 ms, 1.961 ms] 454.325 µs (31.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~35b4f26f84, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
appsec (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
iast (18.611 s) : 18611000, 18611000
.   : milestone, 18611000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
.   : milestone, 18100000,
profiling (15.192 s) : 15192000, 15192000
.   : milestone, 15192000,
tracing (14.859 s) : 14859000, 14859000
.   : milestone, 14859000,
section candidate
no_agent (15.278 s) : 15278000, 15278000
.   : milestone, 15278000,
appsec (15.316 s) : 15316000, 15316000
.   : milestone, 15316000,
iast (18.847 s) : 18847000, 18847000
.   : milestone, 18847000,
iast_GLOBAL (18.124 s) : 18124000, 18124000
.   : milestone, 18124000,
profiling (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
tracing (15.313 s) : 15313000, 15313000
.   : milestone, 15313000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.166 s [15.166 s, 15.166 s] -
appsec 15.198 s [15.198 s, 15.198 s] 32.0 ms (0.2%)
iast 18.611 s [18.611 s, 18.611 s] 3.445 s (22.7%)
iast_GLOBAL 18.1 s [18.1 s, 18.1 s] 2.934 s (19.3%)
profiling 15.192 s [15.192 s, 15.192 s] 26.0 ms (0.2%)
tracing 14.859 s [14.859 s, 14.859 s] -307.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.278 s [15.278 s, 15.278 s] -
appsec 15.316 s [15.316 s, 15.316 s] 38.0 ms (0.2%)
iast 18.847 s [18.847 s, 18.847 s] 3.569 s (23.4%)
iast_GLOBAL 18.124 s [18.124 s, 18.124 s] 2.846 s (18.6%)
profiling 15.179 s [15.179 s, 15.179 s] -99.0 ms (-0.6%)
tracing 15.313 s [15.313 s, 15.313 s] 35.0 ms (0.2%)

@paul-laffon-dd paul-laffon-dd added inst: apache spark Apache Spark instrumentation type: bug labels Oct 18, 2024
@paul-laffon-dd paul-laffon-dd marked this pull request as ready for review October 18, 2024 11:16
@paul-laffon-dd paul-laffon-dd requested a review from a team as a code owner October 18, 2024 11:16
@paul-laffon-dd paul-laffon-dd requested review from smola and a team October 18, 2024 11:16
@paul-laffon-dd paul-laffon-dd mentioned this pull request Oct 18, 2024
Merged
5 tasks
@paul-laffon-dd paul-laffon-dd merged commit d446c85 into master Oct 22, 2024
106 checks passed
@paul-laffon-dd paul-laffon-dd deleted the paul.laffon/default-long-running-span-djm branch October 22, 2024 08:13
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboitreaud aboitreaud aboitreaud approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: apache spark Apache Spark instrumentation type: bug
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-laffon-dd @aboitreaud