-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7784] Fix automatic coverage includes calculation for headless test sessions #7809
Merged
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7784
Oct 18, 2024
Merged
[🍒 7784] Fix automatic coverage includes calculation for headless test sessions #7809
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7784
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 18, 2024
juan-fernandez
approved these changes
Oct 18, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084348
Total [baseline] (8.609 s) : 0, 8609396
Agent [candidate] (1.074 s) : 0, 1073826
Total [candidate] (8.592 s) : 0, 8592315
section iast
Agent [baseline] (1.208 s) : 0, 1208402
Total [baseline] (9.117 s) : 0, 9116823
Agent [candidate] (1.202 s) : 0, 1202266
Total [candidate] (9.122 s) : 0, 9122001
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203994
Total [baseline] (9.092 s) : 0, 9092081
Agent [candidate] (1.199 s) : 0, 1199461
Total [candidate] (9.073 s) : 0, 9072719
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1198306
Total [baseline] (9.084 s) : 0, 9083874
Agent [candidate] (1.205 s) : 0, 1205415
Total [candidate] (9.077 s) : 0, 9077182
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.343 ms) : 0, 690343
BytebuddyAgent [candidate] (685.313 ms) : 0, 685313
GlobalTracer [baseline] (314.367 ms) : 0, 314367
GlobalTracer [candidate] (312.615 ms) : 0, 312615
AppSec [baseline] (54.16 ms) : 0, 54160
AppSec [candidate] (54.049 ms) : 0, 54049
Remote Config [baseline] (676.743 µs) : 0, 677
Remote Config [candidate] (664.245 µs) : 0, 664
Telemetry [baseline] (11.073 ms) : 0, 11073
Telemetry [candidate] (7.495 ms) : 0, 7495
section iast
BytebuddyAgent [baseline] (806.201 ms) : 0, 806201
BytebuddyAgent [candidate] (800.459 ms) : 0, 800459
GlobalTracer [baseline] (303.235 ms) : 0, 303235
GlobalTracer [candidate] (302.151 ms) : 0, 302151
AppSec [baseline] (56.759 ms) : 0, 56759
AppSec [candidate] (57.957 ms) : 0, 57957
Remote Config [baseline] (588.657 µs) : 0, 589
Remote Config [candidate] (594.147 µs) : 0, 594
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.035 ms) : 0, 7035
IAST [baseline] (20.05 ms) : 0, 20050
IAST [candidate] (20.348 ms) : 0, 20348
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.565 ms) : 0, 802565
BytebuddyAgent [candidate] (797.997 ms) : 0, 797997
GlobalTracer [baseline] (302.287 ms) : 0, 302287
GlobalTracer [candidate] (301.676 ms) : 0, 301676
AppSec [baseline] (57.371 ms) : 0, 57371
AppSec [candidate] (56.291 ms) : 0, 56291
Remote Config [baseline] (600.588 µs) : 0, 601
Remote Config [candidate] (604.933 µs) : 0, 605
Telemetry [baseline] (7.079 ms) : 0, 7079
Telemetry [candidate] (7.038 ms) : 0, 7038
IAST [baseline] (20.383 ms) : 0, 20383
IAST [candidate] (22.149 ms) : 0, 22149
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.49 ms) : 0, 797490
BytebuddyAgent [candidate] (802.09 ms) : 0, 802090
GlobalTracer [baseline] (301.681 ms) : 0, 301681
GlobalTracer [candidate] (304.112 ms) : 0, 304112
AppSec [baseline] (57.817 ms) : 0, 57817
AppSec [candidate] (56.293 ms) : 0, 56293
Remote Config [baseline] (603.363 µs) : 0, 603
Remote Config [candidate] (609.903 µs) : 0, 610
Telemetry [baseline] (6.978 ms) : 0, 6978
Telemetry [candidate] (6.996 ms) : 0, 6996
IAST [baseline] (20.086 ms) : 0, 20086
IAST [candidate] (21.493 ms) : 0, 21493
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075338
Total [baseline] (10.411 s) : 0, 10410918
Agent [candidate] (1.073 s) : 0, 1073400
Total [candidate] (10.374 s) : 0, 10373600
section appsec
Agent [baseline] (1.209 s) : 0, 1209228
Total [baseline] (10.639 s) : 0, 10638964
Agent [candidate] (1.21 s) : 0, 1209819
Total [candidate] (10.609 s) : 0, 10609425
section iast
Agent [baseline] (1.212 s) : 0, 1211510
Total [baseline] (10.943 s) : 0, 10943396
Agent [candidate] (1.209 s) : 0, 1209262
Total [candidate] (10.845 s) : 0, 10844622
section profiling
Agent [baseline] (1.285 s) : 0, 1284987
Total [baseline] (10.704 s) : 0, 10704075
Agent [candidate] (1.274 s) : 0, 1274005
Total [candidate] (10.597 s) : 0, 10597234
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.985 ms) : 0, 684985
BytebuddyAgent [candidate] (685.352 ms) : 0, 685352
GlobalTracer [baseline] (312.48 ms) : 0, 312480
GlobalTracer [candidate] (312.487 ms) : 0, 312487
AppSec [baseline] (53.935 ms) : 0, 53935
AppSec [candidate] (53.725 ms) : 0, 53725
Remote Config [baseline] (659.053 µs) : 0, 659
Remote Config [candidate] (673.244 µs) : 0, 673
Telemetry [baseline] (9.614 ms) : 0, 9614
Telemetry [candidate] (7.47 ms) : 0, 7470
section appsec
BytebuddyAgent [baseline] (702.499 ms) : 0, 702499
BytebuddyAgent [candidate] (702.471 ms) : 0, 702471
GlobalTracer [baseline] (309.483 ms) : 0, 309483
GlobalTracer [candidate] (310.886 ms) : 0, 310886
AppSec [baseline] (165.296 ms) : 0, 165296
AppSec [candidate] (164.025 ms) : 0, 164025
Remote Config [baseline] (629.511 µs) : 0, 630
Remote Config [candidate] (633.652 µs) : 0, 634
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (8.113 ms) : 0, 8113
IAST [baseline] (18.495 ms) : 0, 18495
IAST [candidate] (19.92 ms) : 0, 19920
section iast
BytebuddyAgent [baseline] (807.986 ms) : 0, 807986
BytebuddyAgent [candidate] (805.308 ms) : 0, 805308
GlobalTracer [baseline] (304.183 ms) : 0, 304183
GlobalTracer [candidate] (303.579 ms) : 0, 303579
AppSec [baseline] (57.226 ms) : 0, 57226
AppSec [candidate] (56.76 ms) : 0, 56760
Remote Config [baseline] (590.482 µs) : 0, 590
Remote Config [candidate] (604.149 µs) : 0, 604
Telemetry [baseline] (7.142 ms) : 0, 7142
Telemetry [candidate] (7.129 ms) : 0, 7129
IAST [baseline] (20.569 ms) : 0, 20569
IAST [candidate] (22.117 ms) : 0, 22117
section profiling
BytebuddyAgent [baseline] (684.938 ms) : 0, 684938
BytebuddyAgent [candidate] (679.117 ms) : 0, 679117
GlobalTracer [baseline] (400.33 ms) : 0, 400330
GlobalTracer [candidate] (396.385 ms) : 0, 396385
AppSec [baseline] (55.181 ms) : 0, 55181
AppSec [candidate] (54.59 ms) : 0, 54590
Remote Config [baseline] (657.909 µs) : 0, 658
Remote Config [candidate] (652.174 µs) : 0, 652
Telemetry [baseline] (11.817 ms) : 0, 11817
Telemetry [candidate] (7.488 ms) : 0, 7488
ProfilingAgent [baseline] (93.116 ms) : 0, 93116
ProfilingAgent [candidate] (96.979 ms) : 0, 96979
Profiling [baseline] (93.14 ms) : 0, 93140
Profiling [candidate] (97.003 ms) : 0, 97003
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (364.852 µs) : 345, 384
. : milestone, 365,
iast (483.623 µs) : 462, 505
. : milestone, 484,
iast_FULL (549.739 µs) : 528, 571
. : milestone, 550,
iast_GLOBAL (502.716 µs) : 481, 525
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (485.33 µs) : 464, 507
. : milestone, 485,
iast_INACTIVE (442.502 µs) : 422, 463
. : milestone, 443,
iast_TELEMETRY_OFF (464.315 µs) : 443, 485
. : milestone, 464,
tracing (442.803 µs) : 422, 463
. : milestone, 443,
section candidate
no_agent (365.476 µs) : 346, 385
. : milestone, 365,
iast (483.144 µs) : 462, 504
. : milestone, 483,
iast_FULL (551.834 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (498.738 µs) : 477, 520
. : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (493.352 µs) : 471, 515
. : milestone, 493,
iast_INACTIVE (443.448 µs) : 423, 464
. : milestone, 443,
iast_TELEMETRY_OFF (474.258 µs) : 452, 496
. : milestone, 474,
tracing (440.757 µs) : 420, 462
. : milestone, 441,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.316 ms) : 1297, 1334
. : milestone, 1316,
appsec (1.724 ms) : 1700, 1749
. : milestone, 1724,
appsec_no_iast (1.718 ms) : 1692, 1743
. : milestone, 1718,
iast (1.49 ms) : 1468, 1513
. : milestone, 1490,
profiling (1.474 ms) : 1450, 1498
. : milestone, 1474,
tracing (1.471 ms) : 1447, 1495
. : milestone, 1471,
section candidate
no_agent (1.347 ms) : 1327, 1366
. : milestone, 1347,
appsec (1.732 ms) : 1709, 1754
. : milestone, 1732,
appsec_no_iast (1.724 ms) : 1699, 1748
. : milestone, 1724,
iast (1.485 ms) : 1462, 1507
. : milestone, 1485,
profiling (1.556 ms) : 1532, 1580
. : milestone, 1556,
tracing (1.486 ms) : 1460, 1512
. : milestone, 1486,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1480
. : milestone, 1468,
appsec (2.333 ms) : 2291, 2374
. : milestone, 2333,
iast (2.07 ms) : 2019, 2121
. : milestone, 2070,
iast_GLOBAL (2.123 ms) : 2070, 2176
. : milestone, 2123,
profiling (1.943 ms) : 1902, 1985
. : milestone, 1943,
tracing (1.927 ms) : 1887, 1967
. : milestone, 1927,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.352 ms) : 2311, 2393
. : milestone, 2352,
iast (2.079 ms) : 2026, 2131
. : milestone, 2079,
iast_GLOBAL (2.122 ms) : 2069, 2174
. : milestone, 2122,
profiling (1.93 ms) : 1889, 1971
. : milestone, 1930,
tracing (1.915 ms) : 1875, 1955
. : milestone, 1915,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c766655939, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.711 s) : 18711000, 18711000
. : milestone, 18711000,
iast_GLOBAL (17.971 s) : 17971000, 17971000
. : milestone, 17971000,
profiling (15.253 s) : 15253000, 15253000
. : milestone, 15253000,
tracing (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
section candidate
no_agent (15.774 s) : 15774000, 15774000
. : milestone, 15774000,
appsec (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
iast (18.7 s) : 18700000, 18700000
. : milestone, 18700000,
iast_GLOBAL (18.119 s) : 18119000, 18119000
. : milestone, 18119000,
profiling (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
tracing (15.191 s) : 15191000, 15191000
. : milestone, 15191000,
|
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7784
branch
October 18, 2024 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #7784
What Does This Do
Fixes automatic configuration of code coverage-enabled packages for headless sessions.
Motivation
"Headless" sessions are those where the build system is not instrumented.
At the moment we support instrumenting Maven and Gradle, so when a Maven or a Gradle build is traced, the tracer is injected into the parent build system process. The list of coverage-enabled packages is computed in the parent process and is then propagated to children.
For headless sessions, where there is no instrumented parent process, the list of packages needs to be computed inside the child process (JVM that runs the tests).
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1130