-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic coverage includes calculation for headless test sessions #7784
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/fix-coverage-includes-for-headless
Oct 18, 2024
Merged
Fix automatic coverage includes calculation for headless test sessions #7784
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/fix-coverage-includes-for-headless
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 17, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081031
Total [baseline] (10.336 s) : 0, 10336076
Agent [candidate] (1.073 s) : 0, 1072900
Total [candidate] (10.431 s) : 0, 10430931
section appsec
Agent [baseline] (1.203 s) : 0, 1202781
Total [baseline] (10.613 s) : 0, 10612663
Agent [candidate] (1.211 s) : 0, 1210955
Total [candidate] (10.605 s) : 0, 10604666
section iast
Agent [baseline] (1.206 s) : 0, 1205581
Total [baseline] (10.847 s) : 0, 10847185
Agent [candidate] (1.202 s) : 0, 1201774
Total [candidate] (10.897 s) : 0, 10897060
section profiling
Agent [baseline] (1.274 s) : 0, 1273977
Total [baseline] (10.647 s) : 0, 10646931
Agent [candidate] (1.284 s) : 0, 1283515
Total [candidate] (10.792 s) : 0, 10792017
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.497 ms) : 0, 688497
BytebuddyAgent [candidate] (683.658 ms) : 0, 683658
GlobalTracer [baseline] (316.124 ms) : 0, 316124
GlobalTracer [candidate] (313.547 ms) : 0, 313547
AppSec [baseline] (54.43 ms) : 0, 54430
AppSec [candidate] (53.873 ms) : 0, 53873
Remote Config [baseline] (673.107 µs) : 0, 673
Remote Config [candidate] (659.321 µs) : 0, 659
Telemetry [baseline] (7.564 ms) : 0, 7564
Telemetry [candidate] (7.488 ms) : 0, 7488
section appsec
BytebuddyAgent [baseline] (698.28 ms) : 0, 698280
BytebuddyAgent [candidate] (702.288 ms) : 0, 702288
GlobalTracer [baseline] (308.985 ms) : 0, 308985
GlobalTracer [candidate] (310.855 ms) : 0, 310855
AppSec [baseline] (161.714 ms) : 0, 161714
AppSec [candidate] (164.193 ms) : 0, 164193
Remote Config [baseline] (634.935 µs) : 0, 635
Remote Config [candidate] (638.015 µs) : 0, 638
Telemetry [baseline] (9.184 ms) : 0, 9184
Telemetry [candidate] (9.149 ms) : 0, 9149
IAST [baseline] (20.775 ms) : 0, 20775
IAST [candidate] (20.269 ms) : 0, 20269
section iast
BytebuddyAgent [baseline] (802.894 ms) : 0, 802894
BytebuddyAgent [candidate] (800.141 ms) : 0, 800141
GlobalTracer [baseline] (303.342 ms) : 0, 303342
GlobalTracer [candidate] (302.056 ms) : 0, 302056
AppSec [baseline] (55.819 ms) : 0, 55819
AppSec [candidate] (56.246 ms) : 0, 56246
Remote Config [baseline] (594.202 µs) : 0, 594
Remote Config [candidate] (603.148 µs) : 0, 603
Telemetry [baseline] (7.065 ms) : 0, 7065
Telemetry [candidate] (7.054 ms) : 0, 7054
IAST [baseline] (22.131 ms) : 0, 22131
IAST [candidate] (21.988 ms) : 0, 21988
section profiling
BytebuddyAgent [baseline] (679.323 ms) : 0, 679323
BytebuddyAgent [candidate] (682.408 ms) : 0, 682408
GlobalTracer [baseline] (396.865 ms) : 0, 396865
GlobalTracer [candidate] (400.654 ms) : 0, 400654
AppSec [baseline] (54.26 ms) : 0, 54260
AppSec [candidate] (55.297 ms) : 0, 55297
Remote Config [baseline] (648.402 µs) : 0, 648
Remote Config [candidate] (655.739 µs) : 0, 656
Telemetry [baseline] (7.452 ms) : 0, 7452
Telemetry [candidate] (7.582 ms) : 0, 7582
ProfilingAgent [baseline] (96.637 ms) : 0, 96637
ProfilingAgent [candidate] (97.994 ms) : 0, 97994
Profiling [baseline] (96.661 ms) : 0, 96661
Profiling [candidate] (98.018 ms) : 0, 98018
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071969
Total [baseline] (8.57 s) : 0, 8569958
Agent [candidate] (1.071 s) : 0, 1071413
Total [candidate] (8.546 s) : 0, 8546027
section iast
Agent [baseline] (1.198 s) : 0, 1197998
Total [baseline] (9.113 s) : 0, 9112960
Agent [candidate] (1.199 s) : 0, 1199369
Total [candidate] (9.098 s) : 0, 9097607
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198756
Total [baseline] (9.046 s) : 0, 9045991
Agent [candidate] (1.201 s) : 0, 1200685
Total [candidate] (9.099 s) : 0, 9098904
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197288
Total [baseline] (9.073 s) : 0, 9073458
Agent [candidate] (1.197 s) : 0, 1196646
Total [candidate] (9.089 s) : 0, 9088577
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.479 ms) : 0, 683479
BytebuddyAgent [candidate] (682.954 ms) : 0, 682954
GlobalTracer [baseline] (312.87 ms) : 0, 312870
GlobalTracer [candidate] (312.851 ms) : 0, 312851
AppSec [baseline] (53.893 ms) : 0, 53893
AppSec [candidate] (53.764 ms) : 0, 53764
Remote Config [baseline] (658.041 µs) : 0, 658
Remote Config [candidate] (669.486 µs) : 0, 669
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.514 ms) : 0, 7514
section iast
BytebuddyAgent [baseline] (798.031 ms) : 0, 798031
BytebuddyAgent [candidate] (798.138 ms) : 0, 798138
GlobalTracer [baseline] (301.37 ms) : 0, 301370
GlobalTracer [candidate] (301.862 ms) : 0, 301862
AppSec [baseline] (54.572 ms) : 0, 54572
AppSec [candidate] (56.044 ms) : 0, 56044
IAST [baseline] (22.675 ms) : 0, 22675
IAST [candidate] (22.013 ms) : 0, 22013
Remote Config [baseline] (602.368 µs) : 0, 602
Remote Config [candidate] (604.885 µs) : 0, 605
Telemetry [baseline] (7.048 ms) : 0, 7048
Telemetry [candidate] (7.039 ms) : 0, 7039
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.447 ms) : 0, 797447
BytebuddyAgent [candidate] (798.049 ms) : 0, 798049
GlobalTracer [baseline] (301.661 ms) : 0, 301661
GlobalTracer [candidate] (301.87 ms) : 0, 301870
AppSec [baseline] (54.819 ms) : 0, 54819
AppSec [candidate] (57.285 ms) : 0, 57285
IAST [baseline] (23.56 ms) : 0, 23560
IAST [candidate] (22.093 ms) : 0, 22093
Remote Config [baseline] (600.321 µs) : 0, 600
Remote Config [candidate] (606.341 µs) : 0, 606
Telemetry [baseline] (7.025 ms) : 0, 7025
Telemetry [candidate] (7.096 ms) : 0, 7096
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.804 ms) : 0, 795804
BytebuddyAgent [candidate] (795.277 ms) : 0, 795277
GlobalTracer [baseline] (302.309 ms) : 0, 302309
GlobalTracer [candidate] (301.833 ms) : 0, 301833
AppSec [baseline] (56.181 ms) : 0, 56181
AppSec [candidate] (54.863 ms) : 0, 54863
IAST [baseline] (21.72 ms) : 0, 21720
IAST [candidate] (23.403 ms) : 0, 23403
Remote Config [baseline] (603.352 µs) : 0, 603
Remote Config [candidate] (616.677 µs) : 0, 617
Telemetry [baseline] (6.962 ms) : 0, 6962
Telemetry [candidate] (6.964 ms) : 0, 6964
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section baseline
no_agent (362.363 µs) : 343, 382
. : milestone, 362,
iast (487.345 µs) : 466, 509
. : milestone, 487,
iast_FULL (546.888 µs) : 526, 568
. : milestone, 547,
iast_GLOBAL (503.948 µs) : 482, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (483.264 µs) : 461, 505
. : milestone, 483,
iast_INACTIVE (445.57 µs) : 424, 467
. : milestone, 446,
iast_TELEMETRY_OFF (470.115 µs) : 448, 492
. : milestone, 470,
tracing (443.057 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (378.763 µs) : 357, 400
. : milestone, 379,
iast (487.719 µs) : 466, 510
. : milestone, 488,
iast_FULL (553.529 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (511.215 µs) : 489, 533
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (483.544 µs) : 462, 505
. : milestone, 484,
iast_INACTIVE (444.385 µs) : 423, 465
. : milestone, 444,
iast_TELEMETRY_OFF (469.912 µs) : 449, 491
. : milestone, 470,
tracing (446.784 µs) : 425, 469
. : milestone, 447,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
. : milestone, 1346,
appsec (1.71 ms) : 1686, 1734
. : milestone, 1710,
appsec_no_iast (1.728 ms) : 1703, 1752
. : milestone, 1728,
iast (1.477 ms) : 1454, 1500
. : milestone, 1477,
profiling (1.538 ms) : 1514, 1563
. : milestone, 1538,
tracing (1.479 ms) : 1455, 1503
. : milestone, 1479,
section candidate
no_agent (1.327 ms) : 1308, 1346
. : milestone, 1327,
appsec (1.708 ms) : 1683, 1733
. : milestone, 1708,
appsec_no_iast (1.723 ms) : 1699, 1747
. : milestone, 1723,
iast (1.473 ms) : 1450, 1496
. : milestone, 1473,
profiling (1.515 ms) : 1490, 1540
. : milestone, 1515,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section baseline
no_agent (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
appsec (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
iast (18.865 s) : 18865000, 18865000
. : milestone, 18865000,
iast_GLOBAL (17.934 s) : 17934000, 17934000
. : milestone, 17934000,
profiling (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
tracing (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
section candidate
no_agent (15.59 s) : 15590000, 15590000
. : milestone, 15590000,
appsec (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
iast (19.145 s) : 19145000, 19145000
. : milestone, 19145000,
iast_GLOBAL (17.864 s) : 17864000, 17864000
. : milestone, 17864000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~2e701d4fbf, baseline=1.41.0-SNAPSHOT~b53b6dc565
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.323 ms) : 2281, 2364
. : milestone, 2323,
iast (2.071 ms) : 2019, 2123
. : milestone, 2071,
iast_GLOBAL (2.113 ms) : 2060, 2165
. : milestone, 2113,
profiling (1.944 ms) : 1901, 1987
. : milestone, 1944,
tracing (1.905 ms) : 1866, 1945
. : milestone, 1905,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.307 ms) : 2266, 2347
. : milestone, 2307,
iast (2.074 ms) : 2022, 2126
. : milestone, 2074,
iast_GLOBAL (2.107 ms) : 2054, 2159
. : milestone, 2107,
profiling (1.927 ms) : 1886, 1968
. : milestone, 1927,
tracing (1.914 ms) : 1873, 1954
. : milestone, 1914,
|
anmarchenko
approved these changes
Oct 18, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/fix-coverage-includes-for-headless
branch
October 18, 2024 09:56
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes automatic configuration of code coverage-enabled packages for headless sessions.
Motivation
"Headless" sessions are those where the build system is not instrumented.
At the moment we support instrumenting Maven and Gradle, so when a Maven or a Gradle build is traced, the tracer is injected into the parent build system process. The list of coverage-enabled packages is computed in the parent process and is then propagated to children.
For headless sessions, where there is no instrumented parent process, the list of packages needs to be computed inside the child process (JVM that runs the tests).
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1130