-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7783] Fix Jacoco coverage exclusion #7808
Merged
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7783
Oct 18, 2024
Merged
[🍒 7783] Fix Jacoco coverage exclusion #7808
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7783
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 18, 2024
juan-fernandez
approved these changes
Oct 18, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078383
Total [baseline] (8.575 s) : 0, 8574931
Agent [candidate] (1.077 s) : 0, 1077303
Total [candidate] (8.599 s) : 0, 8599404
section iast
Agent [baseline] (1.199 s) : 0, 1199470
Total [baseline] (9.109 s) : 0, 9108818
Agent [candidate] (1.205 s) : 0, 1205389
Total [candidate] (9.116 s) : 0, 9115727
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1199917
Total [baseline] (9.078 s) : 0, 9078438
Agent [candidate] (1.198 s) : 0, 1198441
Total [candidate] (9.073 s) : 0, 9072797
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1197972
Total [baseline] (9.076 s) : 0, 9076262
Agent [candidate] (1.203 s) : 0, 1203372
Total [candidate] (9.068 s) : 0, 9067942
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.71 ms) : 0, 685710
BytebuddyAgent [candidate] (686.984 ms) : 0, 686984
GlobalTracer [baseline] (313.681 ms) : 0, 313681
GlobalTracer [candidate] (314.104 ms) : 0, 314104
AppSec [baseline] (53.88 ms) : 0, 53880
AppSec [candidate] (54.183 ms) : 0, 54183
Remote Config [baseline] (666.199 µs) : 0, 666
Remote Config [candidate] (667.155 µs) : 0, 667
Telemetry [baseline] (10.788 ms) : 0, 10788
Telemetry [candidate] (7.588 ms) : 0, 7588
section iast
BytebuddyAgent [baseline] (799.154 ms) : 0, 799154
BytebuddyAgent [candidate] (801.952 ms) : 0, 801952
GlobalTracer [baseline] (301.361 ms) : 0, 301361
GlobalTracer [candidate] (302.941 ms) : 0, 302941
AppSec [baseline] (57.362 ms) : 0, 57362
AppSec [candidate] (56.543 ms) : 0, 56543
IAST [baseline] (20.302 ms) : 0, 20302
IAST [candidate] (22.35 ms) : 0, 22350
Remote Config [baseline] (613.164 µs) : 0, 613
Remote Config [candidate] (622.086 µs) : 0, 622
Telemetry [baseline] (7.039 ms) : 0, 7039
Telemetry [candidate] (7.194 ms) : 0, 7194
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.103 ms) : 0, 799103
BytebuddyAgent [candidate] (797.268 ms) : 0, 797268
GlobalTracer [baseline] (301.831 ms) : 0, 301831
GlobalTracer [candidate] (301.582 ms) : 0, 301582
AppSec [baseline] (56.834 ms) : 0, 56834
AppSec [candidate] (56.255 ms) : 0, 56255
IAST [baseline] (20.893 ms) : 0, 20893
IAST [candidate] (21.969 ms) : 0, 21969
Remote Config [baseline] (581.015 µs) : 0, 581
Remote Config [candidate] (606.236 µs) : 0, 606
Telemetry [baseline] (7.004 ms) : 0, 7004
Telemetry [candidate] (7.054 ms) : 0, 7054
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.129 ms) : 0, 797129
BytebuddyAgent [candidate] (800.143 ms) : 0, 800143
GlobalTracer [baseline] (301.967 ms) : 0, 301967
GlobalTracer [candidate] (303.523 ms) : 0, 303523
AppSec [baseline] (57.966 ms) : 0, 57966
AppSec [candidate] (54.419 ms) : 0, 54419
IAST [baseline] (19.776 ms) : 0, 19776
IAST [candidate] (23.984 ms) : 0, 23984
Remote Config [baseline] (592.462 µs) : 0, 592
Remote Config [candidate] (597.207 µs) : 0, 597
Telemetry [baseline] (6.898 ms) : 0, 6898
Telemetry [candidate] (6.909 ms) : 0, 6909
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082466
Total [baseline] (10.384 s) : 0, 10384222
Agent [candidate] (1.071 s) : 0, 1070604
Total [candidate] (10.357 s) : 0, 10356623
section appsec
Agent [baseline] (1.216 s) : 0, 1215727
Total [baseline] (10.576 s) : 0, 10576328
Agent [candidate] (1.205 s) : 0, 1205298
Total [candidate] (10.622 s) : 0, 10621918
section iast
Agent [baseline] (1.199 s) : 0, 1198773
Total [baseline] (10.777 s) : 0, 10776694
Agent [candidate] (1.215 s) : 0, 1215134
Total [candidate] (10.929 s) : 0, 10929193
section profiling
Agent [baseline] (1.269 s) : 0, 1269159
Total [baseline] (10.668 s) : 0, 10668302
Agent [candidate] (1.269 s) : 0, 1269238
Total [candidate] (10.644 s) : 0, 10644285
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.564 ms) : 0, 690564
BytebuddyAgent [candidate] (682.6 ms) : 0, 682600
GlobalTracer [baseline] (315.311 ms) : 0, 315311
GlobalTracer [candidate] (312.612 ms) : 0, 312612
AppSec [baseline] (53.919 ms) : 0, 53919
AppSec [candidate] (53.613 ms) : 0, 53613
Remote Config [baseline] (670.618 µs) : 0, 671
Remote Config [candidate] (665.665 µs) : 0, 666
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (7.454 ms) : 0, 7454
section appsec
BytebuddyAgent [baseline] (705.598 ms) : 0, 705598
BytebuddyAgent [candidate] (700.466 ms) : 0, 700466
GlobalTracer [baseline] (311.669 ms) : 0, 311669
GlobalTracer [candidate] (309.745 ms) : 0, 309745
AppSec [baseline] (166.937 ms) : 0, 166937
AppSec [candidate] (162.557 ms) : 0, 162557
IAST [baseline] (20.221 ms) : 0, 20221
IAST [candidate] (19.274 ms) : 0, 19274
Remote Config [baseline] (629.235 µs) : 0, 629
Remote Config [candidate] (633.837 µs) : 0, 634
Telemetry [baseline] (7.095 ms) : 0, 7095
Telemetry [candidate] (8.562 ms) : 0, 8562
section iast
BytebuddyAgent [baseline] (798.772 ms) : 0, 798772
BytebuddyAgent [candidate] (810.247 ms) : 0, 810247
GlobalTracer [baseline] (300.929 ms) : 0, 300929
GlobalTracer [candidate] (304.845 ms) : 0, 304845
AppSec [baseline] (57.495 ms) : 0, 57495
AppSec [candidate] (57.533 ms) : 0, 57533
IAST [baseline] (20.342 ms) : 0, 20342
IAST [candidate] (20.817 ms) : 0, 20817
Remote Config [baseline] (607.95 µs) : 0, 608
Remote Config [candidate] (622.352 µs) : 0, 622
Telemetry [baseline] (7.026 ms) : 0, 7026
Telemetry [candidate] (7.223 ms) : 0, 7223
section profiling
BytebuddyAgent [baseline] (678.629 ms) : 0, 678629
BytebuddyAgent [candidate] (676.553 ms) : 0, 676553
GlobalTracer [baseline] (395.02 ms) : 0, 395020
GlobalTracer [candidate] (395.153 ms) : 0, 395153
AppSec [baseline] (54.137 ms) : 0, 54137
AppSec [candidate] (54.331 ms) : 0, 54331
Remote Config [baseline] (654.563 µs) : 0, 655
Remote Config [candidate] (666.706 µs) : 0, 667
Telemetry [baseline] (14.353 ms) : 0, 14353
Telemetry [candidate] (7.431 ms) : 0, 7431
ProfilingAgent [baseline] (87.894 ms) : 0, 87894
ProfilingAgent [candidate] (96.496 ms) : 0, 96496
Profiling [baseline] (87.918 ms) : 0, 87918
Profiling [candidate] (96.519 ms) : 0, 96519
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.335 ms) : 1315, 1354
. : milestone, 1335,
appsec (1.733 ms) : 1710, 1755
. : milestone, 1733,
appsec_no_iast (1.729 ms) : 1705, 1754
. : milestone, 1729,
iast (1.466 ms) : 1443, 1489
. : milestone, 1466,
profiling (1.496 ms) : 1473, 1519
. : milestone, 1496,
tracing (1.448 ms) : 1423, 1473
. : milestone, 1448,
section candidate
no_agent (1.345 ms) : 1325, 1364
. : milestone, 1345,
appsec (1.725 ms) : 1702, 1748
. : milestone, 1725,
appsec_no_iast (1.741 ms) : 1717, 1765
. : milestone, 1741,
iast (1.511 ms) : 1488, 1533
. : milestone, 1511,
profiling (1.531 ms) : 1507, 1556
. : milestone, 1531,
tracing (1.464 ms) : 1439, 1489
. : milestone, 1464,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (373.178 µs) : 353, 393
. : milestone, 373,
iast (493.28 µs) : 471, 515
. : milestone, 493,
iast_FULL (557.237 µs) : 536, 579
. : milestone, 557,
iast_GLOBAL (513.039 µs) : 492, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (491.098 µs) : 469, 513
. : milestone, 491,
iast_INACTIVE (454.577 µs) : 434, 475
. : milestone, 455,
iast_TELEMETRY_OFF (476.063 µs) : 455, 497
. : milestone, 476,
tracing (451.688 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (374.782 µs) : 355, 395
. : milestone, 375,
iast (484.021 µs) : 463, 505
. : milestone, 484,
iast_FULL (560.388 µs) : 539, 582
. : milestone, 560,
iast_GLOBAL (513.847 µs) : 493, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (486.273 µs) : 465, 507
. : milestone, 486,
iast_INACTIVE (451.736 µs) : 430, 473
. : milestone, 452,
iast_TELEMETRY_OFF (476.396 µs) : 455, 498
. : milestone, 476,
tracing (447.375 µs) : 427, 468
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
appsec (15.304 s) : 15304000, 15304000
. : milestone, 15304000,
iast (19.024 s) : 19024000, 19024000
. : milestone, 19024000,
iast_GLOBAL (18.291 s) : 18291000, 18291000
. : milestone, 18291000,
profiling (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
tracing (15.395 s) : 15395000, 15395000
. : milestone, 15395000,
section candidate
no_agent (15.383 s) : 15383000, 15383000
. : milestone, 15383000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.626 s) : 18626000, 18626000
. : milestone, 18626000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
. : milestone, 18110000,
profiling (15.729 s) : 15729000, 15729000
. : milestone, 15729000,
tracing (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~35aeb53e84, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.326 ms) : 2285, 2367
. : milestone, 2326,
iast (2.067 ms) : 2015, 2118
. : milestone, 2067,
iast_GLOBAL (2.116 ms) : 2063, 2168
. : milestone, 2116,
profiling (1.949 ms) : 1907, 1991
. : milestone, 1949,
tracing (1.92 ms) : 1880, 1959
. : milestone, 1920,
section candidate
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.317 ms) : 2276, 2357
. : milestone, 2317,
iast (2.066 ms) : 2015, 2117
. : milestone, 2066,
iast_GLOBAL (2.122 ms) : 2069, 2175
. : milestone, 2122,
profiling (1.952 ms) : 1909, 1995
. : milestone, 1952,
tracing (1.914 ms) : 1874, 1953
. : milestone, 1914,
|
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7783
branch
October 18, 2024 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #7783
What Does This Do
Changes the logic for computing the list of packages included/excluded from Jacoco code coverage.
The old version of the logic checked the list of included packages and filtered out everything that was in the list of excluded packages, and then passed the resulting list of includes to Jacoco plugin.
The new version does two things:
Motivation
Motivation for 1 is simplification.
Motivation for 2 is to decouple ITR code coverage logic from Jacoco coverage logic: a traced project may have pre-configured Jacoco which already have its includes/excludes configured by the user - and these settings may include packages that we're not interested in covering (ITR computes the list of covered packages automatically based on repo index).
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1130