Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jacoco coverage exclusion #7783

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix Jacoco coverage exclusion #7783

merged 1 commit into from
Oct 18, 2024
+101 −71

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Oct 17, 2024 •
edited
Loading

What Does This Do

Changes the logic for computing the list of packages included/excluded from Jacoco code coverage.

The old version of the logic checked the list of included packages and filtered out everything that was in the list of excluded packages, and then passed the resulting list of includes to Jacoco plugin.

The new version does two things:

  1. passes the list of included/excluded packages to Jacoco plugin as is
  2. in the instrumentation that is built on-top of the Jacoco plugin it checks excludes/includes before deciding whether a custom DD coverage probe needs to be inserted.

Motivation

Motivation for 1 is simplification.
Motivation for 2 is to decouple ITR code coverage logic from Jacoco coverage logic: a traced project may have pre-configured Jacoco which already have its includes/excludes configured by the user - and these settings may include packages that we're not interested in covering (ITR computes the list of covered packages automatically based on repo index).

Contributor Checklist

Jira ticket: SDTEST-1130

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Oct 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-coverage-includes
git_commit_date 1729113612 1729162953
git_commit_sha b53b6dc da8d7d2
release_version 1.41.0-SNAPSHOT~b53b6dc565 1.41.0-SNAPSHOT~da8d7d24d9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729165442 1729165442
ci_job_id 675203702 675203702
ci_pipeline_id 46805574 46805574
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072726
Total [baseline] (8.569 s) : 0, 8569347
Agent [candidate] (1.08 s) : 0, 1079812
Total [candidate] (8.565 s) : 0, 8564814
section iast
Agent [baseline] (1.198 s) : 0, 1198312
Total [baseline] (9.119 s) : 0, 9119417
Agent [candidate] (1.208 s) : 0, 1208166
Total [candidate] (9.107 s) : 0, 9106648
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1197213
Total [baseline] (9.066 s) : 0, 9065623
Agent [candidate] (1.201 s) : 0, 1200703
Total [candidate] (9.074 s) : 0, 9073697
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1192996
Total [baseline] (9.091 s) : 0, 9090695
Agent [candidate] (1.204 s) : 0, 1204010
Total [candidate] (9.138 s) : 0, 9138307
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.198 s 125.586 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 124.487 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.193 s 120.27 ms (11.2%)
Total tracing 8.569 s -
Total iast 9.119 s 550.07 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.066 s 496.276 ms (5.8%)
Total iast_TELEMETRY_OFF 9.091 s 521.348 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.208 s 128.354 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 120.89 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.204 s 124.197 ms (11.5%)
Total tracing 8.565 s -
Total iast 9.107 s 541.835 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.074 s 508.883 ms (5.9%)
Total iast_TELEMETRY_OFF 9.138 s 573.493 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.503 ms) : 0, 684503
BytebuddyAgent [candidate] (688.216 ms) : 0, 688216
GlobalTracer [baseline] (312.582 ms) : 0, 312582
GlobalTracer [candidate] (315.308 ms) : 0, 315308
AppSec [baseline] (53.842 ms) : 0, 53842
AppSec [candidate] (54.38 ms) : 0, 54380
Remote Config [baseline] (664.755 µs) : 0, 665
Remote Config [candidate] (671.285 µs) : 0, 671
Telemetry [baseline] (7.467 ms) : 0, 7467
Telemetry [candidate] (7.484 ms) : 0, 7484
section iast
BytebuddyAgent [baseline] (798.12 ms) : 0, 798120
BytebuddyAgent [candidate] (804.112 ms) : 0, 804112
GlobalTracer [baseline] (301.7 ms) : 0, 301700
GlobalTracer [candidate] (303.727 ms) : 0, 303727
AppSec [baseline] (56.838 ms) : 0, 56838
AppSec [candidate] (56.056 ms) : 0, 56056
IAST [baseline] (20.281 ms) : 0, 20281
IAST [candidate] (22.854 ms) : 0, 22854
Remote Config [baseline] (600.318 µs) : 0, 600
Remote Config [candidate] (598.105 µs) : 0, 598
Telemetry [baseline] (7.084 ms) : 0, 7084
Telemetry [candidate] (7.038 ms) : 0, 7038
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.014 ms) : 0, 796014
BytebuddyAgent [candidate] (798.038 ms) : 0, 798038
GlobalTracer [baseline] (301.618 ms) : 0, 301618
GlobalTracer [candidate] (302.833 ms) : 0, 302833
AppSec [baseline] (56.239 ms) : 0, 56239
AppSec [candidate] (55.659 ms) : 0, 55659
IAST [baseline] (22.045 ms) : 0, 22045
IAST [candidate] (22.818 ms) : 0, 22818
Remote Config [baseline] (603.878 µs) : 0, 604
Remote Config [candidate] (601.672 µs) : 0, 602
Telemetry [baseline] (7.055 ms) : 0, 7055
Telemetry [candidate] (7.066 ms) : 0, 7066
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.212 ms) : 0, 793212
BytebuddyAgent [candidate] (800.812 ms) : 0, 800812
GlobalTracer [baseline] (301.188 ms) : 0, 301188
GlobalTracer [candidate] (303.938 ms) : 0, 303938
AppSec [baseline] (55.755 ms) : 0, 55755
AppSec [candidate] (55.751 ms) : 0, 55751
IAST [baseline] (21.642 ms) : 0, 21642
IAST [candidate] (22.264 ms) : 0, 22264
Remote Config [baseline] (605.831 µs) : 0, 606
Remote Config [candidate] (586.319 µs) : 0, 586
Telemetry [baseline] (6.979 ms) : 0, 6979
Telemetry [candidate] (6.913 ms) : 0, 6913
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071021
Total [baseline] (10.461 s) : 0, 10460944
Agent [candidate] (1.094 s) : 0, 1093680
Total [candidate] (10.49 s) : 0, 10490134
section appsec
Agent [baseline] (1.205 s) : 0, 1205270
Total [baseline] (10.579 s) : 0, 10579406
Agent [candidate] (1.209 s) : 0, 1208797
Total [candidate] (10.558 s) : 0, 10557717
section iast
Agent [baseline] (1.209 s) : 0, 1209456
Total [baseline] (10.857 s) : 0, 10856828
Agent [candidate] (1.201 s) : 0, 1200682
Total [candidate] (10.829 s) : 0, 10829452
section profiling
Agent [baseline] (1.275 s) : 0, 1275379
Total [baseline] (10.649 s) : 0, 10649258
Agent [candidate] (1.267 s) : 0, 1267471
Total [candidate] (10.637 s) : 0, 10637430
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.205 s 134.249 ms (12.5%)
Agent iast 1.209 s 138.435 ms (12.9%)
Agent profiling 1.275 s 204.358 ms (19.1%)
Total tracing 10.461 s -
Total appsec 10.579 s 118.462 ms (1.1%)
Total iast 10.857 s 395.884 ms (3.8%)
Total profiling 10.649 s 188.314 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.094 s -
Agent appsec 1.209 s 115.117 ms (10.5%)
Agent iast 1.201 s 107.002 ms (9.8%)
Agent profiling 1.267 s 173.792 ms (15.9%)
Total tracing 10.49 s -
Total appsec 10.558 s 67.583 ms (0.6%)
Total iast 10.829 s 339.319 ms (3.2%)
Total profiling 10.637 s 147.297 ms (1.4%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.768 ms) : 0, 682768
BytebuddyAgent [candidate] (697.903 ms) : 0, 697903
GlobalTracer [baseline] (312.933 ms) : 0, 312933
GlobalTracer [candidate] (318.733 ms) : 0, 318733
AppSec [baseline] (53.567 ms) : 0, 53567
AppSec [candidate] (54.796 ms) : 0, 54796
Remote Config [baseline] (669.375 µs) : 0, 669
Remote Config [candidate] (674.892 µs) : 0, 675
Telemetry [baseline] (7.446 ms) : 0, 7446
Telemetry [candidate] (7.641 ms) : 0, 7641
section appsec
BytebuddyAgent [baseline] (699.319 ms) : 0, 699319
BytebuddyAgent [candidate] (701.963 ms) : 0, 701963
GlobalTracer [baseline] (310.017 ms) : 0, 310017
GlobalTracer [candidate] (310.487 ms) : 0, 310487
AppSec [baseline] (163.881 ms) : 0, 163881
AppSec [candidate] (162.955 ms) : 0, 162955
IAST [baseline] (20.707 ms) : 0, 20707
IAST [candidate] (19.908 ms) : 0, 19908
Remote Config [baseline] (625.462 µs) : 0, 625
Remote Config [candidate] (631.882 µs) : 0, 632
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (9.115 ms) : 0, 9115
section iast
BytebuddyAgent [baseline] (805.542 ms) : 0, 805542
BytebuddyAgent [candidate] (798.848 ms) : 0, 798848
GlobalTracer [baseline] (304.166 ms) : 0, 304166
GlobalTracer [candidate] (302.186 ms) : 0, 302186
AppSec [baseline] (56.883 ms) : 0, 56883
AppSec [candidate] (57.097 ms) : 0, 57097
IAST [baseline] (21.366 ms) : 0, 21366
IAST [candidate] (21.217 ms) : 0, 21217
Remote Config [baseline] (599.96 µs) : 0, 600
Remote Config [candidate] (595.111 µs) : 0, 595
Telemetry [baseline] (7.126 ms) : 0, 7126
Telemetry [candidate] (7.07 ms) : 0, 7070
section profiling
BytebuddyAgent [baseline] (680.477 ms) : 0, 680477
BytebuddyAgent [candidate] (674.841 ms) : 0, 674841
GlobalTracer [baseline] (397.028 ms) : 0, 397028
GlobalTracer [candidate] (395.277 ms) : 0, 395277
AppSec [baseline] (54.43 ms) : 0, 54430
AppSec [candidate] (54.331 ms) : 0, 54331
Remote Config [baseline] (649.122 µs) : 0, 649
Remote Config [candidate] (649.604 µs) : 0, 650
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (7.417 ms) : 0, 7417
ProfilingAgent [baseline] (96.537 ms) : 0, 96537
ProfilingAgent [candidate] (96.401 ms) : 0, 96401
Profiling [baseline] (96.561 ms) : 0, 96561
Profiling [candidate] (96.424 ms) : 0, 96424
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-17T11:14:30 2024-10-17T11:21:23
git_branch master nikita-tkachenko/fix-coverage-includes
git_commit_date 1729113612 1729162953
git_commit_sha b53b6dc da8d7d2
release_version 1.41.0-SNAPSHOT~b53b6dc565 1.41.0-SNAPSHOT~da8d7d24d9
start_time 2024-10-17T11:14:16 2024-10-17T11:21:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729164431 1729164431
ci_job_id 675203703 675203703
ci_pipeline_id 46805574 46805574
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.575 µs) : 356, 395
.   : milestone, 376,
iast (483.196 µs) : 462, 504
.   : milestone, 483,
iast_FULL (552.298 µs) : 531, 574
.   : milestone, 552,
iast_GLOBAL (511.482 µs) : 490, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (479.834 µs) : 458, 501
.   : milestone, 480,
iast_INACTIVE (445.677 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (474.904 µs) : 454, 496
.   : milestone, 475,
tracing (446.765 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (370.464 µs) : 350, 391
.   : milestone, 370,
iast (491.296 µs) : 470, 512
.   : milestone, 491,
iast_FULL (560.075 µs) : 539, 582
.   : milestone, 560,
iast_GLOBAL (510.014 µs) : 488, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (480.898 µs) : 459, 502
.   : milestone, 481,
iast_INACTIVE (450.841 µs) : 429, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (476.375 µs) : 455, 498
.   : milestone, 476,
tracing (450.252 µs) : 430, 471
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.575 µs [355.837 µs, 395.313 µs] -
iast 483.196 µs [462.185 µs, 504.206 µs] 107.621 µs (28.7%)
iast_FULL 552.298 µs [530.922 µs, 573.674 µs] 176.723 µs (47.1%)
iast_GLOBAL 511.482 µs [489.823 µs, 533.142 µs] 135.907 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED 479.834 µs [458.387 µs, 501.282 µs] 104.259 µs (27.8%)
iast_INACTIVE 445.677 µs [425.251 µs, 466.103 µs] 70.102 µs (18.7%)
iast_TELEMETRY_OFF 474.904 µs [453.507 µs, 496.301 µs] 99.329 µs (26.4%)
tracing 446.765 µs [425.676 µs, 467.854 µs] 71.19 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.464 µs [350.237 µs, 390.691 µs] -
iast 491.296 µs [470.195 µs, 512.398 µs] 120.832 µs (32.6%)
iast_FULL 560.075 µs [538.622 µs, 581.527 µs] 189.61 µs (51.2%)
iast_GLOBAL 510.014 µs [488.085 µs, 531.942 µs] 139.549 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 480.898 µs [459.478 µs, 502.319 µs] 110.434 µs (29.8%)
iast_INACTIVE 450.841 µs [429.143 µs, 472.538 µs] 80.376 µs (21.7%)
iast_TELEMETRY_OFF 476.375 µs [454.675 µs, 498.075 µs] 105.911 µs (28.6%)
tracing 450.252 µs [429.607 µs, 470.897 µs] 79.788 µs (21.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1364
.   : milestone, 1346,
appsec (1.749 ms) : 1725, 1773
.   : milestone, 1749,
appsec_no_iast (1.714 ms) : 1689, 1739
.   : milestone, 1714,
iast (1.492 ms) : 1469, 1514
.   : milestone, 1492,
profiling (1.54 ms) : 1515, 1564
.   : milestone, 1540,
tracing (1.476 ms) : 1451, 1501
.   : milestone, 1476,
section candidate
no_agent (1.365 ms) : 1346, 1385
.   : milestone, 1365,
appsec (1.72 ms) : 1695, 1744
.   : milestone, 1720,
appsec_no_iast (1.716 ms) : 1691, 1740
.   : milestone, 1716,
iast (1.483 ms) : 1461, 1505
.   : milestone, 1483,
profiling (1.511 ms) : 1487, 1535
.   : milestone, 1511,
tracing (1.476 ms) : 1453, 1500
.   : milestone, 1476,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.364 ms] -
appsec 1.749 ms [1.725 ms, 1.773 ms] 403.546 µs (30.0%)
appsec_no_iast 1.714 ms [1.689 ms, 1.739 ms] 368.211 µs (27.4%)
iast 1.492 ms [1.469 ms, 1.514 ms] 146.115 µs (10.9%)
profiling 1.54 ms [1.515 ms, 1.564 ms] 193.966 µs (14.4%)
tracing 1.476 ms [1.451 ms, 1.501 ms] 130.661 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.385 ms] -
appsec 1.72 ms [1.695 ms, 1.744 ms] 354.159 µs (25.9%)
appsec_no_iast 1.716 ms [1.691 ms, 1.74 ms] 350.265 µs (25.7%)
iast 1.483 ms [1.461 ms, 1.505 ms] 117.51 µs (8.6%)
profiling 1.511 ms [1.487 ms, 1.535 ms] 145.227 µs (10.6%)
tracing 1.476 ms [1.453 ms, 1.5 ms] 110.998 µs (8.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-coverage-includes
git_commit_date 1729113612 1729162953
git_commit_sha b53b6dc da8d7d2
release_version 1.41.0-SNAPSHOT~b53b6dc565 1.41.0-SNAPSHOT~da8d7d24d9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729164971 1729164971
ci_job_id 675203704 675203704
ci_pipeline_id 46805574 46805574
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.325 ms) : 2284, 2367
.   : milestone, 2325,
iast (2.068 ms) : 2016, 2120
.   : milestone, 2068,
iast_GLOBAL (2.114 ms) : 2062, 2166
.   : milestone, 2114,
profiling (1.946 ms) : 1903, 1989
.   : milestone, 1946,
tracing (1.909 ms) : 1870, 1948
.   : milestone, 1909,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.314 ms) : 2273, 2355
.   : milestone, 2314,
iast (2.065 ms) : 2012, 2117
.   : milestone, 2065,
iast_GLOBAL (2.095 ms) : 2043, 2146
.   : milestone, 2095,
profiling (1.931 ms) : 1890, 1973
.   : milestone, 1931,
tracing (1.912 ms) : 1872, 1952
.   : milestone, 1912,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.325 ms [2.284 ms, 2.367 ms] 864.783 µs (59.2%)
iast 2.068 ms [2.016 ms, 2.12 ms] 607.276 µs (41.6%)
iast_GLOBAL 2.114 ms [2.062 ms, 2.166 ms] 653.595 µs (44.7%)
profiling 1.946 ms [1.903 ms, 1.989 ms] 485.601 µs (33.2%)
tracing 1.909 ms [1.87 ms, 1.948 ms] 448.393 µs (30.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.314 ms [2.273 ms, 2.355 ms] 844.559 µs (57.5%)
iast 2.065 ms [2.012 ms, 2.117 ms] 595.482 µs (40.5%)
iast_GLOBAL 2.095 ms [2.043 ms, 2.146 ms] 625.514 µs (42.6%)
profiling 1.931 ms [1.89 ms, 1.973 ms] 461.912 µs (31.4%)
tracing 1.912 ms [1.872 ms, 1.952 ms] 442.833 µs (30.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~da8d7d24d9, baseline=1.41.0-SNAPSHOT~b53b6dc565
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.739 s) : 15739000, 15739000
.   : milestone, 15739000,
appsec (15.167 s) : 15167000, 15167000
.   : milestone, 15167000,
iast (18.638 s) : 18638000, 18638000
.   : milestone, 18638000,
iast_GLOBAL (17.879 s) : 17879000, 17879000
.   : milestone, 17879000,
profiling (15.08 s) : 15080000, 15080000
.   : milestone, 15080000,
tracing (15.123 s) : 15123000, 15123000
.   : milestone, 15123000,
section candidate
no_agent (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
appsec (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
iast (18.908 s) : 18908000, 18908000
.   : milestone, 18908000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
.   : milestone, 17949000,
profiling (15.814 s) : 15814000, 15814000
.   : milestone, 15814000,
tracing (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.739 s [15.739 s, 15.739 s] -
appsec 15.167 s [15.167 s, 15.167 s] -572.0 ms (-3.6%)
iast 18.638 s [18.638 s, 18.638 s] 2.899 s (18.4%)
iast_GLOBAL 17.879 s [17.879 s, 17.879 s] 2.14 s (13.6%)
profiling 15.08 s [15.08 s, 15.08 s] -659.0 ms (-4.2%)
tracing 15.123 s [15.123 s, 15.123 s] -616.0 ms (-3.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.071 s [15.071 s, 15.071 s] -
appsec 15.126 s [15.126 s, 15.126 s] 55.0 ms (0.4%)
iast 18.908 s [18.908 s, 18.908 s] 3.837 s (25.5%)
iast_GLOBAL 17.949 s [17.949 s, 17.949 s] 2.878 s (19.1%)
profiling 15.814 s [15.814 s, 15.814 s] 743.0 ms (4.9%)
tracing 15.126 s [15.126 s, 15.126 s] 55.0 ms (0.4%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review October 18, 2024 09:10
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit bcf9c26 into master Oct 18, 2024
106 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-coverage-includes branch October 18, 2024 09:55
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 18, 2024
This was referenced Oct 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@romainkomorndatadog romainkomorndatadog Awaiting requested review from romainkomorndatadog romainkomorndatadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @anmarchenko