-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7779] Fix module name detection for headless sessions #7807
Merged
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7779
Oct 18, 2024
Merged
[🍒 7779] Fix module name detection for headless sessions #7807
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7779
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 18, 2024
juan-fernandez
approved these changes
Oct 18, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088965
Total [baseline] (8.595 s) : 0, 8594628
Agent [candidate] (1.078 s) : 0, 1077847
Total [candidate] (8.573 s) : 0, 8572698
section iast
Agent [baseline] (1.201 s) : 0, 1200876
Total [baseline] (9.105 s) : 0, 9104531
Agent [candidate] (1.2 s) : 0, 1199812
Total [candidate] (9.146 s) : 0, 9146013
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1200770
Total [baseline] (9.082 s) : 0, 9082282
Agent [candidate] (1.209 s) : 0, 1209310
Total [candidate] (9.181 s) : 0, 9181422
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1206868
Total [baseline] (9.127 s) : 0, 9127167
Agent [candidate] (1.204 s) : 0, 1204474
Total [candidate] (9.13 s) : 0, 9129590
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.604 ms) : 0, 693604
BytebuddyAgent [candidate] (687.076 ms) : 0, 687076
GlobalTracer [baseline] (316.391 ms) : 0, 316391
GlobalTracer [candidate] (314.402 ms) : 0, 314402
AppSec [baseline] (54.294 ms) : 0, 54294
AppSec [candidate] (54.361 ms) : 0, 54361
Remote Config [baseline] (666.689 µs) : 0, 667
Remote Config [candidate] (669.975 µs) : 0, 670
Telemetry [baseline] (10.198 ms) : 0, 10198
Telemetry [candidate] (7.528 ms) : 0, 7528
section iast
BytebuddyAgent [baseline] (800.926 ms) : 0, 800926
BytebuddyAgent [candidate] (798.039 ms) : 0, 798039
GlobalTracer [baseline] (301.22 ms) : 0, 301220
GlobalTracer [candidate] (302.07 ms) : 0, 302070
AppSec [baseline] (57.187 ms) : 0, 57187
AppSec [candidate] (55.36 ms) : 0, 55360
IAST [baseline] (20.234 ms) : 0, 20234
IAST [candidate] (22.94 ms) : 0, 22940
Remote Config [baseline] (611.587 µs) : 0, 612
Remote Config [candidate] (613.119 µs) : 0, 613
Telemetry [baseline] (7.001 ms) : 0, 7001
Telemetry [candidate] (7.053 ms) : 0, 7053
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.511 ms) : 0, 799511
BytebuddyAgent [candidate] (803.949 ms) : 0, 803949
GlobalTracer [baseline] (302.272 ms) : 0, 302272
GlobalTracer [candidate] (304.354 ms) : 0, 304354
AppSec [baseline] (55.986 ms) : 0, 55986
AppSec [candidate] (56.845 ms) : 0, 56845
IAST [baseline] (21.702 ms) : 0, 21702
IAST [candidate] (22.467 ms) : 0, 22467
Remote Config [baseline] (598.113 µs) : 0, 598
Remote Config [candidate] (626.981 µs) : 0, 627
Telemetry [baseline] (6.994 ms) : 0, 6994
Telemetry [candidate] (7.244 ms) : 0, 7244
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.636 ms) : 0, 803636
BytebuddyAgent [candidate] (801.251 ms) : 0, 801251
GlobalTracer [baseline] (304.287 ms) : 0, 304287
GlobalTracer [candidate] (304.286 ms) : 0, 304286
AppSec [baseline] (57.549 ms) : 0, 57549
AppSec [candidate] (55.911 ms) : 0, 55911
IAST [baseline] (19.991 ms) : 0, 19991
IAST [candidate] (21.603 ms) : 0, 21603
Remote Config [baseline] (615.19 µs) : 0, 615
Remote Config [candidate] (620.267 µs) : 0, 620
Telemetry [baseline] (7.006 ms) : 0, 7006
Telemetry [candidate] (7.027 ms) : 0, 7027
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075355
Total [baseline] (10.437 s) : 0, 10436816
Agent [candidate] (1.073 s) : 0, 1072614
Total [candidate] (10.376 s) : 0, 10376213
section appsec
Agent [baseline] (1.208 s) : 0, 1207634
Total [baseline] (10.627 s) : 0, 10627235
Agent [candidate] (1.21 s) : 0, 1210282
Total [candidate] (10.607 s) : 0, 10606801
section iast
Agent [baseline] (1.202 s) : 0, 1201800
Total [baseline] (10.836 s) : 0, 10836315
Agent [candidate] (1.2 s) : 0, 1200012
Total [candidate] (10.863 s) : 0, 10862761
section profiling
Agent [baseline] (1.274 s) : 0, 1273704
Total [baseline] (10.687 s) : 0, 10686571
Agent [candidate] (1.28 s) : 0, 1280161
Total [candidate] (10.742 s) : 0, 10742357
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.331 ms) : 0, 685331
BytebuddyAgent [candidate] (683.457 ms) : 0, 683457
GlobalTracer [baseline] (313.721 ms) : 0, 313721
GlobalTracer [candidate] (313.53 ms) : 0, 313530
AppSec [baseline] (53.859 ms) : 0, 53859
AppSec [candidate] (53.804 ms) : 0, 53804
Remote Config [baseline] (660.548 µs) : 0, 661
Remote Config [candidate] (686.44 µs) : 0, 686
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (7.455 ms) : 0, 7455
section appsec
BytebuddyAgent [baseline] (701.07 ms) : 0, 701070
BytebuddyAgent [candidate] (702.151 ms) : 0, 702151
GlobalTracer [baseline] (309.866 ms) : 0, 309866
GlobalTracer [candidate] (310.887 ms) : 0, 310887
AppSec [baseline] (163.947 ms) : 0, 163947
AppSec [candidate] (162.42 ms) : 0, 162420
IAST [baseline] (19.346 ms) : 0, 19346
IAST [candidate] (19.916 ms) : 0, 19916
Remote Config [baseline] (635.771 µs) : 0, 636
Remote Config [candidate] (641.809 µs) : 0, 642
Telemetry [baseline] (8.839 ms) : 0, 8839
Telemetry [candidate] (10.516 ms) : 0, 10516
section iast
BytebuddyAgent [baseline] (800.357 ms) : 0, 800357
BytebuddyAgent [candidate] (798.364 ms) : 0, 798364
GlobalTracer [baseline] (302.171 ms) : 0, 302171
GlobalTracer [candidate] (301.918 ms) : 0, 301918
AppSec [baseline] (55.452 ms) : 0, 55452
AppSec [candidate] (54.593 ms) : 0, 54593
IAST [baseline] (22.596 ms) : 0, 22596
IAST [candidate] (22.906 ms) : 0, 22906
Remote Config [baseline] (582.269 µs) : 0, 582
Remote Config [candidate] (601.968 µs) : 0, 602
Telemetry [baseline] (6.976 ms) : 0, 6976
Telemetry [candidate] (7.922 ms) : 0, 7922
section profiling
BytebuddyAgent [baseline] (679.382 ms) : 0, 679382
BytebuddyAgent [candidate] (681.404 ms) : 0, 681404
GlobalTracer [baseline] (396.281 ms) : 0, 396281
GlobalTracer [candidate] (399.578 ms) : 0, 399578
AppSec [baseline] (54.872 ms) : 0, 54872
AppSec [candidate] (54.806 ms) : 0, 54806
Remote Config [baseline] (659.231 µs) : 0, 659
Remote Config [candidate] (662.714 µs) : 0, 663
Telemetry [baseline] (12.295 ms) : 0, 12295
Telemetry [candidate] (7.51 ms) : 0, 7510
ProfilingAgent [baseline] (91.585 ms) : 0, 91585
ProfilingAgent [candidate] (97.221 ms) : 0, 97221
Profiling [baseline] (91.609 ms) : 0, 91609
Profiling [candidate] (97.244 ms) : 0, 97244
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (375.038 µs) : 354, 396
. : milestone, 375,
iast (485.929 µs) : 465, 507
. : milestone, 486,
iast_FULL (556.196 µs) : 535, 577
. : milestone, 556,
iast_GLOBAL (526.104 µs) : 504, 549
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (488.812 µs) : 467, 510
. : milestone, 489,
iast_INACTIVE (446.57 µs) : 426, 467
. : milestone, 447,
iast_TELEMETRY_OFF (474.263 µs) : 453, 495
. : milestone, 474,
tracing (445.874 µs) : 425, 467
. : milestone, 446,
section candidate
no_agent (371.157 µs) : 351, 392
. : milestone, 371,
iast (482.955 µs) : 462, 504
. : milestone, 483,
iast_FULL (558.472 µs) : 537, 580
. : milestone, 558,
iast_GLOBAL (512.28 µs) : 491, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.201 µs) : 463, 505
. : milestone, 484,
iast_INACTIVE (453.526 µs) : 432, 475
. : milestone, 454,
iast_TELEMETRY_OFF (471.906 µs) : 451, 493
. : milestone, 472,
tracing (446.752 µs) : 426, 468
. : milestone, 447,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.328 ms) : 1309, 1347
. : milestone, 1328,
appsec (1.744 ms) : 1720, 1769
. : milestone, 1744,
appsec_no_iast (1.734 ms) : 1711, 1758
. : milestone, 1734,
iast (1.479 ms) : 1457, 1502
. : milestone, 1479,
profiling (1.484 ms) : 1460, 1508
. : milestone, 1484,
tracing (1.455 ms) : 1431, 1479
. : milestone, 1455,
section candidate
no_agent (1.332 ms) : 1313, 1352
. : milestone, 1332,
appsec (1.722 ms) : 1699, 1744
. : milestone, 1722,
appsec_no_iast (1.742 ms) : 1718, 1766
. : milestone, 1742,
iast (1.486 ms) : 1463, 1510
. : milestone, 1486,
profiling (1.479 ms) : 1457, 1502
. : milestone, 1479,
tracing (1.471 ms) : 1446, 1495
. : milestone, 1471,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.308 ms) : 2267, 2349
. : milestone, 2308,
iast (2.062 ms) : 2010, 2114
. : milestone, 2062,
iast_GLOBAL (2.092 ms) : 2040, 2144
. : milestone, 2092,
profiling (1.935 ms) : 1894, 1977
. : milestone, 1935,
tracing (1.906 ms) : 1866, 1945
. : milestone, 1906,
section candidate
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.31 ms) : 2269, 2352
. : milestone, 2310,
iast (2.058 ms) : 2006, 2110
. : milestone, 2058,
iast_GLOBAL (2.114 ms) : 2061, 2167
. : milestone, 2114,
profiling (1.916 ms) : 1875, 1956
. : milestone, 1916,
tracing (1.904 ms) : 1865, 1943
. : milestone, 1904,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~19f44666b2, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
appsec (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
iast (18.572 s) : 18572000, 18572000
. : milestone, 18572000,
iast_GLOBAL (18.011 s) : 18011000, 18011000
. : milestone, 18011000,
profiling (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
section candidate
no_agent (15.384 s) : 15384000, 15384000
. : milestone, 15384000,
appsec (15.18 s) : 15180000, 15180000
. : milestone, 15180000,
iast (18.953 s) : 18953000, 18953000
. : milestone, 18953000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
. : milestone, 17891000,
profiling (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
tracing (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
|
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7779
branch
October 18, 2024 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #7779
What Does This Do
Fixes module name detection for headless test sessions (i.e. sessions for JVMs that are not part of an instrumented Maven/Gradle build).
When a JVM is a part of an instrumented Maven/Gradle build, the parent process provides module names to the children processes via system properties.
For headless sessions the module name is not provided, so there is a fallback that tries to derive module name from current path and repository root (e.g. if repo root is
/my/repo/root
and current path is/my/repo/root/submodule
, then the module name is set tosubmodule
).This fallback logic works incorrectly when repo root is
/my/repo/root
and the current path is/my/repo/root/
: in this case module name is empty, which is not allowed.The fix detects these cases, and uses service name as the last fallback if module name cannot be derived from current path.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1110