Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module name detection for headless sessions #7779

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix module name detection for headless sessions #7779

merged 1 commit into from
Oct 18, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Oct 16, 2024 •
edited by jira bot
Loading

What Does This Do

Fixes module name detection for headless test sessions (i.e. sessions for JVMs that are not part of an instrumented Maven/Gradle build).

When a JVM is a part of an instrumented Maven/Gradle build, the parent process provides module names to the children processes via system properties.
For headless sessions the module name is not provided, so there is a fallback that tries to derive module name from current path and repository root (e.g. if repo root is /my/repo/root and current path is /my/repo/root/submodule, then the module name is set to submodule).
This fallback logic works incorrectly when repo root is /my/repo/root and the current path is /my/repo/root/: in this case module name is empty, which is not allowed.

The fix detects these cases, and uses service name as the last fallback if module name cannot be derived from current path.

Contributor Checklist

Jira ticket: SDTEST-1110

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Oct 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/module-name-fix
git_commit_date 1729088733 1729099885
git_commit_sha 3f89f03 185d67e
release_version 1.41.0-SNAPSHOT~3f89f0321b 1.41.0-SNAPSHOT~185d67e2c7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729102280 1729102280
ci_job_id 674464535 674464535
ci_pipeline_id 46747357 46747357
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071754
Total [baseline] (10.399 s) : 0, 10399273
Agent [candidate] (1.077 s) : 0, 1077066
Total [candidate] (10.383 s) : 0, 10382878
section appsec
Agent [baseline] (1.211 s) : 0, 1210920
Total [baseline] (10.608 s) : 0, 10607616
Agent [candidate] (1.207 s) : 0, 1207389
Total [candidate] (10.631 s) : 0, 10630977
section iast
Agent [baseline] (1.197 s) : 0, 1196513
Total [baseline] (10.871 s) : 0, 10870559
Agent [candidate] (1.207 s) : 0, 1207133
Total [candidate] (10.877 s) : 0, 10877140
section profiling
Agent [baseline] (1.27 s) : 0, 1269611
Total [baseline] (10.752 s) : 0, 10751550
Agent [candidate] (1.27 s) : 0, 1270024
Total [candidate] (10.777 s) : 0, 10777037
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.211 s 139.166 ms (13.0%)
Agent iast 1.197 s 124.759 ms (11.6%)
Agent profiling 1.27 s 197.857 ms (18.5%)
Total tracing 10.399 s -
Total appsec 10.608 s 208.343 ms (2.0%)
Total iast 10.871 s 471.286 ms (4.5%)
Total profiling 10.752 s 352.277 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.207 s 130.323 ms (12.1%)
Agent iast 1.207 s 130.066 ms (12.1%)
Agent profiling 1.27 s 192.957 ms (17.9%)
Total tracing 10.383 s -
Total appsec 10.631 s 248.1 ms (2.4%)
Total iast 10.877 s 494.262 ms (4.8%)
Total profiling 10.777 s 394.16 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.907 ms) : 0, 682907
BytebuddyAgent [candidate] (687.208 ms) : 0, 687208
GlobalTracer [baseline] (313.175 ms) : 0, 313175
GlobalTracer [candidate] (314.294 ms) : 0, 314294
AppSec [baseline] (53.933 ms) : 0, 53933
AppSec [candidate] (53.78 ms) : 0, 53780
Remote Config [baseline] (664.49 µs) : 0, 664
Remote Config [candidate] (651.255 µs) : 0, 651
Telemetry [baseline] (7.457 ms) : 0, 7457
Telemetry [candidate] (7.438 ms) : 0, 7438
section appsec
BytebuddyAgent [baseline] (702.641 ms) : 0, 702641
BytebuddyAgent [candidate] (700.658 ms) : 0, 700658
GlobalTracer [baseline] (310.968 ms) : 0, 310968
GlobalTracer [candidate] (311.373 ms) : 0, 311373
AppSec [baseline] (162.426 ms) : 0, 162426
AppSec [candidate] (163.029 ms) : 0, 163029
Remote Config [baseline] (640.656 µs) : 0, 641
Remote Config [candidate] (645.268 µs) : 0, 645
Telemetry [baseline] (10.396 ms) : 0, 10396
Telemetry [candidate] (7.845 ms) : 0, 7845
IAST [baseline] (20.338 ms) : 0, 20338
IAST [candidate] (20.369 ms) : 0, 20369
section iast
BytebuddyAgent [baseline] (795.874 ms) : 0, 795874
BytebuddyAgent [candidate] (803.788 ms) : 0, 803788
GlobalTracer [baseline] (301.142 ms) : 0, 301142
GlobalTracer [candidate] (303.697 ms) : 0, 303697
AppSec [baseline] (54.604 ms) : 0, 54604
AppSec [candidate] (56.953 ms) : 0, 56953
Remote Config [baseline] (601.963 µs) : 0, 602
Remote Config [candidate] (600.156 µs) : 0, 600
Telemetry [baseline] (7.03 ms) : 0, 7030
Telemetry [candidate] (7.05 ms) : 0, 7050
IAST [baseline] (23.672 ms) : 0, 23672
IAST [candidate] (21.275 ms) : 0, 21275
section profiling
BytebuddyAgent [baseline] (676.156 ms) : 0, 676156
BytebuddyAgent [candidate] (678.517 ms) : 0, 678517
GlobalTracer [baseline] (395.245 ms) : 0, 395245
GlobalTracer [candidate] (394.211 ms) : 0, 394211
AppSec [baseline] (54.87 ms) : 0, 54870
AppSec [candidate] (54.347 ms) : 0, 54347
Remote Config [baseline] (662.536 µs) : 0, 663
Remote Config [candidate] (645.442 µs) : 0, 645
Telemetry [baseline] (7.512 ms) : 0, 7512
Telemetry [candidate] (7.427 ms) : 0, 7427
ProfilingAgent [baseline] (96.58 ms) : 0, 96580
ProfilingAgent [candidate] (96.075 ms) : 0, 96075
Profiling [baseline] (96.604 ms) : 0, 96604
Profiling [candidate] (96.099 ms) : 0, 96099
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075323
Total [baseline] (8.626 s) : 0, 8626244
Agent [candidate] (1.081 s) : 0, 1080620
Total [candidate] (8.613 s) : 0, 8612506
section iast
Agent [baseline] (1.199 s) : 0, 1199051
Total [baseline] (9.164 s) : 0, 9164214
Agent [candidate] (1.206 s) : 0, 1205766
Total [candidate] (9.148 s) : 0, 9148402
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.195 s) : 0, 1195425
Total [baseline] (9.12 s) : 0, 9120090
Agent [candidate] (1.198 s) : 0, 1197749
Total [candidate] (9.106 s) : 0, 9105597
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1194471
Total [baseline] (9.089 s) : 0, 9089000
Agent [candidate] (1.194 s) : 0, 1194311
Total [candidate] (9.078 s) : 0, 9078320
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.199 s 123.728 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 120.102 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.194 s 119.148 ms (11.1%)
Total tracing 8.626 s -
Total iast 9.164 s 537.971 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.12 s 493.847 ms (5.7%)
Total iast_TELEMETRY_OFF 9.089 s 462.756 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.206 s 125.146 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 117.129 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.194 s 113.69 ms (10.5%)
Total tracing 8.613 s -
Total iast 9.148 s 535.896 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.106 s 493.091 ms (5.7%)
Total iast_TELEMETRY_OFF 9.078 s 465.814 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.638 ms) : 0, 683638
BytebuddyAgent [candidate] (690.442 ms) : 0, 690442
GlobalTracer [baseline] (315.618 ms) : 0, 315618
GlobalTracer [candidate] (314.221 ms) : 0, 314221
AppSec [baseline] (54.224 ms) : 0, 54224
AppSec [candidate] (54.043 ms) : 0, 54043
Remote Config [baseline] (669.526 µs) : 0, 670
Remote Config [candidate] (670.332 µs) : 0, 670
Telemetry [baseline] (7.565 ms) : 0, 7565
Telemetry [candidate] (7.482 ms) : 0, 7482
section iast
BytebuddyAgent [baseline] (797.337 ms) : 0, 797337
BytebuddyAgent [candidate] (802.382 ms) : 0, 802382
GlobalTracer [baseline] (301.09 ms) : 0, 301090
GlobalTracer [candidate] (302.888 ms) : 0, 302888
AppSec [baseline] (57.613 ms) : 0, 57613
AppSec [candidate] (56.828 ms) : 0, 56828
IAST [baseline] (21.632 ms) : 0, 21632
IAST [candidate] (21.418 ms) : 0, 21418
Remote Config [baseline] (610.698 µs) : 0, 611
Remote Config [candidate] (603.723 µs) : 0, 604
Telemetry [baseline] (7.133 ms) : 0, 7133
Telemetry [candidate] (7.888 ms) : 0, 7888
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.838 ms) : 0, 794838
BytebuddyAgent [candidate] (796.685 ms) : 0, 796685
GlobalTracer [baseline] (300.989 ms) : 0, 300989
GlobalTracer [candidate] (301.114 ms) : 0, 301114
AppSec [baseline] (57.22 ms) : 0, 57220
AppSec [candidate] (55.74 ms) : 0, 55740
IAST [baseline] (21.168 ms) : 0, 21168
IAST [candidate] (22.846 ms) : 0, 22846
Remote Config [baseline] (594.463 µs) : 0, 594
Remote Config [candidate] (628.622 µs) : 0, 629
Telemetry [baseline] (7.001 ms) : 0, 7001
Telemetry [candidate] (7.071 ms) : 0, 7071
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.022 ms) : 0, 794022
BytebuddyAgent [candidate] (794.277 ms) : 0, 794277
GlobalTracer [baseline] (301.615 ms) : 0, 301615
GlobalTracer [candidate] (301.339 ms) : 0, 301339
AppSec [baseline] (54.846 ms) : 0, 54846
AppSec [candidate] (56.011 ms) : 0, 56011
IAST [baseline] (22.797 ms) : 0, 22797
IAST [candidate] (21.443 ms) : 0, 21443
Remote Config [baseline] (595.099 µs) : 0, 595
Remote Config [candidate] (611.663 µs) : 0, 612
Telemetry [baseline] (6.94 ms) : 0, 6940
Telemetry [candidate] (6.984 ms) : 0, 6984
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-16T17:43:46 2024-10-16T17:50:38
git_branch master nikita-tkachenko/module-name-fix
git_commit_date 1729088733 1729099885
git_commit_sha 3f89f03 185d67e
release_version 1.41.0-SNAPSHOT~3f89f0321b 1.41.0-SNAPSHOT~185d67e2c7
start_time 2024-10-16T17:43:33 2024-10-16T17:50:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729101385 1729101385
ci_job_id 674464536 674464536
ci_pipeline_id 46747357 46747357
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.857 µs) : 355, 394
.   : milestone, 375,
iast (491.622 µs) : 470, 514
.   : milestone, 492,
iast_FULL (559.896 µs) : 539, 581
.   : milestone, 560,
iast_GLOBAL (507.586 µs) : 486, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (487.905 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (461.913 µs) : 441, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (473.811 µs) : 452, 495
.   : milestone, 474,
tracing (449.983 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (375.226 µs) : 354, 396
.   : milestone, 375,
iast (485.164 µs) : 464, 506
.   : milestone, 485,
iast_FULL (558.789 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (508.378 µs) : 487, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (491.059 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (445.098 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (474.803 µs) : 454, 496
.   : milestone, 475,
tracing (448.873 µs) : 428, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.857 µs [355.41 µs, 394.304 µs] -
iast 491.622 µs [469.642 µs, 513.602 µs] 116.765 µs (31.1%)
iast_FULL 559.896 µs [538.612 µs, 581.179 µs] 185.039 µs (49.4%)
iast_GLOBAL 507.586 µs [486.467 µs, 528.706 µs] 132.729 µs (35.4%)
iast_HARDCODED_SECRET_DISABLED 487.905 µs [466.856 µs, 508.953 µs] 113.048 µs (30.2%)
iast_INACTIVE 461.913 µs [440.593 µs, 483.233 µs] 87.056 µs (23.2%)
iast_TELEMETRY_OFF 473.811 µs [452.372 µs, 495.25 µs] 98.954 µs (26.4%)
tracing 449.983 µs [429.194 µs, 470.773 µs] 75.126 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.226 µs [354.221 µs, 396.23 µs] -
iast 485.164 µs [463.956 µs, 506.372 µs] 109.939 µs (29.3%)
iast_FULL 558.789 µs [537.607 µs, 579.971 µs] 183.564 µs (48.9%)
iast_GLOBAL 508.378 µs [487.055 µs, 529.7 µs] 133.152 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 491.059 µs [469.872 µs, 512.246 µs] 115.833 µs (30.9%)
iast_INACTIVE 445.098 µs [424.678 µs, 465.517 µs] 69.872 µs (18.6%)
iast_TELEMETRY_OFF 474.803 µs [453.931 µs, 495.676 µs] 99.578 µs (26.5%)
tracing 448.873 µs [428.003 µs, 469.743 µs] 73.647 µs (19.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.327 ms) : 1308, 1346
.   : milestone, 1327,
appsec (1.711 ms) : 1686, 1736
.   : milestone, 1711,
appsec_no_iast (1.716 ms) : 1691, 1740
.   : milestone, 1716,
iast (1.466 ms) : 1442, 1489
.   : milestone, 1466,
profiling (1.492 ms) : 1469, 1514
.   : milestone, 1492,
tracing (1.493 ms) : 1469, 1517
.   : milestone, 1493,
section candidate
no_agent (1.323 ms) : 1304, 1343
.   : milestone, 1323,
appsec (1.731 ms) : 1706, 1755
.   : milestone, 1731,
appsec_no_iast (1.752 ms) : 1728, 1776
.   : milestone, 1752,
iast (1.477 ms) : 1454, 1499
.   : milestone, 1477,
profiling (1.492 ms) : 1468, 1515
.   : milestone, 1492,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.327 ms [1.308 ms, 1.346 ms] -
appsec 1.711 ms [1.686 ms, 1.736 ms] 384.309 µs (29.0%)
appsec_no_iast 1.716 ms [1.691 ms, 1.74 ms] 389.121 µs (29.3%)
iast 1.466 ms [1.442 ms, 1.489 ms] 138.759 µs (10.5%)
profiling 1.492 ms [1.469 ms, 1.514 ms] 164.921 µs (12.4%)
tracing 1.493 ms [1.469 ms, 1.517 ms] 166.039 µs (12.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.323 ms [1.304 ms, 1.343 ms] -
appsec 1.731 ms [1.706 ms, 1.755 ms] 407.165 µs (30.8%)
appsec_no_iast 1.752 ms [1.728 ms, 1.776 ms] 428.322 µs (32.4%)
iast 1.477 ms [1.454 ms, 1.499 ms] 153.311 µs (11.6%)
profiling 1.492 ms [1.468 ms, 1.515 ms] 168.223 µs (12.7%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 158.473 µs (12.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/module-name-fix
git_commit_date 1729088733 1729099885
git_commit_sha 3f89f03 185d67e
release_version 1.41.0-SNAPSHOT~3f89f0321b 1.41.0-SNAPSHOT~185d67e2c7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729101788 1729101788
ci_job_id 674464537 674464537
ci_pipeline_id 46747357 46747357
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.088 s) : 15088000, 15088000
.   : milestone, 15088000,
appsec (15.223 s) : 15223000, 15223000
.   : milestone, 15223000,
iast (18.772 s) : 18772000, 18772000
.   : milestone, 18772000,
iast_GLOBAL (18.141 s) : 18141000, 18141000
.   : milestone, 18141000,
profiling (15.777 s) : 15777000, 15777000
.   : milestone, 15777000,
tracing (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
section candidate
no_agent (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
appsec (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
iast (19.078 s) : 19078000, 19078000
.   : milestone, 19078000,
iast_GLOBAL (17.587 s) : 17587000, 17587000
.   : milestone, 17587000,
profiling (15.4 s) : 15400000, 15400000
.   : milestone, 15400000,
tracing (15.393 s) : 15393000, 15393000
.   : milestone, 15393000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.088 s [15.088 s, 15.088 s] -
appsec 15.223 s [15.223 s, 15.223 s] 135.0 ms (0.9%)
iast 18.772 s [18.772 s, 18.772 s] 3.684 s (24.4%)
iast_GLOBAL 18.141 s [18.141 s, 18.141 s] 3.053 s (20.2%)
profiling 15.777 s [15.777 s, 15.777 s] 689.0 ms (4.6%)
tracing 15.369 s [15.369 s, 15.369 s] 281.0 ms (1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.946 s [14.946 s, 14.946 s] -
appsec 15.002 s [15.002 s, 15.002 s] 56.0 ms (0.4%)
iast 19.078 s [19.078 s, 19.078 s] 4.132 s (27.6%)
iast_GLOBAL 17.587 s [17.587 s, 17.587 s] 2.641 s (17.7%)
profiling 15.4 s [15.4 s, 15.4 s] 454.0 ms (3.0%)
tracing 15.393 s [15.393 s, 15.393 s] 447.0 ms (3.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~185d67e2c7, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.326 ms) : 2285, 2368
.   : milestone, 2326,
iast (2.082 ms) : 2029, 2135
.   : milestone, 2082,
iast_GLOBAL (2.113 ms) : 2061, 2165
.   : milestone, 2113,
profiling (1.957 ms) : 1913, 2000
.   : milestone, 1957,
tracing (1.919 ms) : 1879, 1959
.   : milestone, 1919,
section candidate
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.337 ms) : 2296, 2379
.   : milestone, 2337,
iast (2.074 ms) : 2022, 2126
.   : milestone, 2074,
iast_GLOBAL (2.119 ms) : 2066, 2171
.   : milestone, 2119,
profiling (1.94 ms) : 1899, 1982
.   : milestone, 1940,
tracing (1.917 ms) : 1877, 1957
.   : milestone, 1917,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.326 ms [2.285 ms, 2.368 ms] 857.018 µs (58.3%)
iast 2.082 ms [2.029 ms, 2.135 ms] 613.162 µs (41.7%)
iast_GLOBAL 2.113 ms [2.061 ms, 2.165 ms] 643.641 µs (43.8%)
profiling 1.957 ms [1.913 ms, 2.0 ms] 487.492 µs (33.2%)
tracing 1.919 ms [1.879 ms, 1.959 ms] 450.032 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.47 ms] -
appsec 2.337 ms [2.296 ms, 2.379 ms] 878.601 µs (60.2%)
iast 2.074 ms [2.022 ms, 2.126 ms] 615.357 µs (42.2%)
iast_GLOBAL 2.119 ms [2.066 ms, 2.171 ms] 659.945 µs (45.2%)
profiling 1.94 ms [1.899 ms, 1.982 ms] 481.489 µs (33.0%)
tracing 1.917 ms [1.877 ms, 1.957 ms] 458.384 µs (31.4%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review October 16, 2024 18:17
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit ff6fd8d into master Oct 18, 2024
106 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/module-name-fix branch October 18, 2024 09:55
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 18, 2024
This was referenced Oct 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @anmarchenko