-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7793] Throw exception when using repo index to resolve source path for classes with identical names #7806
Merged
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7793
Oct 18, 2024
Merged
[🍒 7793] Throw exception when using repo index to resolve source path for classes with identical names #7806
nikita-tkachenko-datadog
merged 1 commit into
release/v1.41.x
from
nikita-tkachenko/backport-pr-7793
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses with identical names
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 18, 2024
nikita-tkachenko-datadog
requested review from
juan-fernandez and
manuel-alvarez-alvarez
October 18, 2024 13:38
juan-fernandez
approved these changes
Oct 18, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 51 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092676
Total [baseline] (8.625 s) : 0, 8624503
Agent [candidate] (1.081 s) : 0, 1081086
Total [candidate] (8.626 s) : 0, 8625813
section iast
Agent [baseline] (1.218 s) : 0, 1217908
Total [baseline] (9.159 s) : 0, 9158776
Agent [candidate] (1.202 s) : 0, 1202419
Total [candidate] (9.118 s) : 0, 9117646
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1205084
Total [baseline] (9.117 s) : 0, 9117165
Agent [candidate] (1.203 s) : 0, 1203209
Total [candidate] (9.088 s) : 0, 9087590
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1207519
Total [baseline] (9.143 s) : 0, 9143273
Agent [candidate] (1.198 s) : 0, 1197641
Total [candidate] (9.115 s) : 0, 9115448
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.946 ms) : 0, 696946
BytebuddyAgent [candidate] (689.282 ms) : 0, 689282
GlobalTracer [baseline] (316.968 ms) : 0, 316968
GlobalTracer [candidate] (315.256 ms) : 0, 315256
AppSec [baseline] (54.457 ms) : 0, 54457
AppSec [candidate] (54.437 ms) : 0, 54437
Remote Config [baseline] (679.131 µs) : 0, 679
Remote Config [candidate] (671.1 µs) : 0, 671
Telemetry [baseline] (9.668 ms) : 0, 9668
Telemetry [candidate] (7.562 ms) : 0, 7562
section iast
BytebuddyAgent [baseline] (813.014 ms) : 0, 813014
BytebuddyAgent [candidate] (799.956 ms) : 0, 799956
GlobalTracer [baseline] (304.476 ms) : 0, 304476
GlobalTracer [candidate] (302.516 ms) : 0, 302516
AppSec [baseline] (57.436 ms) : 0, 57436
AppSec [candidate] (56.214 ms) : 0, 56214
IAST [baseline] (21.27 ms) : 0, 21270
IAST [candidate] (22.194 ms) : 0, 22194
Remote Config [baseline] (632.999 µs) : 0, 633
Remote Config [candidate] (613.821 µs) : 0, 614
Telemetry [baseline] (7.142 ms) : 0, 7142
Telemetry [candidate] (7.109 ms) : 0, 7109
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.401 ms) : 0, 801401
BytebuddyAgent [candidate] (799.754 ms) : 0, 799754
GlobalTracer [baseline] (302.734 ms) : 0, 302734
GlobalTracer [candidate] (303.452 ms) : 0, 303452
AppSec [baseline] (58.538 ms) : 0, 58538
AppSec [candidate] (56.438 ms) : 0, 56438
IAST [baseline] (20.777 ms) : 0, 20777
IAST [candidate] (22.033 ms) : 0, 22033
Remote Config [baseline] (618.843 µs) : 0, 619
Remote Config [candidate] (609.61 µs) : 0, 610
Telemetry [baseline] (7.233 ms) : 0, 7233
Telemetry [candidate] (7.101 ms) : 0, 7101
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.051 ms) : 0, 804051
BytebuddyAgent [candidate] (795.515 ms) : 0, 795515
GlobalTracer [baseline] (304.019 ms) : 0, 304019
GlobalTracer [candidate] (302.334 ms) : 0, 302334
AppSec [baseline] (58.044 ms) : 0, 58044
AppSec [candidate] (55.811 ms) : 0, 55811
IAST [baseline] (19.955 ms) : 0, 19955
IAST [candidate] (22.603 ms) : 0, 22603
Remote Config [baseline] (607.349 µs) : 0, 607
Remote Config [candidate] (611.785 µs) : 0, 612
Telemetry [baseline] (6.997 ms) : 0, 6997
Telemetry [candidate] (6.977 ms) : 0, 6977
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081012
Total [baseline] (10.378 s) : 0, 10377599
Agent [candidate] (1.082 s) : 0, 1081843
Total [candidate] (10.457 s) : 0, 10457101
section appsec
Agent [baseline] (1.216 s) : 0, 1215776
Total [baseline] (10.619 s) : 0, 10619213
Agent [candidate] (1.21 s) : 0, 1210318
Total [candidate] (10.65 s) : 0, 10649682
section iast
Agent [baseline] (1.205 s) : 0, 1204992
Total [baseline] (10.891 s) : 0, 10890792
Agent [candidate] (1.208 s) : 0, 1207806
Total [candidate] (10.894 s) : 0, 10894359
section profiling
Agent [baseline] (1.276 s) : 0, 1276129
Total [baseline] (10.754 s) : 0, 10754099
Agent [candidate] (1.279 s) : 0, 1278780
Total [candidate] (10.717 s) : 0, 10717087
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.192 ms) : 0, 687192
BytebuddyAgent [candidate] (689.091 ms) : 0, 689091
GlobalTracer [baseline] (314.41 ms) : 0, 314410
GlobalTracer [candidate] (316.271 ms) : 0, 316271
AppSec [baseline] (54.022 ms) : 0, 54022
AppSec [candidate] (54.424 ms) : 0, 54424
Remote Config [baseline] (664.363 µs) : 0, 664
Remote Config [candidate] (678.232 µs) : 0, 678
Telemetry [baseline] (10.975 ms) : 0, 10975
Telemetry [candidate] (7.503 ms) : 0, 7503
section appsec
BytebuddyAgent [baseline] (705.744 ms) : 0, 705744
BytebuddyAgent [candidate] (701.7 ms) : 0, 701700
GlobalTracer [baseline] (311.315 ms) : 0, 311315
GlobalTracer [candidate] (310.667 ms) : 0, 310667
AppSec [baseline] (166.469 ms) : 0, 166469
AppSec [candidate] (162.809 ms) : 0, 162809
Remote Config [baseline] (628.022 µs) : 0, 628
Remote Config [candidate] (638.299 µs) : 0, 638
Telemetry [baseline] (7.428 ms) : 0, 7428
Telemetry [candidate] (10.315 ms) : 0, 10315
IAST [baseline] (20.809 ms) : 0, 20809
IAST [candidate] (20.819 ms) : 0, 20819
section iast
BytebuddyAgent [baseline] (802.245 ms) : 0, 802245
BytebuddyAgent [candidate] (804.836 ms) : 0, 804836
GlobalTracer [baseline] (303.096 ms) : 0, 303096
GlobalTracer [candidate] (302.871 ms) : 0, 302871
AppSec [baseline] (57.057 ms) : 0, 57057
AppSec [candidate] (56.267 ms) : 0, 56267
Remote Config [baseline] (595.204 µs) : 0, 595
Remote Config [candidate] (602.916 µs) : 0, 603
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.069 ms) : 0, 7069
IAST [baseline] (20.313 ms) : 0, 20313
IAST [candidate] (22.234 ms) : 0, 22234
section profiling
BytebuddyAgent [baseline] (680.725 ms) : 0, 680725
BytebuddyAgent [candidate] (678.72 ms) : 0, 678720
GlobalTracer [baseline] (397.864 ms) : 0, 397864
GlobalTracer [candidate] (400.389 ms) : 0, 400389
AppSec [baseline] (54.591 ms) : 0, 54591
AppSec [candidate] (54.961 ms) : 0, 54961
Remote Config [baseline] (653.928 µs) : 0, 654
Remote Config [candidate] (657.562 µs) : 0, 658
Telemetry [baseline] (12.949 ms) : 0, 12949
Telemetry [candidate] (7.524 ms) : 0, 7524
ProfilingAgent [baseline] (90.511 ms) : 0, 90511
ProfilingAgent [candidate] (97.636 ms) : 0, 97636
Profiling [baseline] (90.534 ms) : 0, 90534
Profiling [candidate] (97.662 ms) : 0, 97662
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (367.351 µs) : 348, 387
. : milestone, 367,
iast (480.957 µs) : 460, 502
. : milestone, 481,
iast_FULL (553.535 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (504.025 µs) : 483, 525
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (485.08 µs) : 464, 507
. : milestone, 485,
iast_INACTIVE (450.187 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (475.535 µs) : 454, 497
. : milestone, 476,
tracing (450.413 µs) : 430, 471
. : milestone, 450,
section candidate
no_agent (375.052 µs) : 354, 396
. : milestone, 375,
iast (488.334 µs) : 467, 510
. : milestone, 488,
iast_FULL (553.309 µs) : 532, 575
. : milestone, 553,
iast_GLOBAL (510.959 µs) : 489, 533
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (500.37 µs) : 477, 524
. : milestone, 500,
iast_INACTIVE (448.75 µs) : 428, 469
. : milestone, 449,
iast_TELEMETRY_OFF (473.043 µs) : 452, 494
. : milestone, 473,
tracing (451.122 µs) : 430, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1371
. : milestone, 1352,
appsec (1.742 ms) : 1718, 1767
. : milestone, 1742,
appsec_no_iast (1.72 ms) : 1696, 1744
. : milestone, 1720,
iast (1.482 ms) : 1459, 1505
. : milestone, 1482,
profiling (1.493 ms) : 1470, 1515
. : milestone, 1493,
tracing (1.461 ms) : 1437, 1485
. : milestone, 1461,
section candidate
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.746 ms) : 1722, 1770
. : milestone, 1746,
appsec_no_iast (1.731 ms) : 1707, 1755
. : milestone, 1731,
iast (1.489 ms) : 1466, 1511
. : milestone, 1489,
profiling (1.489 ms) : 1465, 1514
. : milestone, 1489,
tracing (1.462 ms) : 1437, 1487
. : milestone, 1462,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.349 ms) : 2307, 2390
. : milestone, 2349,
iast (2.064 ms) : 2013, 2115
. : milestone, 2064,
iast_GLOBAL (2.13 ms) : 2077, 2183
. : milestone, 2130,
profiling (1.936 ms) : 1895, 1977
. : milestone, 1936,
tracing (1.917 ms) : 1878, 1956
. : milestone, 1917,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.356 ms) : 2315, 2398
. : milestone, 2356,
iast (2.097 ms) : 2045, 2150
. : milestone, 2097,
iast_GLOBAL (2.135 ms) : 2082, 2188
. : milestone, 2135,
profiling (1.971 ms) : 1928, 2014
. : milestone, 1971,
tracing (1.919 ms) : 1879, 1958
. : milestone, 1919,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~00856e02d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.427 s) : 15427000, 15427000
. : milestone, 15427000,
appsec (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
iast (19.096 s) : 19096000, 19096000
. : milestone, 19096000,
iast_GLOBAL (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
profiling (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
tracing (15.321 s) : 15321000, 15321000
. : milestone, 15321000,
section candidate
no_agent (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
appsec (15.135 s) : 15135000, 15135000
. : milestone, 15135000,
iast (19.097 s) : 19097000, 19097000
. : milestone, 19097000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
. : milestone, 17928000,
profiling (15.156 s) : 15156000, 15156000
. : milestone, 15156000,
tracing (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
|
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7793
branch
October 18, 2024 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #7793
What Does This Do
Updates repo indexing logic: the logic now stores the list of classes whose path relative to source root is the same (e.g.
src/java/main/my/package/MyClass.java
andsrc/java9/main/my/package/MyClass.java
).When a source path lookup is performed with the repo index, if the class if one of those "duplicates", an exception will be thrown to indicate that we cannot reliably detect the source path for this class.
Motivation
The motivation is to skip code coverage report creation and submission for test cases that cover such classes.
The idea is that since we cannot reliably detect all the source paths, we do not want ITR to skip these test cases, which is why we will not be submitting code coverage reports for them.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1130