-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw exception when using repo index to resolve source path for classes with identical names #7793
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/repo-index-duplicates-check
Oct 18, 2024
Merged
Throw exception when using repo index to resolve source path for classes with identical names #7793
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/repo-index-duplicates-check
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses with identical names
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 17, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075943
Total [baseline] (10.363 s) : 0, 10362518
Agent [candidate] (1.084 s) : 0, 1083914
Total [candidate] (10.346 s) : 0, 10345849
section appsec
Agent [baseline] (1.215 s) : 0, 1214943
Total [baseline] (10.591 s) : 0, 10590972
Agent [candidate] (1.21 s) : 0, 1210078
Total [candidate] (10.581 s) : 0, 10581201
section iast
Agent [baseline] (1.203 s) : 0, 1202591
Total [baseline] (10.926 s) : 0, 10926377
Agent [candidate] (1.214 s) : 0, 1213745
Total [candidate] (10.867 s) : 0, 10867464
section profiling
Agent [baseline] (1.274 s) : 0, 1273926
Total [baseline] (10.682 s) : 0, 10681787
Agent [candidate] (1.271 s) : 0, 1271441
Total [candidate] (10.725 s) : 0, 10724965
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.464 ms) : 0, 685464
BytebuddyAgent [candidate] (689.821 ms) : 0, 689821
GlobalTracer [baseline] (312.677 ms) : 0, 312677
GlobalTracer [candidate] (314.884 ms) : 0, 314884
AppSec [baseline] (53.937 ms) : 0, 53937
AppSec [candidate] (53.955 ms) : 0, 53955
Remote Config [baseline] (670.944 µs) : 0, 671
Remote Config [candidate] (662.56 µs) : 0, 663
Telemetry [baseline] (9.567 ms) : 0, 9567
Telemetry [candidate] (10.858 ms) : 0, 10858
section appsec
BytebuddyAgent [baseline] (705.4 ms) : 0, 705400
BytebuddyAgent [candidate] (702.525 ms) : 0, 702525
GlobalTracer [baseline] (311.272 ms) : 0, 311272
GlobalTracer [candidate] (310.117 ms) : 0, 310117
AppSec [baseline] (165.582 ms) : 0, 165582
AppSec [candidate] (165.697 ms) : 0, 165697
IAST [baseline] (21.083 ms) : 0, 21083
IAST [candidate] (20.742 ms) : 0, 20742
Remote Config [baseline] (640.586 µs) : 0, 641
Remote Config [candidate] (640.717 µs) : 0, 641
Telemetry [baseline] (7.83 ms) : 0, 7830
Telemetry [candidate] (7.078 ms) : 0, 7078
section iast
BytebuddyAgent [baseline] (801.161 ms) : 0, 801161
BytebuddyAgent [candidate] (809.003 ms) : 0, 809003
GlobalTracer [baseline] (302.05 ms) : 0, 302050
GlobalTracer [candidate] (304.819 ms) : 0, 304819
AppSec [baseline] (57.803 ms) : 0, 57803
AppSec [candidate] (57.987 ms) : 0, 57987
IAST [baseline] (20.267 ms) : 0, 20267
IAST [candidate] (20.443 ms) : 0, 20443
Remote Config [baseline] (590.445 µs) : 0, 590
Remote Config [candidate] (604.205 µs) : 0, 604
Telemetry [baseline] (7.063 ms) : 0, 7063
Telemetry [candidate] (7.112 ms) : 0, 7112
section profiling
BytebuddyAgent [baseline] (679.871 ms) : 0, 679871
BytebuddyAgent [candidate] (678.479 ms) : 0, 678479
GlobalTracer [baseline] (396.39 ms) : 0, 396390
GlobalTracer [candidate] (395.509 ms) : 0, 395509
AppSec [baseline] (54.329 ms) : 0, 54329
AppSec [candidate] (54.622 ms) : 0, 54622
Remote Config [baseline] (646.899 µs) : 0, 647
Remote Config [candidate] (644.71 µs) : 0, 645
Telemetry [baseline] (13.784 ms) : 0, 13784
Telemetry [candidate] (12.977 ms) : 0, 12977
ProfilingAgent [baseline] (90.196 ms) : 0, 90196
ProfilingAgent [candidate] (90.488 ms) : 0, 90488
Profiling [baseline] (90.22 ms) : 0, 90220
Profiling [candidate] (90.511 ms) : 0, 90511
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081214
Total [baseline] (8.589 s) : 0, 8589179
Agent [candidate] (1.074 s) : 0, 1074297
Total [candidate] (8.556 s) : 0, 8555790
section iast
Agent [baseline] (1.203 s) : 0, 1203276
Total [baseline] (9.128 s) : 0, 9127568
Agent [candidate] (1.199 s) : 0, 1199291
Total [candidate] (9.117 s) : 0, 9116881
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1200728
Total [baseline] (9.081 s) : 0, 9081451
Agent [candidate] (1.205 s) : 0, 1204557
Total [candidate] (9.102 s) : 0, 9101590
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1204508
Total [baseline] (9.125 s) : 0, 9125154
Agent [candidate] (1.198 s) : 0, 1198311
Total [candidate] (9.105 s) : 0, 9105144
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.538 ms) : 0, 689538
BytebuddyAgent [candidate] (684.193 ms) : 0, 684193
GlobalTracer [baseline] (314.2 ms) : 0, 314200
GlobalTracer [candidate] (312.746 ms) : 0, 312746
AppSec [baseline] (54.237 ms) : 0, 54237
AppSec [candidate] (53.48 ms) : 0, 53480
Remote Config [baseline] (669.503 µs) : 0, 670
Remote Config [candidate] (660.731 µs) : 0, 661
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (9.608 ms) : 0, 9608
section iast
BytebuddyAgent [baseline] (801.119 ms) : 0, 801119
BytebuddyAgent [candidate] (798.488 ms) : 0, 798488
GlobalTracer [baseline] (302.681 ms) : 0, 302681
GlobalTracer [candidate] (302.138 ms) : 0, 302138
AppSec [baseline] (58.116 ms) : 0, 58116
AppSec [candidate] (57.31 ms) : 0, 57310
IAST [baseline] (20.074 ms) : 0, 20074
IAST [candidate] (20.149 ms) : 0, 20149
Remote Config [baseline] (602.156 µs) : 0, 602
Remote Config [candidate] (601.358 µs) : 0, 601
Telemetry [baseline] (7.028 ms) : 0, 7028
Telemetry [candidate] (6.968 ms) : 0, 6968
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.966 ms) : 0, 799966
BytebuddyAgent [candidate] (801.765 ms) : 0, 801765
GlobalTracer [baseline] (301.825 ms) : 0, 301825
GlobalTracer [candidate] (303.031 ms) : 0, 303031
AppSec [baseline] (55.952 ms) : 0, 55952
AppSec [candidate] (57.258 ms) : 0, 57258
IAST [baseline] (21.766 ms) : 0, 21766
IAST [candidate] (21.086 ms) : 0, 21086
Remote Config [baseline] (582.647 µs) : 0, 583
Remote Config [candidate] (606.696 µs) : 0, 607
Telemetry [baseline] (6.987 ms) : 0, 6987
Telemetry [candidate] (7.137 ms) : 0, 7137
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.042 ms) : 0, 802042
BytebuddyAgent [candidate] (797.207 ms) : 0, 797207
GlobalTracer [baseline] (303.86 ms) : 0, 303860
GlobalTracer [candidate] (302.156 ms) : 0, 302156
AppSec [baseline] (56.462 ms) : 0, 56462
AppSec [candidate] (54.556 ms) : 0, 54556
IAST [baseline] (20.802 ms) : 0, 20802
IAST [candidate] (22.382 ms) : 0, 22382
Remote Config [baseline] (604.39 µs) : 0, 604
Remote Config [candidate] (586.259 µs) : 0, 586
Telemetry [baseline] (7.013 ms) : 0, 7013
Telemetry [candidate] (7.781 ms) : 0, 7781
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section baseline
no_agent (372.141 µs) : 353, 392
. : milestone, 372,
iast (483.973 µs) : 463, 505
. : milestone, 484,
iast_FULL (551.587 µs) : 530, 573
. : milestone, 552,
iast_GLOBAL (502.598 µs) : 482, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (494.57 µs) : 472, 517
. : milestone, 495,
iast_INACTIVE (448.267 µs) : 427, 470
. : milestone, 448,
iast_TELEMETRY_OFF (474.488 µs) : 453, 496
. : milestone, 474,
tracing (445.481 µs) : 424, 467
. : milestone, 445,
section candidate
no_agent (367.808 µs) : 348, 388
. : milestone, 368,
iast (480.329 µs) : 459, 501
. : milestone, 480,
iast_FULL (557.025 µs) : 535, 579
. : milestone, 557,
iast_GLOBAL (503.421 µs) : 482, 525
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (484.964 µs) : 464, 506
. : milestone, 485,
iast_INACTIVE (444.2 µs) : 423, 466
. : milestone, 444,
iast_TELEMETRY_OFF (477.819 µs) : 456, 500
. : milestone, 478,
tracing (439.844 µs) : 420, 460
. : milestone, 440,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section baseline
no_agent (1.33 ms) : 1310, 1349
. : milestone, 1330,
appsec (1.711 ms) : 1688, 1734
. : milestone, 1711,
appsec_no_iast (1.728 ms) : 1704, 1752
. : milestone, 1728,
iast (1.48 ms) : 1458, 1502
. : milestone, 1480,
profiling (1.472 ms) : 1449, 1494
. : milestone, 1472,
tracing (1.451 ms) : 1426, 1475
. : milestone, 1451,
section candidate
no_agent (1.339 ms) : 1320, 1359
. : milestone, 1339,
appsec (1.708 ms) : 1685, 1732
. : milestone, 1708,
appsec_no_iast (1.722 ms) : 1697, 1746
. : milestone, 1722,
iast (1.479 ms) : 1455, 1502
. : milestone, 1479,
profiling (1.517 ms) : 1490, 1543
. : milestone, 1517,
tracing (1.463 ms) : 1438, 1488
. : milestone, 1463,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1466
. : milestone, 1455,
appsec (2.299 ms) : 2258, 2340
. : milestone, 2299,
iast (2.063 ms) : 2011, 2115
. : milestone, 2063,
iast_GLOBAL (2.108 ms) : 2055, 2160
. : milestone, 2108,
profiling (1.923 ms) : 1882, 1964
. : milestone, 1923,
tracing (1.91 ms) : 1871, 1950
. : milestone, 1910,
section candidate
no_agent (1.461 ms) : 1449, 1472
. : milestone, 1461,
appsec (2.316 ms) : 2275, 2358
. : milestone, 2316,
iast (2.053 ms) : 2002, 2104
. : milestone, 2053,
iast_GLOBAL (2.099 ms) : 2047, 2151
. : milestone, 2099,
profiling (1.922 ms) : 1882, 1963
. : milestone, 1922,
tracing (1.909 ms) : 1869, 1949
. : milestone, 1909,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~307dd9292d, baseline=1.42.0-SNAPSHOT~666f2afac1
dateFormat X
axisFormat %s
section baseline
no_agent (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
appsec (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
iast (18.884 s) : 18884000, 18884000
. : milestone, 18884000,
iast_GLOBAL (17.945 s) : 17945000, 17945000
. : milestone, 17945000,
profiling (15.732 s) : 15732000, 15732000
. : milestone, 15732000,
tracing (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
section candidate
no_agent (15.117 s) : 15117000, 15117000
. : milestone, 15117000,
appsec (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
iast (18.887 s) : 18887000, 18887000
. : milestone, 18887000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (15.764 s) : 15764000, 15764000
. : milestone, 15764000,
tracing (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
|
nikita-tkachenko-datadog
requested review from
juan-fernandez and
manuel-alvarez-alvarez
October 18, 2024 09:13
anmarchenko
approved these changes
Oct 18, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/repo-index-duplicates-check
branch
October 18, 2024 09:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates repo indexing logic: the logic now stores the list of classes whose path relative to source root is the same (e.g.
src/java/main/my/package/MyClass.java
andsrc/java9/main/my/package/MyClass.java
).When a source path lookup is performed with the repo index, if the class if one of those "duplicates", an exception will be thrown to indicate that we cannot reliably detect the source path for this class.
Motivation
The motivation is to skip code coverage report creation and submission for test cases that cover such classes.
The idea is that since we cannot reliably detect all the source paths, we do not want ITR to skip these test cases, which is why we will not be submitting code coverage reports for them.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1130