-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7736] Update bundled Jacoco version #7769
Merged
nikita-tkachenko-datadog
merged 1 commit into
release/v1.40.x
from
nikita-tkachenko/backport-pr-7736
Oct 16, 2024
Merged
[🍒 7736] Update bundled Jacoco version #7769
nikita-tkachenko-datadog
merged 1 commit into
release/v1.40.x
from
nikita-tkachenko/backport-pr-7736
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
the
comp: ci visibility
Continuous Integration Visibility
label
Oct 16, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 8 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083141
Total [baseline] (8.606 s) : 0, 8605807
Agent [candidate] (1.079 s) : 0, 1078908
Total [candidate] (8.573 s) : 0, 8572958
section iast
Agent [baseline] (1.203 s) : 0, 1202859
Total [baseline] (9.099 s) : 0, 9099001
Agent [candidate] (1.198 s) : 0, 1197695
Total [candidate] (9.109 s) : 0, 9109319
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1201180
Total [baseline] (9.113 s) : 0, 9112755
Agent [candidate] (1.207 s) : 0, 1207226
Total [candidate] (9.152 s) : 0, 9152087
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1202968
Total [baseline] (9.084 s) : 0, 9084363
Agent [candidate] (1.215 s) : 0, 1215218
Total [candidate] (9.157 s) : 0, 9156570
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.189 ms) : 0, 690189
BytebuddyAgent [candidate] (688.702 ms) : 0, 688702
GlobalTracer [baseline] (316.173 ms) : 0, 316173
GlobalTracer [candidate] (313.524 ms) : 0, 313524
AppSec [baseline] (54.69 ms) : 0, 54690
AppSec [candidate] (54.464 ms) : 0, 54464
Remote Config [baseline] (666.011 µs) : 0, 666
Remote Config [candidate] (671.933 µs) : 0, 672
Telemetry [baseline] (7.564 ms) : 0, 7564
Telemetry [candidate] (7.68 ms) : 0, 7680
section iast
BytebuddyAgent [baseline] (800.158 ms) : 0, 800158
BytebuddyAgent [candidate] (797.706 ms) : 0, 797706
GlobalTracer [baseline] (302.318 ms) : 0, 302318
GlobalTracer [candidate] (300.359 ms) : 0, 300359
AppSec [baseline] (56.71 ms) : 0, 56710
AppSec [candidate] (54.602 ms) : 0, 54602
IAST [baseline] (22.144 ms) : 0, 22144
IAST [candidate] (23.493 ms) : 0, 23493
Remote Config [baseline] (612.162 µs) : 0, 612
Remote Config [candidate] (630.308 µs) : 0, 630
Telemetry [baseline] (7.1 ms) : 0, 7100
Telemetry [candidate] (7.05 ms) : 0, 7050
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.514 ms) : 0, 798514
BytebuddyAgent [candidate] (803.647 ms) : 0, 803647
GlobalTracer [baseline] (302.253 ms) : 0, 302253
GlobalTracer [candidate] (302.968 ms) : 0, 302968
AppSec [baseline] (56.722 ms) : 0, 56722
AppSec [candidate] (55.617 ms) : 0, 55617
IAST [baseline] (22.126 ms) : 0, 22126
IAST [candidate] (23.226 ms) : 0, 23226
Remote Config [baseline] (618.266 µs) : 0, 618
Remote Config [candidate] (630.928 µs) : 0, 631
Telemetry [baseline] (7.1 ms) : 0, 7100
Telemetry [candidate] (7.173 ms) : 0, 7173
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.046 ms) : 0, 801046
BytebuddyAgent [candidate] (808.062 ms) : 0, 808062
GlobalTracer [baseline] (302.641 ms) : 0, 302641
GlobalTracer [candidate] (305.623 ms) : 0, 305623
AppSec [baseline] (54.773 ms) : 0, 54773
AppSec [candidate] (55.984 ms) : 0, 55984
IAST [baseline] (23.028 ms) : 0, 23028
IAST [candidate] (23.789 ms) : 0, 23789
Remote Config [baseline] (594.072 µs) : 0, 594
Remote Config [candidate] (627.873 µs) : 0, 628
Telemetry [baseline] (6.967 ms) : 0, 6967
Telemetry [candidate] (7.038 ms) : 0, 7038
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079526
Total [baseline] (10.447 s) : 0, 10447492
Agent [candidate] (1.07 s) : 0, 1069768
Total [candidate] (10.39 s) : 0, 10390228
section appsec
Agent [baseline] (1.21 s) : 0, 1210469
Total [baseline] (10.645 s) : 0, 10644650
Agent [candidate] (1.208 s) : 0, 1207865
Total [candidate] (10.589 s) : 0, 10588578
section iast
Agent [baseline] (1.2 s) : 0, 1200199
Total [baseline] (10.908 s) : 0, 10907680
Agent [candidate] (1.198 s) : 0, 1198078
Total [candidate] (10.866 s) : 0, 10865679
section profiling
Agent [baseline] (1.281 s) : 0, 1281335
Total [baseline] (10.719 s) : 0, 10718913
Agent [candidate] (1.27 s) : 0, 1270133
Total [candidate] (10.644 s) : 0, 10644392
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.072 ms) : 0, 688072
BytebuddyAgent [candidate] (682.414 ms) : 0, 682414
GlobalTracer [baseline] (315.154 ms) : 0, 315154
GlobalTracer [candidate] (311.222 ms) : 0, 311222
AppSec [baseline] (54.202 ms) : 0, 54202
AppSec [candidate] (53.974 ms) : 0, 53974
Remote Config [baseline] (677.84 µs) : 0, 678
Remote Config [candidate] (674.417 µs) : 0, 674
Telemetry [baseline] (7.55 ms) : 0, 7550
Telemetry [candidate] (7.743 ms) : 0, 7743
section appsec
BytebuddyAgent [baseline] (702.304 ms) : 0, 702304
BytebuddyAgent [candidate] (702.306 ms) : 0, 702306
GlobalTracer [baseline] (310.68 ms) : 0, 310680
GlobalTracer [candidate] (308.514 ms) : 0, 308514
AppSec [baseline] (162.632 ms) : 0, 162632
AppSec [candidate] (163.28 ms) : 0, 163280
IAST [baseline] (20.283 ms) : 0, 20283
IAST [candidate] (20.771 ms) : 0, 20771
Remote Config [baseline] (644.79 µs) : 0, 645
Remote Config [candidate] (648.354 µs) : 0, 648
Telemetry [baseline] (10.266 ms) : 0, 10266
Telemetry [candidate] (8.919 ms) : 0, 8919
section iast
BytebuddyAgent [baseline] (798.019 ms) : 0, 798019
BytebuddyAgent [candidate] (796.868 ms) : 0, 796868
GlobalTracer [baseline] (301.969 ms) : 0, 301969
GlobalTracer [candidate] (300.333 ms) : 0, 300333
AppSec [baseline] (57.375 ms) : 0, 57375
AppSec [candidate] (51.326 ms) : 0, 51326
IAST [baseline] (21.378 ms) : 0, 21378
IAST [candidate] (28.125 ms) : 0, 28125
Remote Config [baseline] (601.611 µs) : 0, 602
Remote Config [candidate] (614.719 µs) : 0, 615
Telemetry [baseline] (7.123 ms) : 0, 7123
Telemetry [candidate] (7.024 ms) : 0, 7024
section profiling
BytebuddyAgent [baseline] (681.795 ms) : 0, 681795
BytebuddyAgent [candidate] (676.256 ms) : 0, 676256
GlobalTracer [baseline] (398.991 ms) : 0, 398991
GlobalTracer [candidate] (394.264 ms) : 0, 394264
AppSec [baseline] (55.493 ms) : 0, 55493
AppSec [candidate] (55.083 ms) : 0, 55083
Remote Config [baseline] (664.403 µs) : 0, 664
Remote Config [candidate] (659.565 µs) : 0, 660
Telemetry [baseline] (7.556 ms) : 0, 7556
Telemetry [candidate] (7.471 ms) : 0, 7471
ProfilingAgent [baseline] (97.634 ms) : 0, 97634
ProfilingAgent [candidate] (97.589 ms) : 0, 97589
Profiling [baseline] (97.657 ms) : 0, 97657
Profiling [candidate] (97.612 ms) : 0, 97612
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1361
. : milestone, 1342,
appsec (1.721 ms) : 1697, 1746
. : milestone, 1721,
appsec_no_iast (1.712 ms) : 1688, 1735
. : milestone, 1712,
iast (1.463 ms) : 1440, 1486
. : milestone, 1463,
profiling (1.468 ms) : 1444, 1492
. : milestone, 1468,
tracing (1.466 ms) : 1441, 1490
. : milestone, 1466,
section candidate
no_agent (1.346 ms) : 1326, 1366
. : milestone, 1346,
appsec (1.714 ms) : 1690, 1739
. : milestone, 1714,
appsec_no_iast (1.702 ms) : 1678, 1727
. : milestone, 1702,
iast (1.473 ms) : 1450, 1495
. : milestone, 1473,
profiling (1.466 ms) : 1442, 1490
. : milestone, 1466,
tracing (1.441 ms) : 1417, 1465
. : milestone, 1441,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section baseline
no_agent (368.04 µs) : 349, 388
. : milestone, 368,
iast (486.607 µs) : 465, 508
. : milestone, 487,
iast_FULL (549.251 µs) : 528, 570
. : milestone, 549,
iast_GLOBAL (511.053 µs) : 489, 533
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (486.554 µs) : 465, 508
. : milestone, 487,
iast_INACTIVE (441.934 µs) : 421, 462
. : milestone, 442,
iast_TELEMETRY_OFF (465.366 µs) : 444, 486
. : milestone, 465,
tracing (442.596 µs) : 420, 465
. : milestone, 443,
section candidate
no_agent (368.108 µs) : 348, 388
. : milestone, 368,
iast (480.911 µs) : 460, 502
. : milestone, 481,
iast_FULL (549.532 µs) : 528, 571
. : milestone, 550,
iast_GLOBAL (502.558 µs) : 481, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (481.979 µs) : 461, 503
. : milestone, 482,
iast_INACTIVE (446.3 µs) : 425, 468
. : milestone, 446,
iast_TELEMETRY_OFF (468.286 µs) : 447, 490
. : milestone, 468,
tracing (442.356 µs) : 421, 464
. : milestone, 442,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.327 ms) : 2286, 2368
. : milestone, 2327,
iast (2.087 ms) : 2035, 2138
. : milestone, 2087,
iast_GLOBAL (2.12 ms) : 2068, 2173
. : milestone, 2120,
profiling (1.926 ms) : 1885, 1967
. : milestone, 1926,
tracing (1.926 ms) : 1886, 1965
. : milestone, 1926,
section candidate
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (2.328 ms) : 2288, 2369
. : milestone, 2328,
iast (2.076 ms) : 2024, 2127
. : milestone, 2076,
iast_GLOBAL (2.117 ms) : 2066, 2169
. : milestone, 2117,
profiling (1.931 ms) : 1889, 1973
. : milestone, 1931,
tracing (1.93 ms) : 1890, 1969
. : milestone, 1930,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~0b14c1edb4, baseline=1.41.0-SNAPSHOT~f74856b0fd
dateFormat X
axisFormat %s
section baseline
no_agent (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
appsec (15.316 s) : 15316000, 15316000
. : milestone, 15316000,
iast (19.083 s) : 19083000, 19083000
. : milestone, 19083000,
iast_GLOBAL (18.293 s) : 18293000, 18293000
. : milestone, 18293000,
profiling (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
tracing (15.329 s) : 15329000, 15329000
. : milestone, 15329000,
section candidate
no_agent (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
appsec (15.353 s) : 15353000, 15353000
. : milestone, 15353000,
iast (19.133 s) : 19133000, 19133000
. : milestone, 19133000,
iast_GLOBAL (17.888 s) : 17888000, 17888000
. : milestone, 17888000,
profiling (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
tracing (15.303 s) : 15303000, 15303000
. : milestone, 15303000,
|
smola
approved these changes
Oct 16, 2024
nikita-tkachenko-datadog
merged commit Oct 16, 2024
0bf75a3
into
release/v1.40.x
94 of 98 checks passed
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7736
branch
October 16, 2024 09:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #7736
What Does This Do
Updates Jacoco version that is bundled with the tracer.
Motivation
Jacoco is used, among other things, for parsing coverage data gathered by the JVMs that run the tests.
If the customer's project is using a newer version of Jacoco, the coverage data may not be compatible with the older version that the tracer uses.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]